From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60563)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dr2DT-0005UE-F4
	for guix-patches@gnu.org; Sun, 10 Sep 2017 09:24:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dr2DS-00030o-KS
	for guix-patches@gnu.org; Sun, 10 Sep 2017 09:24:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49895)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dr2DS-00030k-GG
	for guix-patches@gnu.org; Sun, 10 Sep 2017 09:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dr2DS-0007Ac-5I
	for guix-patches@gnu.org; Sun, 10 Sep 2017 09:24:02 -0400
Subject: [bug#28177] [PATCH 01/12] gnu: Add discount.
Resent-Message-ID: <handler.28177.B28177.150504983227546@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170821190443.7056f624@cbaines.net>
	<20170821180832.23356-1-mail@cbaines.net>
Date: Sun, 10 Sep 2017 15:23:41 +0200
In-Reply-To: <20170821180832.23356-1-mail@cbaines.net> (Christopher Baines's
	message of "Mon, 21 Aug 2017 19:08:21 +0100")
Message-ID: <87ingq7kma.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 28177@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> skribis:

> This is required by perl-text-markdown-discount, which is required by iki=
wiki.
>
> * gnu/packages/markdown.scm (discount) New variable.

[...]

> +         (add-before 'configure 'set_ac_default_path
> +           (lambda args
> +             (substitute* "configure.inc"
> +               (("ac_default_path=3D\".*\"")
> +                (string-append "ac_default_path=3D\"" (getenv "PATH") "\=
"")))
> +             #t)))))

Did you check the references of the resulting store item?  It seems to
me that we might end up referring too much if this value is recorded in
the binary (GCC, Binutils, Make, etc.).

Perhaps we should instead set it to a very specific list, say coreutils,
grep, sed, or whatever is expected?

Thanks,
Ludo=E2=80=99.