From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxJqH-0004f7-Lj for guix-patches@gnu.org; Wed, 27 Sep 2017 17:26:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxJqE-0003zO-G9 for guix-patches@gnu.org; Wed, 27 Sep 2017 17:26:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55049) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxJqE-0003zJ-CT for guix-patches@gnu.org; Wed, 27 Sep 2017 17:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dxJqE-0002tj-2s for guix-patches@gnu.org; Wed, 27 Sep 2017 17:26:02 -0400 Subject: [bug#28593] [PATCH] gnu: openfoam: Clean up to reduce closure. Resent-Message-ID: From: Dave Love References: <20170925104459.17798-1-fx@gnu.org> <87fubbj5yr.fsf@gnu.org> <1506426036.2423.32.camel@tourbillion-technology.com> Date: Wed, 27 Sep 2017 22:25:02 +0100 In-Reply-To: <1506426036.2423.32.camel@tourbillion-technology.com> (Paul Garlick's message of "Tue, 26 Sep 2017 12:40:36 +0100") Message-ID: <87ing3sukx.fsf@albion.it.manchester.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Paul Garlick Cc: 28593@debbugs.gnu.org Paul Garlick writes: > This suggests that the binaries in .../bin and .../lib are being > stripped. =A0However, if I check a randomly-selected executable in the > bin directory: > > $ objdump --syms /home/paul/.guix-profile/lib/OpenFOAM- > 4.1/platforms/linux64GccDPInt32Opt/bin/blockMesh | grep debug > > 0000000000000000=A0=A0=A0=A0=A0=A0=A0O *UND* 0000000000000000=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0_ZN > 4Foam8fileName5debugE > 0000000000000000=A0=A0=A0=A0=A0=A0=A0O *UND* 0000000000000000=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0_ZN > 4Foam4word5debugE > > The 'file' command also reports that the executables and shared objects > are 'not stripped'. =A0Does adding a debug output achieve the effect of > stripping the binaries?=A0 That was confusing me too, and I was going to ask about it... >> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0(ze= ro? >> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= (system* "find" "-name" "*.o" "-delete")))) >> Rather: >>=20 >> =A0 (for-each delete-file (find-files "." "\\.o$")) I don't understand the need to avoid system(*), but I assumed the optimizations in find make it significantly faster then find-files -- is that not true? (Dealing with the file structure in openfoam is horribly slow when I've done builds on the NFS filesystems.) > Maybe. =A0We need to be careful that we not delete files which are needed > later on. =A0Typically, a user will copy part of the directory structure > to a subdirectory of $HOME and compile a new solver. =A0The OpenFOAM > 'wmake' utility takes care of the dependencies and re-compiles object > files as needed. =A0 > > So, object files under 'platforms/linux64GccDPInt32Opt/src' should be > safe to delete. =A0However, this needs to be checked to make sure no > dependencies are deleted that cannot easily be re-compiled. =A0Have you > already checked this Dave by, for example, re-compiling a standard > solver? > > Paul. Not in this case, but people have been using my rpm version in anger, though it's an earlier version. (I was looking at this partly to help updating the rpm.) I'd have expected to have to regenerate the dependency files when modifying the source. [I wish openfoam had a sane build system, even one that stopped on an error, sigh. Actually, it might be worth patching that, like the rpm -- I've several times missed components not being built -- assuming that hasn't changed.]