From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Janssen Subject: Re: 01/01: gnu: vlc: Enable libdvdread and libdvdcss support. Date: Thu, 04 Jan 2018 16:27:19 +0100 Message-ID: <87inch4pbc.fsf@gnu.org> References: <20180103234811.7224.89557@vcs0.savannah.gnu.org> <20180103234812.5D12F21A06@vcs0.savannah.gnu.org> <87tvw2vzf5.fsf@netris.org> <20180104115022.36cd9da2@scratchpost.org> <87k1wx4td2.fsf@gnu.org> <20180104154006.04b658ea@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX7QU-0001Xs-Vt for guix-devel@gnu.org; Thu, 04 Jan 2018 10:27:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX7QR-0007LT-Dx for guix-devel@gnu.org; Thu, 04 Jan 2018 10:27:26 -0500 In-reply-to: <20180104154006.04b658ea@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > Hi Roel, > > On Thu, 04 Jan 2018 14:59:53 +0100 > Roel Janssen wrote: > >> I can confirm that this fixes the build of gnome-disk-utility. >> >> Should we fix dvdread.pc, or propagate it with libdvdread? > > I think we should propagate. If libdvdread is requiring libdvdcss (whether private or not) then libdvdcss ['s pc file] should be there when libdvdread is used... In that case, may I apply the attached patch? Thanks! Kind regards, Roel Janssen --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-vlc-Enable-libdvdread-and-libdvdcss-support.patch Content-Transfer-Encoding: 8bit >From b7fa57648b5cd45a5ce4f234c99c42fad42366b4 Mon Sep 17 00:00:00 2001 From: Roel Janssen Date: Thu, 4 Jan 2018 16:25:44 +0100 Subject: [PATCH] gnu: vlc: Enable libdvdread and libdvdcss support. * gnu/packages/video.scm (libdvdread): Compile with libdvdcss support; (vlc): Add libdvdread as input. --- gnu/packages/video.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 2d638abfe..77a82bb9d 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -22,6 +22,7 @@ ;;; Copyright © 2017 Clément Lassieur ;;; Copyright © 2017 Gregor Giesen ;;; Copyright © 2017 Rutger Helling +;;; Copyright © 2018 Roel Janssen ;;; ;;; This file is part of GNU Guix. ;;; @@ -1357,6 +1358,12 @@ players, like VLC or MPlayer.") (base32 "0ayqiq0psq18rcp6f5pz82sxsq66v0kwv0y55dbrcg68plnxy71j")))) (build-system gnu-build-system) + (arguments + `(#:configure-flags '("--with-libdvdcss=yes"))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (propagated-inputs + `(("libdvdcss" ,libdvdcss))) (home-page "http://dvdnav.mplayerhq.hu/") (synopsis "Library for reading video DVDs") (description -- 2.15.1 --=-=-=--