From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0Wte-0000mi-SU for guix-patches@gnu.org; Mon, 26 Mar 2018 14:31:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0Wta-0005jA-TI for guix-patches@gnu.org; Mon, 26 Mar 2018 14:31:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46835) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0Wta-0005j4-NZ for guix-patches@gnu.org; Mon, 26 Mar 2018 14:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f0Wta-0005db-Bl for guix-patches@gnu.org; Mon, 26 Mar 2018 14:31:02 -0400 Subject: [bug#30678] [PATCH] Update VLC to 3.0.1 Resent-Message-ID: From: Marius Bakke In-Reply-To: References: Date: Mon, 26 Mar 2018 20:30:38 +0200 Message-ID: <87in9iit9t.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: miles.harvey@runbox.com, 30678@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello! Sorry for the sloooow response. miles.harvey@runbox.com writes: > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 8190b0ffc..d668d8235 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm Can you resubmit this patch using "git format-patch"? Please also take a look at the git log for conventions. Some comments below. > (build-system gnu-build-system) > (native-inputs > `(("git" ,git) ; needed for a test > + ("gcc" ,gcc) Do you know why GCC is needed? Normally the one provided by gnu-build-system is sufficient. > @@ -857,16 +863,54 @@ audio/video codec library.") > ("perl" ,perl) > ("pulseaudio" ,pulseaudio) > ("python" ,python-wrapper) > - ("qtbase" ,qtbase) > + ;; Qt required instead of just qtbase as it was > + ;; before, otherwise check_POTFILES.sh test fails. > + ("qt" ,qt)=20 The "qt" package frequently lags behind the "modular" Qt, so we try to get rid of the former. Maybe it requires some of the other Qt "modules"? What is the error message? > ("qtx11extras" ,qtx11extras) > ("sdl" ,sdl) > ("sdl-image" ,sdl-image) > ("speex" ,speex) > ("x265" ,x265) > - ("xcb-util-keysyms" ,xcb-util-keysyms))) > + ("xcb-util-keysyms" ,xcb-util-keysyms) > + ;Optional inputs > + ;("lua" ,lua) ;Configure phase doesn't find this > + ("libarchive" ,libarchive) > + ("livemedia-utils" ,livemedia-utils) > + ("libbluray" ,libbluray) > + ("samba" ,samba) > + ;("nfs-utils" ,(@ (gnu packages nfs) nfs-utils)) ;configure phase= doesn't find this > + ;("freerdp" ,(@ (gnu packages rdesktop) freerdp)) ;causes compila= tion failure > + ("libshout" ,libshout) > + ("libebml" ,libebml) > + ("libmatroska" ,libmatroska) > + ("libmodplug" ,libmodplug) > + ("mpg123" ,mpg123) > + ;("gstreamer" > + ; ,(@ (gnu packages gstreamer) gstreamer)) ;configure phase doesn= 't find this. > + ("libva" ,libva) > + ("twolame" ,twolame) > + ("libdca" ,libdca) > + ("libmpeg2" ,libmpeg2) > + ("speexdsp" ,speexdsp) > + ("fluidsynth" ,fluidsynth) > + ("libass" ,libass) > + ("fribidi" ,fribidi) > + ("librsvg" ,librsvg) > + ("libcaca" ,libcaca) > + ("jack" ,jack-1) > + ("soxr" ,soxr) > + ("chromaprint" ,chromaprint) > + ("protobuf" ,protobuf) > + ("eudev" ,eudev) > + ("libmtp" ,libmtp) > + ("libupnp" ,libupnp) > + ("taglib" ,taglib) > + ("libsecret" ,libsecret) > + ("libnotify" ,libnotify))) Wooooow, that's a lot of new dependencies! Can you preserve the alphabetical sorting of inputs? Thanks for working on it! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlq5PE4ACgkQoqBt8qM6 VPoRnQgAzawdpW058oxSmHwq51ujVM0HxOQ8wDWRBSUSc2KjLAfjW0u9B9L08JC0 KHqh34u1ShqrDN+I3Z12DzxPPPJXEBJm8nHt0C3COMe7Zh8uP6WmP0m9LPqIAalt xg4PzkypRwsIwoTrop3gEemkDT53bDALULYc7v99P1rMJI9kZn2WTwd8ktv2oW78 gchqsVfDZwYV1/oGFZN4Un78PleJ6PVHFi8ksmBGuQs961RQitMwTZMgjLdKvF/M V5UJuB1zBujsGJGSISbBAstIG3gR+HeKwqthQJuSbpr/fZWMnoldIk2N8Kwo7l/p B4va92cDg8TmXZvUVVdVXyy2V4hp7A== =gM8p -----END PGP SIGNATURE----- --=-=-=--