From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 03/07: gnu: libfive: Add snippet, enable tests and remove obsolete phase. Date: Thu, 19 Apr 2018 08:26:22 -0400 Message-ID: <87in8nidqp.fsf@netris.org> References: <20180419095903.21090.36781@vcs0.savannah.gnu.org> <20180419095904.D9E2D204EE@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f98es-0000Tk-9f for guix-devel@gnu.org; Thu, 19 Apr 2018 08:27:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f98en-00046A-QS for guix-devel@gnu.org; Thu, 19 Apr 2018 08:27:26 -0400 In-Reply-To: <20180419095904.D9E2D204EE@vcs0.savannah.gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22's\?\= message of "Thu, 19 Apr 2018 05:59:04 -0400 (EDT)") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Hi Ludovic, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > civodul pushed a commit to branch master > in repository guix. > > commit 0818c01aefbaa7ecce5e310ec5f70886850a7f9c > Author: Diego Nicola Barbato > Date: Fri Apr 6 13:43:54 2018 +0200 > > gnu: libfive: Add snippet, enable tests and remove obsolete phase. >=20=20=20=20=20 > * gnu/packages/engineering.scm (libfive)[source]: Add snippet to > remove bundled catch. [...] > + (snippet > + ;; Remove bundled catch since we provide our own. > + '(delete-file "libfive/test/catch.hpp")))) It would be good to try to avoid adding more phases or snippets that return unspecified values. I fixed every snippet in 'core-updates', but I guess more passes will be needed as these errors continue to be introduced. Mark