From: Oleg Pykhalov <go.wigust@gmail.com>
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31178@debbugs.gnu.org, 31176@debbugs.gnu.org
Subject: [bug#31178] [PATCH] gnu: Add inxi.
Date: Mon, 23 Apr 2018 08:23:11 +0300 [thread overview]
Message-ID: <87in8ifqdc.fsf@gmail.com> (raw)
In-Reply-To: <87sh7mr17w.fsf@gmail.com> (Pierre Neidhardt's message of "Mon, 23 Apr 2018 10:03:23 +0530")
[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]
Hello Pierre and Ludovic,
Pierre Neidhardt <ambrevar@gmail.com> writes:
> I didn't know Oleg was going to submit a patch, maybe there was some
> confusion in the process :p
I've mentioned it in our mailing list discussion, see
https://lists.gnu.org/archive/html/help-guix/2018-04/msg00130.html
Nevertheless thank you for a 31178! :-)
> I've quickly reviewed our two patches. Overall I'd opt for mine :p
>
> - It's the latest version.
> - It has more inputs.
I thought that we stuck with an ‘inxi’ Perl script version (31178) and
there was no patch until I pushed one. It's better to get 31178 version
than 31176 ofcourse because of ‘inxi’ version.
But I don't like all those ‘propagated-inputs’ except ‘perl-*’ and I
guess we could do better. Maybe we could use PATH for non ‘perl-*’
inputs the same way as in 31176. WDYT?
> I think we should use propagated-inputs and not native-inputs. What do
> you think?
I'm not sure about 31178 currently. Usually we prefer to avoid
‘propagated-inputs’ if possible in Guix, because all ‘propagated-inputs’
will be in a Guix profile and could lead to collisions.
If you are talking about 31176, then no, because I've used a wrapper to
find all ‘inxi-minimal’ or ‘inxi’ requisites. It was easy to do,
because ‘inxi’ in 31176 is a Shell script, not a Perl script. Thanks to
Chris Marusich for an idea.
[…]
[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31176
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-04-23 5:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 12:38 [bug#31178] [PATCH] gnu: Add inxi Pierre Neidhardt
2018-04-22 21:42 ` [bug#31176] " Ludovic Courtès
2018-04-23 4:33 ` Pierre Neidhardt
2018-04-23 5:23 ` Oleg Pykhalov [this message]
2018-04-23 5:34 ` [bug#31176] " Pierre Neidhardt
2018-04-28 21:27 ` Ludovic Courtès
2018-04-29 17:38 ` Oleg Pykhalov
2018-04-30 10:07 ` Ludovic Courtès
2018-04-30 12:31 ` [bug#31176] " Pierre Neidhardt
2018-04-30 19:18 ` Oleg Pykhalov
2018-05-01 7:27 ` [bug#31178] [bug#31176] " Oleg Pykhalov
2018-05-06 9:42 ` Pierre Neidhardt
2018-05-06 13:31 ` Oleg Pykhalov
2018-05-07 10:14 ` Peter Neidhardt
2018-05-07 15:29 ` Oleg Pykhalov
2018-05-07 19:52 ` [bug#31176] " Peter Neidhardt
2018-05-08 18:11 ` [bug#31178] " Oleg Pykhalov
2018-04-30 13:17 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in8ifqdc.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=31176@debbugs.gnu.org \
--cc=31178@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.