From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fHnFX-0007JX-QI
	for guix-patches@gnu.org; Sun, 13 May 2018 05:25:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fHnFW-0000hi-Q6
	for guix-patches@gnu.org; Sun, 13 May 2018 05:25:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:52270)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fHnFW-0000he-Mm
	for guix-patches@gnu.org; Sun, 13 May 2018 05:25:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fHnFW-0003k6-BE
	for guix-patches@gnu.org; Sun, 13 May 2018 05:25:02 -0400
Subject: [bug#31416] [PATCH 1/4] system: Add os-with-u-boot.
Resent-Message-ID: <handler.31416.B31416.152620348114351@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180511143515.23435-1-dannym@scratchpost.org>
	<20180511143652.26935-1-dannym@scratchpost.org>
Date: Sun, 13 May 2018 11:24:30 +0200
In-Reply-To: <20180511143652.26935-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Fri, 11 May 2018 16:36:49 +0200")
Message-ID: <87in7rnc1d.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 31416@debbugs.gnu.org

Hello!

Great that you=E2=80=99re streamlining GuixSD on ARM!

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/system/install.scm (os-with-u-boot): New procedure.
> * gnu/packages/bootloaders.scm (make-u-boot-package): Export.
> * doc/guix.texi (Building the Installation Image for ARM boards): New
> subsection.

[...]

> +@subsection Building the Installation Image for ARM boards

=E2=80=9CBoards=E2=80=9D

> +Many ARM boards require a board-specific bootloader in order to boot.

Maybe: =E2=80=9Crequire a specific variant of the
@uref{http://www.denx.de/wiki/U-Boot/, U-Boot} bootloader.=E2=80=9D

> +If you build an entire disk image and the is not still available otherwi=
se
> +(on another available drive etc), it's advisable to build an image that
> +includes the bootloader, specifically:
> +
> +@example
> +guix system disk-image --system=3Darmhf-linux -e '((@ (gnu system instal=
l) os-with-u-boot) (@ (gnu system install) installation-os) "A20-OLinuXino-=
Lime2")'
> +@end example

Note: In Texinfo you need to double all the at signs.

> +Or if you don't cross compile:

It=E2=80=99s not cross-compilation.  :-)

But I don=E2=80=99t think you need to repeat the command line.

> +"A20-OLinuXino-Lime2" is the name of the board.  If you specify an inval=
id
   ^
@code

> +board, you get a list.

I think the patch is otherwise OK.

Ludo=E2=80=99.