From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fL05e-0002Xa-3f for guix-patches@gnu.org; Tue, 22 May 2018 01:44:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fL05a-00045c-VY for guix-patches@gnu.org; Tue, 22 May 2018 01:44:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35614) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fL05a-00045T-Ot for guix-patches@gnu.org; Tue, 22 May 2018 01:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fL05a-0006T3-CP for guix-patches@gnu.org; Tue, 22 May 2018 01:44:02 -0400 Subject: [bug#31490] [PATCH] gnu: Add emacs-cmake-mode. Resent-Message-ID: From: Oleg Pykhalov References: <20180518122716.9272-1-go.wigust@gmail.com> <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> Date: Tue, 22 May 2018 08:43:41 +0300 In-Reply-To: <462AD6C1-4912-4999-BDC9-3B3AE7C2D07F@gmail.com> (Maxim Cournoyer's message of "Fri, 18 May 2018 13:07:07 +0000") Message-ID: <87in7gb5yq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Maxim Cournoyer Cc: 31490@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Maxim, Thank you for review. Maxim Cournoyer writes: > On May 18, 2018 12:27:16 PM UTC, Oleg Pykhalov wrot= e: >>* gnu/packages/cmake.scm (emacs-cmake-mode): New public variable. >>--- >> gnu/packages/cmake.scm | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> [=E2=80=A6] > Should we delete the Emacs mode files from our cmake package to not > have duplication in the store when installing both CMake and > emacs-cmake-mode? Sure, we should. Could I push the following patch to core-updates? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-cmake-Delete-Emacs-library.patch Content-Transfer-Encoding: quoted-printable Content-Description: gnu: cmake: Delete Emacs library. From=2046cb6d48c7fd7712fca1d5619d02eba992b9182a Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Tue, 22 May 2018 07:41:45 +0300 Subject: [PATCH] gnu: cmake: Delete Emacs library. * gnu/packages/finance.scm (cmake)[arguments]: Delete Emacs library. =2D-- gnu/packages/cmake.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/cmake.scm b/gnu/packages/cmake.scm index e9fa86641..5f4a3c846 100644 =2D-- a/gnu/packages/cmake.scm +++ b/gnu/packages/cmake.scm @@ -85,6 +85,13 @@ " --exclude-regex ^\\(" (string-join skipped-tests "\\|") "\\)$= "))) #:phases (modify-phases %standard-phases + (add-after 'unpack 'split-package + ;; Remove files that have been packaged in other package recipe= s. + (lambda _ + (delete-file "Auxiliary/cmake-mode.el") + (substitute* "Auxiliary/CMakeLists.txt" + (("install\\(FILES cmake-mode.el \ +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") "")))) (add-before 'configure 'patch-bin-sh (lambda _ ;; Replace "/bin/sh" by the right path in... a lot of =2D-=20 2.17.0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 DQpb4oCmXQ0KDQpPbGVnLg0K --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlsDrg4ACgkQckbhHGm3 lWnr/Q//UXl+iJA/u5axeAWESEBR55eO9nGkf64uw8CBnvgS02Axep8QYv4Hel/k ezSBJRtVv1OPepsoQiiScEQ3TUubLLTOvmOy6Zpw0w+B7x+Cj2kyjSBvZoxrem4x yZ1eImbvwDP44RTnCMRix5f1xYK8+Lmd0rDT69NmFroigud5103J2BdxiKQfdu8K /oEYGi6H4GEaewLX6vlZ7CKGoS60/5KbEOatPnGTeWW3g2kTHH/KjqZQeI+uvHMT miyetX/73agFdQghGwK5wVZUU/WIJY+hFznJdn5GrFB7lPDFhH7lBMlxxaEqioMP rFlqNL/tDcP+CfV7tqK1tsOH3fKUr163lMlPBVnECgC3rpx50Lre1WdeUW4ka3Bd vr6bMsFFpDpWwsAjGwjao5D3Ww4GMaiXFgO+YJd+KuHB+6v8FS3QxZhgx3Pra2SF 3ViuvE9YtM1ZoV8dKfVci0hsRmRDLN94EIvysSPXXCrRQ8Fuc6zAgeCrore8IxUV hrMTky0dZhfF0BCdxXA5Fnf25bYtk/IAP4hE22MFd3AP13qo2mEq+ciAdsFg5ps/ V1YLvBVhAD6PkhIc/7a/udRmojivIbZrUHroaTHMCoBz/3gzV1cxUCVNtvK+2LBu q/AuICWuhFkYNiUqUNxQJkqpFpyQ8NDg7mKb65FRb2YJDPSMKd0= =EmEv -----END PGP SIGNATURE----- --==-=-=--