From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: GSoC: Adding a web interface similar to the Hydra web interface Date: Mon, 28 May 2018 12:39:09 +0200 Message-ID: <87in78hxo2.fsf@elephly.net> References: <87vac3twbe.fsf@gnu.org> <87o9hog2ye.fsf@elephly.net> <87d0xyn9zs.fsf@elephly.net> <87d0xswvls.fsf@elephly.net> <87r2m4ntk4.fsf@mdc-berlin.de> <87tvqxy4i9.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNFZ2-0000oF-Go for guix-devel@gnu.org; Mon, 28 May 2018 06:39:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNFZ0-0001M7-Hy for guix-devel@gnu.org; Mon, 28 May 2018 06:39:44 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21074) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fNFZ0-0001LL-8f for guix-devel@gnu.org; Mon, 28 May 2018 06:39:42 -0400 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tatiana Sholokhova Cc: guix-devel@gnu.org Hi Tatiana, > I've just made a new commit. I tried to fix codestyle mistakes but I'm no= t > sure that I managed to cover them all. Thank you for making the extra effort! One more thing I=E2=80=99ve noticed is that your patches add trailing white= space to some lines (i.e. a line that ends on a space, or an empty line that only contains a space character), which we try to avoid. This is just a minor problem, but we would probably edit these commits to remove these whitespace changes before merging the commits into the =E2=80=9Cmaster=E2= =80=9D branch. You are welcome to rewrite history in the =E2=80=9Cweb-interface=E2=80=9D b= ranch, i.e. you can fix the previous commits in your local repository and then force push them to =E2=80=9Cweb-interface=E2=80=9D. (Please be extra caref= ul not to force push to the =E2=80=9Cmaster=E2=80=9D branch.) Another thing I saw is things like this: '( something else =E2=80=A6) i.e. an opening parenthesis followed by a line break. Please try to avoid those. > I've added static files support and an example of css style file. > > Also, I've added new html templates displaying builds of a specification. > It is available via "/status/" or via a link from the main pag= e. Excellent. For your latest commit please use this commit message body instead: --8<---------------cut here---------------start------------->8--- * src/cuirass/http.scm (%static-directory, file-mime-types): New variables. (url-handler): Add handler for =E2=80=9C/status/=E2=80=9D; add h= andler for static files. * src/static/style.css: New file. =E2=80=A6 --8<---------------cut here---------------end--------------->8--- I recommend merging this commit with the previous commit. You can use =E2=80=9Cgit rebase -i $start=E2=80=9D to interactively rebase commits and = mark the last two commits to be squashed into one commit. Please reword the commit message as well. I know that this may seem like nitpicking, but it=E2=80=99s a good habit to acquire early =E2=80=94 fixing up commits at the very end is much harder in= my experience. > Now I'm not sure what I should display in the tables and what pages to > implement in the interface? I think it would be helpful if I have a more > realistic database for understanding database structure and testing > purposes. But I don't know how can I get one. You can download a copy of the Cuirass database as it is used on berlin.guixsd.org, one of the build farms of the Guix project. I have copied it here: http://bootstrappable.org/cuirass.db It is 12G(!), which indicates that Cuirass adds way too many entries than absolutely needed. Ludovic wrote on IRC that we don=E2=80=99t seem to check if a record already exists when two subsequent evaluations yield the same build. I have also put up a smaller database at http://bootstrappable.org/cuirass-small.db which also came from berlin.guixsd.org. I don=E2=80=99t know if that one w= ould be useful to you, though, as it is only 48kB in size. -- Ricardo