From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP9n4-0000lH-90 for guix-patches@gnu.org; Sat, 02 Jun 2018 12:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP9n1-0004uG-0m for guix-patches@gnu.org; Sat, 02 Jun 2018 12:54:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51608) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fP9n0-0004u6-UB for guix-patches@gnu.org; Sat, 02 Jun 2018 12:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fP9n0-0004Zy-HM for guix-patches@gnu.org; Sat, 02 Jun 2018 12:54:02 -0400 Subject: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast. Resent-Message-ID: References: <20180518184910.9987-16-ambrevar@gmail.com> <20180601075051.28276-1-ambrevar@gmail.com> <87zi0d5lsi.fsf@gnu.org> From: Pierre Neidhardt In-reply-to: <87zi0d5lsi.fsf@gnu.org> Date: Sat, 02 Jun 2018 18:53:24 +0200 Message-ID: <87in713zaz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31514@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Pierre Neidhardt skribis: > >> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable. > > [...] > >> + (package >> + (name "emacs-gif-screencast") >> + (version "20180309") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "https://github.com/Ambrevar/emacs-gif-screencast/archive/" >> + "825e606950ec842304bf75cf85baef707b853b03" >> + ".tar.gz")) > > Could you use the usual scheme for version numbers of Git snapshots > (info "(guix) Version Numbers")? I followed the form of emacs-zotxt that was just packaged. emacs-gif-screencast, like many other Emacs packages, has no version number. Do you suggest something like =2D-8<---------------cut here---------------start------------->8--- (let ((commit ...)) ; ... (gitversion "20180309" "1" commit) =2D-8<---------------cut here---------------end--------------->8--- ? >> + (propagated-inputs >> + `(("scrot" ,scrot) >> + ("imagemagick" ,imagemagick) >> + ("gifsicle" ,gifsicle))) > > Instead of propagating these, which could =E2=80=9Cpollute=E2=80=9D the u= ser=E2=80=99s profile, > could you hardcode the absolute file names of these programs in the .el > files? See how this is done for EMMS, for instance. Ack. =2D-=20 Pierre Neidhardt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlsSy4QACgkQm9z0l6S7 zH/nCAgAsQOM7uwnpXtSiLO+fr90OAC/qA5cQJpmYEBLwQb5MQfgYkYkqeWVYLze qASL2J0wccDuAwE/axRCy6OAge4nEudZYjOvynUey/Ez3RVbzxT3jjo2y8tgLfRN wNA3cYC+Gh3p9CCGQdY3SD+O5CJKsuTDd3fJ6Of3adXa9XhOdIAfcwpMLucVTHHW gMUVqP5JvNWdFfW51yxs05hXFzsSme6CIhKXSiwgeeNj+9kmPcJXY2xMWyznziWV +mKLBFIaYIdLduAJ/YdPJs2QqOzRRGWnTdwgevcSuXM0Mz744BnRXy8xm0hs4pjl JZzZZLHpWcQYW600cimoHmeBkqDVYg== =0v+5 -----END PGP SIGNATURE----- --=-=-=--