From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47087)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fRJbV-0000eD-Ds
	for guix-patches@gnu.org; Fri, 08 Jun 2018 11:47:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fRJbS-0007Kp-Ad
	for guix-patches@gnu.org; Fri, 08 Jun 2018 11:47:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:60196)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fRJbS-0007Kh-6t
	for guix-patches@gnu.org; Fri, 08 Jun 2018 11:47:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fRJbR-0008Is-Qk
	for guix-patches@gnu.org; Fri, 08 Jun 2018 11:47:01 -0400
Subject: [bug#31687] [PATCH] services: Add dnsmasq-service-type.
Resent-Message-ID: <handler.31687.B31687.152847277631865@debbugs.gnu.org>
From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=)
References: <20180602152814.14217-1-iyzsong@member.fsf.org>
	<87bmcll4o3.fsf@gnu.org>
Date: Fri, 08 Jun 2018 23:45:26 +0800
In-Reply-To: <87bmcll4o3.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Fri, 08 Jun 2018 16:43:40 +0200")
Message-ID: <87in6tl1t5.fsf@member.fsf.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 31687@debbugs.gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> Hello!
>
> Thanks for this patch, that looks like a useful service to have!
>
> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@member.fsf.org> skribis:
>
>> +@item @code{no-negcache?} (default: @code{#f})
>> +When true, disable negative caching.
>
> Minor issues:
>
>   =E2=80=A2 The general guideline is to avoid abbreviations in identifier=
s=E2=80=94we=E2=80=99re
>     using the language that comes with =E2=80=98call-with-current-continu=
ation=E2=80=99,
>     after all.  ;-)
>
>   =E2=80=A2 Another guideline is to avoid double-negations and the likes.
>
> So in this example, I would recommend:
>
>   =E2=80=98negative-caching?=E2=80=99 (default: #t)
>

Agree, I like this naming guideline, pushed :-)


> I think there=E2=80=99s a couple of other abbreviations.

It=E2=80=99s not clear to me whether other options are abbreviations or not=
 or
worth to expand.  eg: =E2=80=98no-hosts?=E2=80=99 and =E2=80=98no-resolv?=
=E2=80=99, they=E2=80=99re refer to the
well-known =E2=80=98/etc/hosts=E2=80=99 and =E2=80=98/etc/resolv.conf=E2=80=
=99 files, what could we use
instead?