From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdi9B-0005Yp-Pw
	for guix-patches@gnu.org; Thu, 12 Jul 2018 16:25:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdi98-0005Ns-KX
	for guix-patches@gnu.org; Thu, 12 Jul 2018 16:25:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49503)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fdi98-0005NS-5o
	for guix-patches@gnu.org; Thu, 12 Jul 2018 16:25:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fdi97-0005AG-O2
	for guix-patches@gnu.org; Thu, 12 Jul 2018 16:25:01 -0400
Subject: [bug#31999] [PATCH 6/7] gnu: Add libblockdev.
Resent-Message-ID: <handler.31999.B31999.153142705619788@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <20180628213527.23318-5-ambrevar@gmail.com>
References: <20180628213527.23318-1-ambrevar@gmail.com>
	<20180628213527.23318-5-ambrevar@gmail.com>
Date: Thu, 12 Jul 2018 22:24:11 +0200
Message-ID: <87in5k6w44.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Pierre Neidhardt <ambrevar@gmail.com>, 31999@debbugs.gnu.org

--=-=-=
Content-Type: text/plain

Pierre Neidhardt <ambrevar@gmail.com> writes:

> * gnu/package/disk.scm (libblockdev): New variable.

[...]

> +(define-public libblockdev
> +  (package
> +    (name "libblockdev")
> +    (version "2.17")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/rhinstaller/libblockdev")
> +                    (commit (string-append version "-1"))))
> +              (file-name (string-append name "-" version "-checkout"))
> +              (sha256
> +               (base32
> +                "14f52cj2qcnm8i2zb57qfpdk3kij2gb3xgqkbvidmf6sjicq84z2"))))


Note that this project provides uploaded releases, which are preferrable
to git checkouts, and won't suddenly change.  Could you change to that?

Otherwise LGTM, provided `guix lint` is happy :-)

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAltHuOsACgkQoqBt8qM6
VPoFlggAth8CxChfENWDvGhZW7kuBFivl5mb0KOBbWSsjhMl2jNq/DQyOBG6vPff
T9mrV1P5hRYVV8bF7vrng2KHbidmFqRyd++Pcxe9WrnTH7oM/eDmKuRq/kjyyWWC
tZoYDRD+6SvgsFkNMgBxQHD9N4FDw1CyO3gfIIvLCFs/xyCpSZ4e/TXzEM0J12Bo
OvIl1CZS3I5PXUOYTc7M0yzv6OzMgXUfWXmZJIV/8nxXCRoSnjnZLen31iXK/y6X
F8gy4p4auMdMu8bhhfPQT8o3zwZyk483760X9NIMmBD00LDWNl58qSU6X6fHzQHK
wDApxYoY+eOkghB8flr8pb7LIAWiog==
=AKJV
-----END PGP SIGNATURE-----
--=-=-=--