From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4w5m-00042U-T8 for guix-patches@gnu.org; Tue, 25 Sep 2018 18:46:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4w5i-0002dJ-RY for guix-patches@gnu.org; Tue, 25 Sep 2018 18:46:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49913) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g4w5i-0002cW-MM for guix-patches@gnu.org; Tue, 25 Sep 2018 18:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g4w5i-0007mU-JI for guix-patches@gnu.org; Tue, 25 Sep 2018 18:46:02 -0400 Subject: bug#32095: [PATCH 2/2] gnu: node: Update to 10.6.0. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <87lg7s71ky.fsf@gnu.org> References: <20180708152009.28002-1-mthl@gnu.org> <20180708152009.28002-2-mthl@gnu.org> <87muv0fo9d.fsf@gnu.org> <87pnxqus5x.fsf@gnu.org> <87a7oteeos.fsf@fastmail.com> <87tvn1z6ge.fsf@gnu.org> <87in2x36ys.fsf@gnu.org> <875zyxmttw.fsf@fastmail.com> <87h8ihbibh.fsf@gnu.org> <87worcl55u.fsf@fastmail.com> <87lg7s71ky.fsf@gnu.org> Date: Wed, 26 Sep 2018 00:45:26 +0200 Message-ID: <87in2tkxh5.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Lirzin Cc: 32095-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Mathieu Lirzin writes: > Marius Bakke writes: > >> I managed to build Node LTS on 'core-updates' with this patch: >> >> From 9556fc13a77d2619cfd1e861f0269bccf0a58986 Mon Sep 17 00:00:00 2001 >> From: Marius Bakke >> Date: Sun, 23 Sep 2018 13:12:23 +0200 >> Subject: [PATCH] gnu: Add Node LTS. >> >> * gnu/packages/libevent.scm (libuv-1.19): New public variable. >> * gnu/packages/node.scm (node)[arguments]: Adjust 'patch-files' phase to >> ignore missing files. >> (node-lts): New public variable. >> --- >> gnu/packages/libevent.scm | 13 +++++++++++++ >> gnu/packages/node.scm | 30 +++++++++++++++++++++++++++--- >> 2 files changed, 40 insertions(+), 3 deletions(-) > > Excellent! The patch looks good to me. It turned out the OpenSSL related test failure when I first tried this on 'master' was due to recently expired TLS certificates, and not due to a difference in OpenSSL version on 'core-updates'. So I pushed another patch to disable tests that require valid TLS certificates (it also caused the current Node package to FTBFS), and then the Node LTS patch to 'master'. Thanks for the review! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAluquoYACgkQoqBt8qM6 VPpD/Qf/d44K7rg+VariJRaPqasf8NIw3DV8aqH7L9Hovt9p3ahOOOrhPZG/iR7c QBMZIa4eNu7vydse7IZYmqUU4PbuCsJ5OgmPG70ecjFuYyGX3/6TWwbA9+i89QGH Fh82+OxKVtOtNI9N6LIxl47qfTwpum0OJ88R0xYQGQfF+wezpZoDagugoSQPvr+Y VztNmn9iZTs9b7bt4qXB2OWeEvO9s6eK9LDaGwrJnGD8hRA6Zx8V6KfOuVWoc+Ac wMS4RLwkb4EYg/GObh0pdeFomOLb+m04Oid3KTa7R1N0JJg3rMPEl0IqEti19kcn wIZzqUMTcpAN3rEl0l2NqX3T85lo5A== =reld -----END PGP SIGNATURE----- --=-=-=--