From: Marius Bakke <mbakke@fastmail.com>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: 32095-done@debbugs.gnu.org
Subject: bug#32095: [PATCH 2/2] gnu: node: Update to 10.6.0.
Date: Wed, 26 Sep 2018 00:45:26 +0200 [thread overview]
Message-ID: <87in2tkxh5.fsf@fastmail.com> (raw)
In-Reply-To: <87lg7s71ky.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
Mathieu Lirzin <mthl@gnu.org> writes:
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> I managed to build Node LTS on 'core-updates' with this patch:
>>
>> From 9556fc13a77d2619cfd1e861f0269bccf0a58986 Mon Sep 17 00:00:00 2001
>> From: Marius Bakke <mbakke@fastmail.com>
>> Date: Sun, 23 Sep 2018 13:12:23 +0200
>> Subject: [PATCH] gnu: Add Node LTS.
>>
>> * gnu/packages/libevent.scm (libuv-1.19): New public variable.
>> * gnu/packages/node.scm (node)[arguments]: Adjust 'patch-files' phase to
>> ignore missing files.
>> (node-lts): New public variable.
>> ---
>> gnu/packages/libevent.scm | 13 +++++++++++++
>> gnu/packages/node.scm | 30 +++++++++++++++++++++++++++---
>> 2 files changed, 40 insertions(+), 3 deletions(-)
>
> Excellent! The patch looks good to me.
It turned out the OpenSSL related test failure when I first tried this
on 'master' was due to recently expired TLS certificates, and not
due to a difference in OpenSSL version on 'core-updates'.
So I pushed another patch to disable tests that require valid TLS
certificates (it also caused the current Node package to FTBFS), and
then the Node LTS patch to 'master'.
Thanks for the review!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2018-09-25 22:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 15:16 [bug#32095] [PATCH 0/2] Update libuv and node Mathieu Lirzin
2018-07-08 15:20 ` [bug#32095] [PATCH 1/2] gnu: libuv: Update to 1.21.0 Mathieu Lirzin
2018-07-08 15:20 ` [bug#32095] [PATCH 2/2] gnu: node: Update to 10.6.0 Mathieu Lirzin
2018-07-09 14:59 ` Ludovic Courtès
2018-09-06 23:23 ` Mathieu Lirzin
2018-09-07 11:21 ` Marius Bakke
2018-07-09 14:58 ` [bug#32095] [PATCH 1/2] gnu: libuv: Update to 1.21.0 Ludovic Courtès
2018-07-09 15:08 ` Ludovic Courtès
2018-09-07 15:13 ` [bug#32095] [PATCH 2/2] gnu: node: Update to 10.6.0 Mathieu Lirzin
2018-09-22 15:08 ` Mathieu Lirzin
2018-09-22 15:32 ` Marius Bakke
2018-09-22 16:36 ` Mathieu Lirzin
2018-09-23 13:22 ` Marius Bakke
2018-09-23 14:03 ` Mathieu Lirzin
2018-09-25 22:45 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in2tkxh5.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=32095-done@debbugs.gnu.org \
--cc=mthl@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.