From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56422)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gPPdz-0001rv-UJ
	for guix-patches@gnu.org; Wed, 21 Nov 2018 05:22:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gPPdy-00081x-3h
	for guix-patches@gnu.org; Wed, 21 Nov 2018 05:22:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33555)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gPPdx-00081W-Vz
	for guix-patches@gnu.org; Wed, 21 Nov 2018 05:22:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gPPdx-0006vJ-Nq
	for guix-patches@gnu.org; Wed, 21 Nov 2018 05:22:01 -0500
Subject: [bug#33436] [PATCH] gnu: Add python-warcio.
Resent-Message-ID: <handler.33436.B33436.154279567626557@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <4f8816d0-8b47-7299-f31b-a2fa0f592d2d@riseup.net>
Date: Wed, 21 Nov 2018 11:21:06 +0100
In-Reply-To: <4f8816d0-8b47-7299-f31b-a2fa0f592d2d@riseup.net> (swedebugia's
	message of "Mon, 19 Nov 2018 21:41:46 +0100")
Message-ID: <87in0qu3xp.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: swedebugia <swedebugia@riseup.net>
Cc: 33436@debbugs.gnu.org

Hello!

swedebugia <swedebugia@riseup.net> skribis:

>>>From 537b2b111a464956bdec640ea5f84c4598ea66f9 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia@riseup.net>
> Date: Mon, 19 Nov 2018 21:37:46 +0100
> Subject: [PATCH] gnu: Add python-warcio.
>
> * gnu/packages/python.scm: New variable.
                           ^
Nitpick: You forgot the variable name here.  :-)

> +   (arguments
> +    ;; FIXME: Some tests require network access. 150 out of 1354 fail
> +    '(#:tests? #f))

Could you investigate a bit further?  What do the test logs show?

It would be good to see if these tests can be easily fixed, if they
should definitely be skipped (for instance because they rely on some
external service), or if it=E2=80=99s something else.

> +   (home-page "https://github.com/webrecorder/warcio")
> +   (synopsis "Streaming web archival archive (WARC) library")
> +   (description
> +    "warcio is designed for fast, low-level access to web archival
                 ^^
What about: =E2=80=9Cwarcio is a Python library to read and write the WARC =
format
commonly used in Web archives.  It is designed for=E2=80=A6=E2=80=9D?

Thank you,
Ludo=E2=80=99.