From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gleyO-0002k5-T5 for guix-patches@gnu.org; Mon, 21 Jan 2019 14:11:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gleyN-0004oF-1C for guix-patches@gnu.org; Mon, 21 Jan 2019 14:11:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gleyM-0004nM-R8 for guix-patches@gnu.org; Mon, 21 Jan 2019 14:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gleyM-0005er-FB for guix-patches@gnu.org; Mon, 21 Jan 2019 14:11:02 -0500 Subject: [bug#34056] [PATCH] core-updates -- gnu: python2: Fix test flags. Resent-Message-ID: References: <20190113071850.14337-1-ericbavier@centurylink.net> <8736pwjhes.fsf@cbaines.net> <20190113204242.55461ef2@centurylink.net> From: Christopher Baines In-reply-to: <20190113204242.55461ef2@centurylink.net> Date: Mon, 21 Jan 2019 19:10:06 +0000 Message-ID: <87imyhj08h.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Eric Bavier Cc: 34056@debbugs.gnu.org --=-=-= Content-Type: text/plain Eric Bavier writes: > On Sun, 13 Jan 2019 22:56:27 +0000 > Christopher Baines wrote: > >> ericbavier@centurylink.net writes: >> >> > From: Eric Bavier >> > >> > * gnu/packages/python.scm (python-2.7)[arguments]: 'EXTRATESTOPTS' -> >> > 'TESTOPTS'. This overrides the default '-l' argument for memory leak checks >> > which is not compatible with the -j for parallelism. >> > --- >> > gnu/packages/python.scm | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> > index 9b43f465cc..dffded738d 100644 >> > --- a/gnu/packages/python.scm >> > +++ b/gnu/packages/python.scm >> > @@ -194,7 +194,7 @@ >> > (assoc-ref %outputs "out") "/lib")) >> > ;; With no -j argument tests use all available cpus, so provide one. >> > #:make-flags >> > - (list (format #f "EXTRATESTOPTS=-j~d" (parallel-job-count))) >> > + (list (format #f "TESTOPTS=-j~d" (parallel-job-count))) >> > >> > #:modules ((ice-9 ftw) (ice-9 match) >> > (guix build utils) (guix build gnu-build-system)) >> >> Hey Eric, >> >> I've also been looking at some Python 2 things on core-updates today, >> trying to get the linkchecker package building again. >> >> I've just pushed a slightly different patch, but to this effect to >> core-updates, and only just seen this message, sorry about that. > > Not a problem. > >> Thanks for looking at it though, this approach is probably neater, as I >> used substitute* instead. > > Would you like to keep your patch, or apply this one instead? I'm quite happy to switch to this approach. I don't know whether the best way to do that is to switch out the patches by force-pushing to core-updates, or to just apply your patch on top though... Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlxGGQ9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfXUBAAi1pJXn8YsUImq5oC96kGHxqSeAqhTJ35zCno3pUhCnqf85rNhakCVrrr +msmIo5tvi5y/CtTKeVhH6KAtcXKBBEVzH8B/P08D7OuuqIazqE8EMEpWtWAM41p 569ADdDxUC1Eu8GOiqrCFnHVzKZ8pXx5fp3TXyh5IG2R2xczPM25j+1hQ8cJ5SAu gSyQF56qMCVSs8nxO0VpbvVv6WgKywMuoS7yYW+TETXS4p7Qalb23OxPM1VfyV/n uBm1RoBhDj3AtsNh0YXee1Gg22XiKuGpeBYDT40WvburR/pxxhRWeT9eOIzYQjAt /WfdnBn/2j6F4cndMBy1pxTVC+gkYZEsSCYWpwn2hVSR3zyzYkSj+rP/w7kc+BlG h8sfSKueHvlqF1vZGrntzBIYwoYMgw+b7BwDFtIHSoegTolE0ZJAz6Eq/ipGiXaf 50/H4rikXZ4dSWjoKg6CsyCWScmsYymfljh61X87p2LOx/QetcaMt0Ln+rkvAKoH naFO3x6WTFVr2vcO3DuhkCp4zQ151oI0U1qB1WkwISMtn3+IAcNtem/BSXd63fbI I7NPiBpxVur6d5mEu/5N49H7ZhswYVjYvTamdy3EmZGdI/Z+DMsoOauszDxrHPX5 pJksQ3UxDoPMc3v/64M6Fl8ek+Myw0eHSI5vWNL0PkZFPfa45Nc= =2LFR -----END PGP SIGNATURE----- --=-=-=--