From: "Ludovic Courtès" <ludo@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: guix: Simplify and robustify lzread!.
Date: Thu, 09 May 2019 16:27:24 +0200 [thread overview]
Message-ID: <87imujem9f.fsf@gnu.org> (raw)
In-Reply-To: <8736lpxm8i.fsf@ambrevar.xyz> (Pierre Neidhardt's message of "Wed, 08 May 2019 12:40:45 +0200")
Hi Pierre,
Pierre Neidhardt <mail@ambrevar.xyz> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi Pierre!
>>
>> guix-commits@gnu.org skribis:
>>
>>> commit ecfc54403e2a1934b4f6e84ddad429b7970091fa
>>> Author: Pierre Neidhardt <mail@ambrevar.xyz>
>>> Date: Tue May 7 18:40:40 2019 +0200
>>>
>>> guix: Simplify and robustify lzread!.
>> ^
>> Should be lzlib.
>
> Oops!
> I must confess that I never really understood the whole logic behind
> GNU-style commit message :p
It’s really Guix-specific here, but the idea is that the word before
colon indicates the part of the code being modified, to provide a bit of
context.
>> Could you add a test for this corner case? It’s corner cases like that
>> that can spoil the whole experience, so it feels safer to add tests as
>> soon as we encounter them. :-)
>
> I would have, but I don't know how. The problem is that I don't control
> the chunk size passed to the read! callback of the custom port. That's
> all up to Guile's implementation of custom ports.
>
> In practice, it seems that the BV is always big enough so the potential
> issue can never arise. But the new code is better on all aspects.
Didn’t you encounter the bug on an actual use case, though? If you did,
you could just write that use case in the test file. If not, that’s
okay.
(I’m super cautious here but that’s because I spent countless hours
debugging code that used zlib and libbz2 and lzo in the past. :-))
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-05-09 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190507164442.23834.73953@vcs0.savannah.gnu.org>
[not found] ` <20190507164443.0BEE2207FC@vcs0.savannah.gnu.org>
2019-05-08 9:52 ` 01/01: guix: Simplify and robustify lzread! Ludovic Courtès
2019-05-08 10:40 ` Pierre Neidhardt
2019-05-09 14:27 ` Ludovic Courtès [this message]
2019-05-09 15:42 ` Pierre Neidhardt
2019-05-10 21:40 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imujem9f.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.