From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:54953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hPw5s-0004Zo-SK
	for guix-patches@gnu.org; Sun, 12 May 2019 17:33:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hPvwx-0001aa-0I
	for guix-patches@gnu.org; Sun, 12 May 2019 17:24:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:58203)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hPvww-0001Yd-Su
	for guix-patches@gnu.org; Sun, 12 May 2019 17:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hPvww-0006hL-Hg
	for guix-patches@gnu.org; Sun, 12 May 2019 17:24:02 -0400
Subject: [bug#28128] [PATCH 2/2] scripts: system: Support container network
	sharing.
Resent-Message-ID: <handler.28128.B28128.155769622125719@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190313093610.1071-1-arunisaac@systemreboot.net>
	<20190313093610.1071-3-arunisaac@systemreboot.net>
	<87va0n80u5.fsf@gnu.org> <cu71s39usgi.fsf@systemreboot.net>
	<874l80tw60.fsf@gnu.org> <cu7h8bw7cqo.fsf@systemreboot.net>
	<871s2y7r71.fsf@inria.fr> <cu7ef6uwv04.fsf@systemreboot.net>
	<cu7v9yixyfd.fsf@systemreboot.net>
Date: Sun, 12 May 2019 23:23:28 +0200
In-Reply-To: <cu7v9yixyfd.fsf@systemreboot.net> (Arun Isaac's message of "Fri,
	10 May 2019 18:24:14 +0530")
Message-ID: <87imuftlin.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 28128@debbugs.gnu.org

Hi Arun!

Arun Isaac <arunisaac@systemreboot.net> skribis:

> I took too long, but here it is finally! Should I add any documentation
> about this new -N option to the manual?

Yes, please.

> From d5f6fb996f591c44d94fe578a5c41a830ddcb077 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Fri, 10 May 2019 16:56:16 +0530
> Subject: [PATCH] linux-container: Add support for container network shari=
ng.
>
> * gnu/system/linux-container.scm (container-essential-services): If netwo=
rk is
> to be shared with the host, remove network configuration files from etc
> service.
> (containerized-operating-system): If network is to be shared with the hos=
t,
> remove nscd service and map host's /var/run/nscd if it exists.
> (container-script): If network is to be shared with the host, do not crea=
te
> network namespace.
> * guix/scripts/system.scm (system-derivation-for-action): Add
> (perform-action): Add #:container-shared-network? argument.
> (show-help): Add "-N, --network" help information.
> (%options): Add network option.
> (process-action): Call perform-action with #container-shared-network? arg=
ument.
>
> Co-authored-by: Christopher Baines <mail@cbaines.net>

LGTM!  I guess this is what you wanted to achieve, Chris, right?

Thank you,
Ludo=E2=80=99.