From: Marius Bakke <mbakke@fastmail.com>
To: Ivan Petkov <ivanppetkov@gmail.com>, guix-devel <guix-devel@gnu.org>
Subject: Re: Rust dependency on git
Date: Fri, 24 May 2019 12:45:27 +0200 [thread overview]
Message-ID: <87imu0dtbs.fsf@devup.no> (raw)
In-Reply-To: <3DCD63BD-98AB-40AD-B294-CF4E699B20BA@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 974 bytes --]
Hi Ivan,
Ivan Petkov <ivanppetkov@gmail.com> writes:
> Hi Guix,
>
> The latest stable rust (version 1.35.0) appears to require git as a
> native-input since the tidy test (which checks for code formatting in the rust
> repo) fails because it cannot run `git ls-files`.
>
> I saw a comment in the rust package definition that git changes too frequently
> to be kept as an input[1]. Is anyone aware if this is still a problem?
> I'd rather avoid having to patch the test suite tools to ignore this test
> if it is as simple as adding "git" as a native input.
I would prefer to keep Git out of the Rust bootstrap still. The reason
is that I don't want to rebuild the whole toolchain for every Git update.
Obviously there are other ways to deal with that, so it's not a very
hard opinion.
It seems odd to me that the release tarballs would run 'git ls-files'
anyway. Do they actually contain a git repository? Would it work to
simply replace the invokation with 'find'?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-05-24 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 3:22 Rust dependency on git Ivan Petkov
2019-05-24 10:45 ` Marius Bakke [this message]
2019-05-25 19:32 ` Ivan Petkov
2019-07-19 5:55 ` Chris Marusich
2019-07-19 15:10 ` Ivan Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imu0dtbs.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=ivanppetkov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.