From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:41352)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ibB27-0000ir-0V
 for guix-patches@gnu.org; Sat, 30 Nov 2019 17:16:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ibB25-0005PO-CX
 for guix-patches@gnu.org; Sat, 30 Nov 2019 17:16:06 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57527)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ibB22-0005JG-60
 for guix-patches@gnu.org; Sat, 30 Nov 2019 17:16:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ibB22-0006BE-20
 for guix-patches@gnu.org; Sat, 30 Nov 2019 17:16:02 -0500
Subject: [bug#38440] [PATCH 0/5] Add the `qt` build-system.
Resent-Message-ID: <handler.38440.B38440.157515213223703@debbugs.gnu.org>
From: Brett Gilio <brettg@posteo.net>
References: <20191130215910.18891-1-h.goebel@crazy-compilers.com>
Date: Sat, 30 Nov 2019 16:15:30 -0600
In-Reply-To: <20191130215910.18891-1-h.goebel@crazy-compilers.com> (Hartmut
 Goebel's message of "Sat, 30 Nov 2019 22:59:10 +0100")
Message-ID: <87imn1m2nx.fsf@posteo.net>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 38440@debbugs.gnu.org

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Works and is a good substitude for `wrap-program` from `qt-utils`. This
> `wrap-program` is still kept, since some packagins not using the
> cmake-build-syttem use it.
>
> Like `wrap-program`, this implementation has one deficit: The
> wrapper collects paths from *all* inputs, thus e.g. cmake will become a
> dependency of *every* binary packages using qt-build-system.
>
> But contraty to `wrap-program` this implementation does not use env-vars to
> build the paths, but inputs. Thus it will be easier to solve the issue by
> filtering inputs.
>
> Comments on the code are heardy welcome.
>
> Also see
> <https://lists.gnu.org/archive/html/guix-devel/2019-11/msg00386.html>
> <https://lists.gnu.org/archive/html/guix-devel/2019-11/msg00391.html>
>
> Hartmut Goebel (5):
>   guix: Add the 'qt' build system.
>   gnu: sddm: Use qt-build-system.
>   gnu: ktouch: Use qt-build-system.
>   gnu: kdeconnect: Use qt-build-system.
>   gnu: quaternion: Use qt-build-system.
>
>  Makefile.am                       |   2 +
>  doc/guix.texi                     |  21 ++-
>  gnu/packages/display-managers.scm |  18 +-
>  gnu/packages/education.scm        |  17 +-
>  gnu/packages/kde.scm              |  18 +-
>  gnu/packages/messaging.scm        |  17 +-
>  guix/build-system/qt.scm          | 295 ++++++++++++++++++++++++++++++
>  guix/build/qt-build-system.scm    | 109 +++++++++++
>  8 files changed, 440 insertions(+), 57 deletions(-)
>  create mode 100644 guix/build-system/qt.scm
>  create mode 100644 guix/build/qt-build-system.scm

Hartmut,

LGTM! Thanks for your work.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/