From: Brett Gilio <brettg@posteo.net>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 38440@debbugs.gnu.org
Subject: [bug#38440] [PATCH 0/5] Add the `qt` build-system.
Date: Sat, 30 Nov 2019 16:15:30 -0600 [thread overview]
Message-ID: <87imn1m2nx.fsf@posteo.net> (raw)
In-Reply-To: <20191130215910.18891-1-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Sat, 30 Nov 2019 22:59:10 +0100")
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> Works and is a good substitude for `wrap-program` from `qt-utils`. This
> `wrap-program` is still kept, since some packagins not using the
> cmake-build-syttem use it.
>
> Like `wrap-program`, this implementation has one deficit: The
> wrapper collects paths from *all* inputs, thus e.g. cmake will become a
> dependency of *every* binary packages using qt-build-system.
>
> But contraty to `wrap-program` this implementation does not use env-vars to
> build the paths, but inputs. Thus it will be easier to solve the issue by
> filtering inputs.
>
> Comments on the code are heardy welcome.
>
> Also see
> <https://lists.gnu.org/archive/html/guix-devel/2019-11/msg00386.html>
> <https://lists.gnu.org/archive/html/guix-devel/2019-11/msg00391.html>
>
> Hartmut Goebel (5):
> guix: Add the 'qt' build system.
> gnu: sddm: Use qt-build-system.
> gnu: ktouch: Use qt-build-system.
> gnu: kdeconnect: Use qt-build-system.
> gnu: quaternion: Use qt-build-system.
>
> Makefile.am | 2 +
> doc/guix.texi | 21 ++-
> gnu/packages/display-managers.scm | 18 +-
> gnu/packages/education.scm | 17 +-
> gnu/packages/kde.scm | 18 +-
> gnu/packages/messaging.scm | 17 +-
> guix/build-system/qt.scm | 295 ++++++++++++++++++++++++++++++
> guix/build/qt-build-system.scm | 109 +++++++++++
> 8 files changed, 440 insertions(+), 57 deletions(-)
> create mode 100644 guix/build-system/qt.scm
> create mode 100644 guix/build/qt-build-system.scm
Hartmut,
LGTM! Thanks for your work.
--
Brett M. Gilio
https://git.sr.ht/~brettgilio/
next prev parent reply other threads:[~2019-11-30 22:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-30 21:59 [bug#38440] [PATCH 0/5] Add the `qt` build-system Hartmut Goebel
2019-11-30 22:00 ` [bug#38440] [PATCH 1/5] guix: Add the 'qt' build system Hartmut Goebel
2019-11-30 22:00 ` [bug#38440] [PATCH 2/5] gnu: sddm: Use qt-build-system Hartmut Goebel
2019-11-30 22:00 ` [bug#38440] [PATCH 3/5] gnu: ktouch: " Hartmut Goebel
2019-11-30 22:00 ` [bug#38440] [PATCH 4/5] gnu: kdeconnect: " Hartmut Goebel
2019-11-30 22:00 ` [bug#38440] [PATCH 5/5] gnu: quaternion: " Hartmut Goebel
2019-11-30 22:15 ` Brett Gilio [this message]
2019-12-01 19:28 ` bug#38440: [PATCH 0/5] Add the `qt` build-system Hartmut Goebel
2019-11-30 22:17 ` [bug#38440] [PATCH v2] guix: Add the 'qt' build system Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imn1m2nx.fsf@posteo.net \
--to=brettg@posteo.net \
--cc=38440@debbugs.gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.