From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:35562)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1isCO0-0006xm-E8
 for guix-patches@gnu.org; Thu, 16 Jan 2020 16:09:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1isCNz-0002Oe-8U
 for guix-patches@gnu.org; Thu, 16 Jan 2020 16:09:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:60701)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1isCNy-0002Ni-3o
 for guix-patches@gnu.org; Thu, 16 Jan 2020 16:09:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1isCNx-0008J0-V3
 for guix-patches@gnu.org; Thu, 16 Jan 2020 16:09:01 -0500
Subject: [bug#39086] [PATCH 3/5] gnu: Add unicode-cldr-common.
Resent-Message-ID: <handler.39086.B39086.157920890131878@debbugs.gnu.org>
References: <20200111120829.29821-1-leo.prikler@student.tugraz.at>
 <20200111120829.29821-3-leo.prikler@student.tugraz.at>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20200111120829.29821-3-leo.prikler@student.tugraz.at>
Date: Thu, 16 Jan 2020 22:08:09 +0100
Message-ID: <87imlbxg7a.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 39086@debbugs.gnu.org


Leo Prikler <leo.prikler@student.tugraz.at> writes:

> * gnu/packages/ibus (unicode-cldr-commmon): New package.

This should be:

    * gnu/packages/ibus.scm (unicode-cldr-commmon): New variable.

You know, I wonder if these things really belong to ibus.scm.  I
remember a TODO somewhere in the code that bemoaned the lack of
versioned Unicode data files.  Perhaps we should just add a new module
(gnu packages unicode) =E2=80=94 what do you think?

> +(define-public unicode-cldr-common
> +  (package
> +    (name "unicode-cldr-common")
> +    (version "36")
> +    (source
> +     (origin (method url-fetch/zipbomb)
> +             (uri "https://unicode.org/Public/cldr/36/cldr-common-36.0.z=
ip")
> +             (sha256
> +              (base32
> +
> "0hxsc3j5zb32hmiaj0r3ajchmklx6zng6zlh1ca6s9plq5b9w9q7"))))

The version should be =E2=80=9C36.0=E2=80=9D.  The source URI should refere=
nce the
version field twice.

> +    (description
> +     "The Unicode Common Locale Data Repository (CLDR) is a large reposi=
tory of
> +locale data, including among others
> +- patterns for formatting and parsing,
> +- name translations,
> +- and various informations on languages, scripts and country-specific
> +conventions.")
> +    (license unicode)))

Please use @enumerate or @itemize texinfo syntax here.

--=20
Ricardo