From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42506) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1XQJ-0006wc-MQ for guix-patches@gnu.org; Tue, 11 Feb 2020 10:26:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1XQI-00009G-9C for guix-patches@gnu.org; Tue, 11 Feb 2020 10:26:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51399) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1XQI-000095-5O for guix-patches@gnu.org; Tue, 11 Feb 2020 10:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1XQI-0002y0-0P for guix-patches@gnu.org; Tue, 11 Feb 2020 10:26:02 -0500 Subject: [bug#38546] [00/11] Update Julia, Fix precompilation, add HTTP.jl Resent-Message-ID: From: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti In-Reply-To: References: <87v9qpvbyr.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87wo9ouaq5.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87d0bcly8f.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <877e1jdd62.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> <87lfp9dusm.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> Date: Tue, 11 Feb 2020 16:24:52 +0100 Message-ID: <87imkddu4b.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: zimoun Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 38546@debbugs.gnu.org zimoun writes: Hi > On Tue, 11 Feb 2020 at 16:10, Nicol=C3=B2 Balzarotti wrote: > >> > 1. >> >> Do you have a special motivation to rename 'llvm-patch' to 'julia-pat= ch'? >> >> (I agree, it is better :-)) >> > >> Yes, because now it's not only used by llvm-julia but also by the new >> libunwind-julia. So calling llvm-patch a function that takes a patch >> from the julia repo and that is applied to a "julia module" is measleadi= ng. > > Ok. > > >> > 2. >> >> Well, only 2 inputs are missing. Do you think it is affordable to pack >> >> them and so remove the commentary? >> >> >> >> --8<---------------cut here---------------start------------->8--- >> >> ;; FIXME: The following inputs are downloaded from upstream to allow = us >> >> ;; to use the lightweight Julia release tarball. Ideally, these inpu= ts >> >> ;; would eventually be replaced with proper Guix packages. >> >> ;; Find dependencies versions here: >> >> ;; https://raw.githubusercontent.com/JuliaLang/julia/v1.3.0/deps/Vers= ions.make >> >> --8<---------------cut here---------------end--------------->8--- >> >> I indeed tried. The main problem is that in the Makefile there's no >> USE_SYSTEM_{OBJCONV/LIBWHICH}, and I didn't want to mess with the it. >> But yes, I think I could at least try again. > > Let me check how it will be crawled by SWH to be sure that Guix will > be able to still build Julia 1.3 even if GitHub does not exist > anymore. > And I am in favour to let these 2 inputs. > > >> > 3. >> >> Otherwise, there is some issues about indentation -- I think you use >> >> Emacs, so check that '.dir-locals.el' is correctly setup -- double >> >> space for sentences in description, >> >> 'patch/julia-SOURCE_DATE_EPOCH-mtime.patch' should be added with the >> >> same commit that "Update", etc. >> >> I have half-corrected so I can send you these 2 v2-patches if you wan= t to. :-) >> > >> If you already fixed them, yes please send a v2 patch and I'll continue >> working from there. > > Stay tuned. :-) > I try to send it today... > Don't worry, I'm still working on my PhD thesis so my spare time until the end of the week is low :D > >> Fine for me, do we need also to debug a broken test right? > > I do not know if the test are broken. I am not able to run them on my > desktop machine. Not enough memory. > Ok, so I'll run tests a few times on my server then > > Cheers, > simon Thanks, Nicol=C3=B2