From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 23/33: gnu: commencement: gcc-boot0: Build fix for the Hurd.
Date: Tue, 10 Mar 2020 10:13:37 +0100
Message-ID: <87imjcwp1a.fsf@gnu.org>
References: <20200310075832.7126.86402@vcs0.savannah.gnu.org>
 <20200310075850.035F02125B@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:56097)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>) id 1jBaxH-000446-Tn
 for guix-devel@gnu.org; Tue, 10 Mar 2020 05:13:40 -0400
In-Reply-To: <20200310075850.035F02125B@vcs0.savannah.gnu.org>
 (guix-commits@gnu.org's message of "Tue, 10 Mar 2020 03:58:49 -0400
 (EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: guix-devel@gnu.org, Jan Nieuwenhuizen <janneke@gnu.org>

guix-commits@gnu.org skribis:

> commit 7a57ca758c590742b63100944f07fddb7290f797
> Author: Jan Nieuwenhuizen <janneke@gnu.org>
> AuthorDate: Sun Mar 1 13:45:42 2020 +0100
>
>     gnu: commencement: gcc-boot0: Build fix for the Hurd.
>=20=20=20=20=20
>     Fixes:
>         g++   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE   -fno-excepti=
ons -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-=
strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedant=
ic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CON=
FIG_H -DGENERATOR_FILE -fno-PIE -static-libstdc++ -static-libgcc -Wl,-rpath=
=3D/gnu/store/vp2id82a597p119b3wyhhkhd467wvn78-glibc-bootstrap-0/lib -Wl,-d=
ynamic-linker -Wl,/gnu/store/vp2id82a597p119b3w [...]
>             build/genmddeps.o build/read-md.o build/errors.o ../build-i58=
6-unknown-gnu/libiberty/libiberty.a
>         /gnu/store/jk3kx5jwjs9m60svzk6sz79bf0w33l91-binutils-cross-boot0-=
2.34/bin/ld: build/read-md.o: in function `md_reader::~md_reader()':
>         /tmp/guix-build-gcc-cross-boot0-7.5.0.drv-0/build/gcc/../../gcc-7=
.5.0/gcc/read-md.c:1049: undefined reference to `operator delete(void*, uns=
igned int)'
>=20=20=20=20=20
>     This raises the question: Should libstdc++-boot0 (v4.9) be sufficient=
 to build
>     gcc-boot0 (v7.5.0)?

Hmm?  :-)

>     * gnu/packages/commencement.scm (gcc-boot0): Add static library path.

>                 `(,(string-append "LDFLAGS=3D"
> +                                 (if ,(hurd-system?)
> +                                     (string-append
> +                                      "-L" (assoc-ref %build-inputs "gcc=
") "/lib ")
> +                                     "")

Could you add a comment saying that this is to allow the =E2=80=98delete=E2=
=80=99
operator to be found?  Weird.

That=E2=80=99s it, thanks for the great work!

Ludo=E2=80=99.