From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36866) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJ8vW-0000A3-Uu for guix-patches@gnu.org; Tue, 31 Mar 2020 00:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJ8vV-00045R-Q9 for guix-patches@gnu.org; Tue, 31 Mar 2020 00:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jJ8vV-000458-Kq for guix-patches@gnu.org; Tue, 31 Mar 2020 00:55:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jJ8vV-00024f-JT for guix-patches@gnu.org; Tue, 31 Mar 2020 00:55:01 -0400 Subject: [bug#40291] gnu: packages: java: Add libantlr3c Resent-Message-ID: From: Maxim Cournoyer References: Date: Tue, 31 Mar 2020 00:53:59 -0400 In-Reply-To: (Raghav Gururajan's message of "Sat, 28 Mar 2020 18:24:57 +0000") Message-ID: <87imilxgyg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Raghav Gururajan Cc: 40291@debbugs.gnu.org Hello Raghav! You'll find my review of this patch below. For other readers, this is needed in preparation of Linphone, which requires it through its belle-sip dependency. "Raghav Gururajan" writes: > Hello Guix! > > Please find the attached patch to add "libantlr3c" package. > > Regards, > RG. > > From 791e2392aaa9a3202db90c1e50340c38bd001504 Mon Sep 17 00:00:00 2001 > From: Raghav Gururajan > Date: Sat, 28 Mar 2020 14:21:35 -0400 > Subject: [PATCH 6/6] gnu: packages: java: Add libantlr3c This should be: "gnu: Add libantlr3c." > * gnu/packages/java.scm (libantlr3c): New variable. > --- > gnu/packages/java.scm | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index 5154dc124e..400ef8795e 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -105,6 +105,35 @@ > ;; build framework. We then build the more recent JDKs Icedtea 2.x and > ;; Icedtea 3.x. > > +(define-public libantlr3c > + (package > + (name "libantlr3c") > + (version "3.4") > + (source > + (origin > + (method url-fetch) > + (uri > + (string-append "https://www.antlr3.org/download/C/" > + name "-" version ".tar.gz")) > + (sha256 > + (base32 "0lpbnb4dq4azmsvlhp6khq1gy42kyqyjv8gww74g5lm2y6blm4fa")))) > + (build-system gnu-build-system) > + (arguments > + `(#:configure-flags > + (list > + "--enable-debuginfo" > + "--enable-64bit" Is this really required? The default is "no". If enabled, it probably needs to be made conditional so that it is only enabled for 64 bits architectures. > + "--enable-abiflags" > + "--enable-antlrdebug" > + "--enable-shared" > + "--enable-static" If enabled, the static library should go to its own "static" output. > + "--enable-fast-install"))) > + (synopsis "ANTLR C Library") > + (description "LIBANTLR3C provides run-time C libraries for ANTLR3 > +(ANother Tool for Language Recognition v3).") > + (home-page "https://www.antlr3.org/") > + (license license:bsd-3))) > + The indentation is off. If you don't use Emacs for editing, you can run the Emacs script provided by Guix like this: ./etc/indent-code.el gnu/packages/java.scm libantlr3c Thanks! Maxim