From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:40924) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPWZs-0005XG-Vv for guix-patches@gnu.org; Fri, 17 Apr 2020 15:23:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPWZs-0006la-0z for guix-patches@gnu.org; Fri, 17 Apr 2020 15:23:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58381) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPWZr-0006lE-Ss for guix-patches@gnu.org; Fri, 17 Apr 2020 15:23:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jPWZq-0002Ce-ML for guix-patches@gnu.org; Fri, 17 Apr 2020 15:23:03 -0400 Subject: [bug#38596] [PATCH] gnu: Add PureScript. Resent-Message-ID: References: <87k12lrdd3.fsf@asu.edu> From: Christopher Baines In-reply-to: <87k12lrdd3.fsf@asu.edu> Date: Fri, 17 Apr 2020 20:21:58 +0100 Message-ID: <87imhx6hpl.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: John Soo Cc: 38596@debbugs.gnu.org --=-=-= Content-Type: text/plain John Soo writes: > Hi Guix, > > I rebased these patches on master. Hi John, I've had an initial look through these now, sorry it's taken so long! I think the patches are pretty much good to merge, but I do have a few comments. ghc-utf8-light could do with a better description, something a little more informative. The ghc-sourcemap and ghc-mtl-compat tests are disabled, it would be good to at least add a comments as to why. The ghc-protolude synopsis could potentially be more informative. I think adding specific versions of dependencies for purescript is OK, but only if they're justified, like if the package only builds with that version. The justification should also be noted in the purescript package description. I don't think it's necessary to go through all the custom versions of packages you've added, but it would be good to at least see if there's one case where the upstream specification is overly strict, and the slightly different version from Guix would work. That at least would provide an example of how to override versions going forward. Let me know what you think, thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl6aAdZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfdEQ/7Bh4I9NfJm4fSTLa9ljAvnpuPKL7gcqhdr92oPCHelfYLebPCvUzjE2Fw 6cMRu1wFXU46Y4PP2em/70vJjvMnQ4XmtLkGYM3ROGa6sedovpBv/NPBGFjrjRuV hIyFonxbSlRFhLK5QQTcoMw7/Ng5SyqH+c7dzjG0X2Gwf7U0IQckeVHU6os/apz4 eFBTk3m2BuVLXfwB48xA8V/ZMnotz3oe0HceCiz47npP4ngd14imc3LNpozhc1ai dzzSHQduDL5TxEfKKwvlsh+Z2ifXf3xR79Pd4E1KMTQmUnV88cCKqXP2no7fuojp qNTC1re4QxoJUyfp6L4kay0nowf9/fGR5m+ipGYtTXjn3ZnGjXBSN/YFYGnbCJbT iLGnUAKDtUkSe7YrXr0arGRDZALFhxzWvxVJgDP9Ki3BEtMjdxIGsoHA0/84BfVL m/mH0Be1nBfF0Q6UaKJc9/0mS4BBwVi7YNcHHFaBi0K0CKMYIUWf03Gxilv53J8V 12UbF9iC7Uh6PAymfpMpfFkMEiavHcFsZ+0i98yBgf7/8RsBzkVeShhuGB6gqAzM Vty8dolv1qVD/2n7TZGBTptVeDBb/W/hzpaCdGknfItszk1n8dqqs2sZERaMnMHB IYnLaCJclFAkuGa11zAqw8J6HcwyKI3+Gen1cNNhoqRwAXOTI7E= =ErSf -----END PGP SIGNATURE----- --=-=-=--