bug#41457: guix pull: channel d8feee9 - extraneous field initializers (sha256)

bug#41457: guix pull: channel d8feee9 - extraneous field initializers (sha256)

[Matias Jose Seco Baccanelli]

Hello! 

I've encountered the following exception, during regular 'guix pull'
command:

Updating channel 'guix' from Git repository at
'https://git.savannah.gnu.org/git/guix.git'... Building from this
channel: guix      https://git.savannah.gnu.org/git/guix.git
d8feee9 Computing Guix derivation for 'x86_64-linux'...
ice-9/psyntax.scm:1585:32: In procedure expand-macro: Syntax error:
unknown location: %origin: extraneous field initializers (sha256) in
form (%origin (method url-fetch) (uri (string-append
"mirror://gnu/bash/bash-" version ".tar.gz")) (sha256 (base32
"0kgvfwqdcd90waczf4gx39xnrxzijhjrzyzv7s8v4w31qqm0za5l")) (patch-flags
(quote ("-p0"))) (patches (cons (search-patch
"bash-linux-pgrp-pipe.patch") %patch-series-5.0))) guix pull: error:
You found a bug: the program
'/gnu/store/fsch1y8hilmkg21rmgk256j3wfi2w7wk-compute-guix-derivation'
failed to compute the derivation for Guix (version:
"d8feee9f18ede0d1ea4d0e4876f09a0dab770295"; system: "x86_64-linux";
host version: "5c10d55206a4f7a9b932ff08512a4f50c1db35be"; pull-version:
1). Please report it by email to <bug-guix@gnu.org>.

Available for further informations,
saluti,
Matias

bug#41457: guix pull: channel d8feee9 - extraneous field initializers (sha256)

[Ricardo Wurmus]

Hi,

I can reproduce this:

--8<---------------cut here---------------start------------->8---
[rwurmus@bimsb-sys02.mdc-berlin.net:~/code/guix] (1005) $ ~/.config/guix/current/bin/guix pull
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
Building from this channel:
  guix      https://git.savannah.gnu.org/git/guix.git	cd5d5f5
Computing Guix derivation for 'x86_64-linux'...  ice-9/psyntax.scm:1585:32: In procedure expand-macro:
Syntax error:
unknown location: %origin: extraneous field initializers (sha256) in form (%origin (method url-fetch) (uri (string-append "mirror://gnu/bash/bash-" version ".tar.gz")) (sha256 (base32 "0kgvfwqdcd90waczf4gx39xnrxzijhjrzyzv7s8v4w31qqm0za5l")) (patch-flags (quote ("-p0"))) (patches (cons (search-patch "bash-linux-pgrp-pipe.patch") %patch-series-5.0)))
-guix pull: error: You found a bug: the program '/gnu/store/fsch1y8hilmkg21rmgk256j3wfi2w7wk-compute-guix-derivation'
failed to compute the derivation for Guix (version: "cd5d5f53228fd5bf96d9f790aa2606ae71fa68d7"; system: "x86_64-linux";
host version: "be0ecfb1787b9e6954bf745bceeb1b9d2669d51a"; pull-version: 1).
Please report it by email to <bug-guix@gnu.org>.

[rwurmus@bimsb-sys02.mdc-berlin.net:~/code/guix] (1006) $ ~/.config/guix/current/bin/guix describe
Generation 8	Apr 15 2020 10:05:07	(current)
  guix-bimsb 78833aa
    repository URL: https://github.com/BIMSBbioinfo/guix-bimsb
    branch: master
    commit: 78833aa4c89fb317cdd67f17ff27111228d870a9
  …
  guix be0ecfb
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: be0ecfb1787b9e6954bf745bceeb1b9d2669d51a
--8<---------------cut here---------------end--------------->8---

It seems to be related to the commits between
c7d2dd69004b020de5d86898d2497ab3c8435c37 and
1ad5209d904d471ded6cf53b4e29b64e963dea3f.

I’m trying this now as a work-around:

    ~/.config/guix/current/bin/guix pull --commit=1ad5209d904d471ded6cf53b4e29b64e963dea3f

-- 
Ricardo

bug#41457: guix pull: channel d8feee9 - extraneous field initializers (sha256)

[Ludovic Courtès]

Hi,

Here’s a reproducer that works well for me:

  guix time-machine --commit=be0ecfb1787b9e6954bf745bceeb1b9d2669d51a -- \
    pull --commit=d8feee9f18ede0d1ea4d0e4876f09a0dab770295 -p /tmp/test

Before that I was able to pull from
df05842332be80ed7f53022402b95cf711163b41 to
d8feee9f18ede0d1ea4d0e4876f09a0dab770295 just fine.

Ludo’.

bug#41457: guix pull: channel d8feee9 - extraneous field initializers (sha256)

[Ludovic Courtès]

Hi,

Ricardo Wurmus <rekado@elephly.net> skribis:

> [rwurmus@bimsb-sys02.mdc-berlin.net:~/code/guix] (1005) $ ~/.config/guix/current/bin/guix pull
> Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
> Building from this channel:
>   guix      https://git.savannah.gnu.org/git/guix.git	cd5d5f5
> Computing Guix derivation for 'x86_64-linux'...  ice-9/psyntax.scm:1585:32: In procedure expand-macro:
> Syntax error:
> unknown location: %origin: extraneous field initializers (sha256) in form (%origin (method url-fetch) (uri (string-append "mirror://gnu/bash/bash-" version ".tar.gz")) (sha256 (base32 "0kgvfwqdcd90waczf4gx39xnrxzijhjrzyzv7s8v4w31qqm0za5l")) (patch-flags (quote ("-p0"))) (patches (cons (search-patch "bash-linux-pgrp-pipe.patch") %patch-series-5.0)))
> -guix pull: error: You found a bug: the program '/gnu/store/fsch1y8hilmkg21rmgk256j3wfi2w7wk-compute-guix-derivation'
> failed to compute the derivation for Guix (version: "cd5d5f53228fd5bf96d9f790aa2606ae71fa68d7"; system: "x86_64-linux";
> host version: "be0ecfb1787b9e6954bf745bceeb1b9d2669d51a"; pull-version: 1).
> Please report it by email to <bug-guix@gnu.org>.

Good news, this is fixed by 50ea3135e0948a042cd3b899e970f6ade291a0c2!

As noted in the commit log, this issue stemmed from a change in
#:autoload semantics in Guile 3.0.  In 3.0, the line:

  #:autoload (gcrypt hash) (port-sha256)

means that only ‘port-sha256’ is imported.  Conversely, in 2.2 (which is
the Guile version used by the ‘compute-guix-derivation’ program above),
that #:autoload line means that all the (gcrypt hash) bindings are
imported.  That includes the ‘sha256’ bindings, which would thus prevent
matching the ‘sha256’ literal in the ‘origin-compatibility-helper’
macro.  Terrible!

Ludo’.

bug#41457: guix pull: channel d8feee9 - extraneous field initializers (sha256)

[Jan Nieuwenhuizen]

Ludovic Courtès writes:

Hello,

> Good news, this is fixed by 50ea3135e0948a042cd3b899e970f6ade291a0c2!
>
> As noted in the commit log, this issue stemmed from a change in
> #:autoload semantics in Guile 3.0.  In 3.0, the line:
>
>   #:autoload (gcrypt hash) (port-sha256)
>
> means that only ‘port-sha256’ is imported.  Conversely, in 2.2 (which is
> the Guile version used by the ‘compute-guix-derivation’ program above),
> that #:autoload line means that all the (gcrypt hash) bindings are
> imported.  That includes the ‘sha256’ bindings, which would thus prevent
> matching the ‘sha256’ literal in the ‘origin-compatibility-helper’
> macro.  Terrible!

Huh?  I just used #:autoload for the first time (in the native
qemu-image patch thaw way may not be using after all ...) and so I just
read the documentation.

]I am pretty sure that t]The 3.0 documentation says that "when a module
is autoloaded, all symbols become available"?

    http://git.savannah.gnu.org/cgit/guile.git/tree/doc/ref/api-modules.texi#n298

So...what's going on here?

janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

bug#41457: guix pull: channel d8feee9 - extraneous field initializers (sha256)

[Ludovic Courtès]

Hi,

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

> ]I am pretty sure that t]The 3.0 documentation says that "when a module
> is autoloaded, all symbols become available"?
>
>     http://git.savannah.gnu.org/cgit/guile.git/tree/doc/ref/api-modules.texi#n298
>
> So...what's going on here?

Ah!  It’s an omission, fixed in Guile commit
723e483e7d88897f1ad654028e86a87dd040b886.

The changed was made late in the 2.9.x series, in commit
cb14fd214365e50b6b1655616ae74d0228933bbd, and later documented in
‘NEWS’.

Thanks for the heads-up!

Ludo’.