From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SLapFoltTV8cNwAA0tVLHw (envelope-from ) for ; Mon, 31 Aug 2020 21:37:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MMRsEoltTV+DYwAA1q6Kng (envelope-from ) for ; Mon, 31 Aug 2020 21:37:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A69419403EC for ; Mon, 31 Aug 2020 21:37:12 +0000 (UTC) Received: from localhost ([::1]:48404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCrUE-0004I3-1S for larch@yhetil.org; Mon, 31 Aug 2020 17:37:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCrEl-0005Vy-2E for bug-guix@gnu.org; Mon, 31 Aug 2020 17:21:11 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCrEc-0001oq-Lt for bug-guix@gnu.org; Mon, 31 Aug 2020 17:21:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCrEc-00069d-GB for bug-guix@gnu.org; Mon, 31 Aug 2020 17:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43138: Stack overflow in emacs 27 because of preloading emacs-seq Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 31 Aug 2020 21:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43138 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Received: via spool by 43138-submit@debbugs.gnu.org id=B43138.159890882523591 (code B ref 43138); Mon, 31 Aug 2020 21:21:02 +0000 Received: (at 43138) by debbugs.gnu.org; 31 Aug 2020 21:20:25 +0000 Received: from localhost ([127.0.0.1]:53950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCrE1-00068Q-6n for submit@debbugs.gnu.org; Mon, 31 Aug 2020 17:20:25 -0400 Received: from mout.gmx.net ([212.227.15.19]:57621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCrDx-000688-4F for 43138@debbugs.gnu.org; Mon, 31 Aug 2020 17:20:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598908814; bh=FhT5pEQErnD88gldemQqfewz5dzY7IOo+MJLtd6HFi4=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=e0yDkAnDRKyJ1jG97LCwKbj1SOARAmjnRo1MGkRLS2YvxV52Dd9pC6/OuJmEANTdv qsFQBbR1q5EO8eMrcHpwkLfQHfAqFbsFqw1jnO0A72dChC1NhbdVoGKgLxEBCTF8RK DUxAfPXrExzejn8dK0kgXrnD1e6Cpgf5jpYjYCcw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MUowV-1k3gAp2CgL-00QlPC; Mon, 31 Aug 2020 23:20:14 +0200 References: <87ft82lsul.fsf@gmx.com> <87imcyv9iq.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois In-reply-to: <87imcyv9iq.fsf@netris.org> Date: Mon, 31 Aug 2020 22:20:17 +0100 Message-ID: <87imcy5x7y.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:d1yk2KJ3kagfs4L/CWoIBdIIGOf9byst/LZSEd0/UCu9D6vIY5S N/oCIJ3JCR/aHMkQI2DlkdlYQ8c0xQObIOZGfSlGqD+tqTv0cjW9HL2zhOh47N8uGzmETru /RA1Si2/FGkRfVEKhaPNXE3G32u66qu0PGgGETBszmZgsEOiJGGGhG/m4iWG901iOKf/tNp HqcVFYHg742/ly3Pgx9kA== X-UI-Out-Filterresults: notjunk:1;V03:K0:uAo2X+JmUWg=:a8l0cgpdjSWkJ6lxmm87DE YFjm6jjIfdvMbY1RA/XqmwRP32Lrxp/N7B51MnYc5MN0qrDPPJnULUNah8kHmVSNcA0R3y00T TH1UsQk/8HASiGpAGakSUWykm3bj2VjoVE4JZ3m5Kdf16FN8IZHL+FqwvDikM4j7+wgZiHnfj qbUCap/PD3dT/YgS8B3IpZ5qlXyOBPUQjB7CrGQj3fXt0wYIXZ62kHzYE4CppF387cb3GRk69 AGbrOJ/EVT0zc1JhKgme6r5WN9HpKXXjcY0PrIId9SexXoUjVT7ixRXq9dEzucv0ddtvtKtz1 kXPBMh9QAmgnHIYN6gr/9seFHQmBGPLOrPmteqBdc00FcuaXWZL8KP5Go5XlkRJZn+46pDInU n/FxsBMzuBflUGIsEvgbT8FwSSTyTinym1/DtBmQXELh5ny9otIyobfr5XTOFslWhdeyjzlEB 4MBGzUmBOPmWb6mYgwN0aOXIJJ8XMlDpKOEpLXlvDMOzVj6rlHz1+4XtjaGyujieoTSzjSRa9 PuJXf5U0884F/ZcYoHV6Wv50ZzL7P2KqJkKx68iHCyUU3zmMxnWUKwtikXfo029xkJHD9jfrD MR5iaPskOTNbKokczwe6Vk2twcLhBnWaxSlJC+ZTXZ8NwouXKSOGZvf2QwtefYVsA9Dq4RWAa TzcGZBWr7+tgn53IrvVTXSNlwGd2PcdxF2qLzWHU0temI7jmmpig0cLF43rJHMeTinpYH4qbU yTY5dmBu+Xa/KPvSqfqHGMZ0UPX506CmkfcJOwzgTmE2aRToxcvE23POZXoleDoOF7yrW5LVx ahAi4G3k94rRqjGB9T78ks8+Jnf7QWGerUPxcPB502fJS3iWINs+K+FdSRgqyqqFYUhcjf2N8 d4XI4Lj+93XVhpGdSCEzmhZRL4ZIjsz2q7bQMXeymdZW4HYA3nKXFkweBnqBdgMyAG7LRTD2u zYHSQouyFED9wHz0K4kzBYosA3xWDlaL3br0PRone0uy0HIiICRljcF+3izo2//wiIq56mTcT Y8bhs3D2OpInG+gPH8LDmpQ+W8D/BD0if1+KNQ9pDwvGaglorXQk+FWkcrEHgAjQyjnldRMXi e3zz0/Swr2zhAvklQb/DOyWgwyAQj1+yaxewC0gt4j3J48189xheJR06ooK88zLRtmCy21NWN AGYpX0jC+MA0sL1nfYRduWZmfdijNZJ/guLUKbDgLyh+GMVhtQz5RjyTAt1dypAkpEoTnM4tT 5wTTOQfCuUUib0iUEed5DVBitDedv2ywzPB9rWQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43138@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmx.net header.s=badeba3b8450 header.b=e0yDkAnD; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 3.99 X-TUID: jhjNJArYbcm4 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Mark, Mark H Weaver writes: > Hi Pierre, > > Pierre Langlois writes: > >> [...] However, it mentions that `emacs-seq` has been >> included in emacs proper for a while. >> >> So, what would be the best fix for this? Should we remove `emacs-seq` >> entirely or try and patch it? Since we don't support previous versions >> of emacs I don't know if we need it. > > If 'emacs-seq' is included in Emacs 27, it seems to me that we should > just delete it, unless there's something I'm missing. Agreed, I was curious if there was another reason for needing it, since I /believe/ it's been in emacs proper since 25, but emacs-seq was added in to guix after that. I suspect it it's still listed as a dependency for packages, even though it's not actually needed. Anyways, I've reconfigured my system with the following patch to fix the issue, let me know if that looks OK! The packages that depended on it build just fine, although I don't use them directly -- I was pulling emacs-seq from emacs-org-roam which depends on emacs-biblio, but I'm not using this feature. Oh, another thing, I wanted to warn potential users of emacs-seq with a deprecation warning using (guix deprecation), like: ;; seq.el is included into emacs. (define-deprecated emacs-seq emacs) It would be good to do that so somebody isn't tempted to re-add it when it's listed a dependency. But that triggers errors: error: emacs: unbound variable hint: Did you forget a `use-modules' form? Am I using it wrong? The (gnu packages emacs) module is included of course. Thanks, Pierre --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Remove-emacs-seq-package.patch Content-Transfer-Encoding: quoted-printable =46rom 1d4fc30d13df916a0800dfcf2f993a1c2a95add8 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Mon, 31 Aug 2020 17:05:58 +0100 Subject: [PATCH] gnu: Remove emacs-seq package. It is included with emacs and installing it alongisde emacs 27 causes issu= es. Fixes . * gnu/packages/emacs-xyz.scm (emacs-bugs-hunter)[propagated-inputs]: Remov= e. (emacs-erc-status-sidebar)[propagated-inputs]: Remove. (emacs-psc-ide)[propagated-inputs]: Remove emacs-seq. (emacs-biblio)[propagated-inputs]: Remove emacs-seq. (emacs-seq): Delete variable. (emacs-flycheck-haskell)[propagated-inputs]: Remove emacs-seq. =2D-- gnu/packages/emacs-xyz.scm | 28 ++-------------------------- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 3036004cee..151718dd6e 100644 =2D-- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1312,8 +1312,6 @@ regexp-like arguments to @code{skip-chars-forward} a= nd (base32 "134fj493sdn93pyyac8rpz1fzahzmayvphsrmqp3wvgysmfqm38l")))) (build-system emacs-build-system) - (propagated-inputs - `(("emacs-seq" ,emacs-seq))) (home-page "https://github.com/Malabarba/elisp-bug-hunter") (synopsis "Hunt down errors by bisecting elisp files") (description @@ -3506,7 +3504,6 @@ IRC bouncer with ERC.") (sha256 (base32 "1hwlhzgx03z8891sblz56zdp8zj0izh72kxykgcnz5rrkyc3vfi3")= ))) (build-system emacs-build-system) - (propagated-inputs `(("emacs-seq" ,emacs-seq))) (home-page "https://github.com/drewbarbs/erc-status-sidebar") (synopsis "Hexchat-like activity overview for ERC channels") (description @@ -13560,8 +13557,7 @@ and can be consulted and modified.") ("emacs-dash" ,emacs-dash) ("emacs-flycheck" ,emacs-flycheck) ("emacs-let-alist" ,emacs-let-alist) - ("emacs-s" ,emacs-s) - ("emacs-seq" ,emacs-seq))) + ("emacs-s" ,emacs-s))) (home-page "https://github.com/purescript-emacs/psc-ide-emacs") (synopsis "Emacs integration for PureScript's psc-ide tool") (description @@ -14321,8 +14317,7 @@ with (La)TeX mode, Org mode and other Emacs editin= g modes.") (base32 "1gxjind6r235az59dr8liv03d8994mqb8a7m28j3c12q7p70aziz")))= ) (build-system emacs-build-system) (propagated-inputs - `(("emacs-seq" ,emacs-seq) - ("emacs-dash" ,emacs-dash) + `(("emacs-dash" ,emacs-dash) ("emacs-let-alist" ,emacs-let-alist))) (home-page "https://github.com/cpitclaudel/biblio.el") (synopsis "Browse and import bibliographic references") @@ -14730,24 +14725,6 @@ timestamps and date-time format strings library f= or Emacs.") "@code{npm-mode} provides a minor mode to work with @code{npm} proje= cts.") (license license:gpl3+))) -(define-public emacs-seq - (package - (name "emacs-seq") - (version "2.20") - (source - (origin - (method url-fetch) - (uri (string-append "https://elpa.gnu.org/packages/seq-" version "= .tar")) - (sha256 - (base32 - "0vrpx6nnyjb0gsypknzagimlhvcvi5y1rcdkpxyqr42415zr8d0n")))) - (build-system emacs-build-system) - (home-page "https://elpa.gnu.org/packages/seq.html") - (synopsis "Sequence manipulation functions") - (description "Sequence-manipulation functions that complement basic -functions provided by @file{subr.el}.") - (license license:gpl3+))) - (define-public emacs-itail (let ((commit "6e43c20da03be3b9c6ece93b7dc3495975ec1888") (revision "1")) @@ -20448,7 +20425,6 @@ unescaping of quotes.") (build-system emacs-build-system) (propagated-inputs `(("emacs-dash" ,emacs-dash) - ("emacs-seq" ,emacs-seq) ("emacs-flycheck" ,emacs-flycheck) ("emacs-haskell-mode" ,emacs-haskell-mode) ("emacs-let-alist" ,emacs-let-alist))) =2D- 2.28.0 --=-=-=--