From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qNPJBY51jF/UHwAA0tVLHw (envelope-from ) for ; Sun, 18 Oct 2020 17:04:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AP6gAY51jF+6aQAA1q6Kng (envelope-from ) for ; Sun, 18 Oct 2020 17:04:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ABA699402DD for ; Sun, 18 Oct 2020 17:04:13 +0000 (UTC) Received: from localhost ([::1]:50860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUC6O-0003c6-Er for larch@yhetil.org; Sun, 18 Oct 2020 13:04:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUC6E-0003ao-Pp for bug-guix@gnu.org; Sun, 18 Oct 2020 13:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUC6E-0003Je-Gl for bug-guix@gnu.org; Sun, 18 Oct 2020 13:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUC6E-0005BZ-Cz for bug-guix@gnu.org; Sun, 18 Oct 2020 13:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 18 Oct 2020 17:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44027 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Received: via spool by 44027-submit@debbugs.gnu.org id=B44027.160304061919894 (code B ref 44027); Sun, 18 Oct 2020 17:04:02 +0000 Received: (at 44027) by debbugs.gnu.org; 18 Oct 2020 17:03:39 +0000 Received: from localhost ([127.0.0.1]:38989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUC5r-0005Ao-3B for submit@debbugs.gnu.org; Sun, 18 Oct 2020 13:03:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUC5p-0005Aa-Ix for 44027@debbugs.gnu.org; Sun, 18 Oct 2020 13:03:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46508) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUC5i-0003HL-E1; Sun, 18 Oct 2020 13:03:30 -0400 Received: from 2a01cb000492e90010138f9af686d929.ipv6.abo.wanadoo.fr ([2a01:cb00:492:e900:1013:8f9a:f686:d929]:56022 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUC5h-0003yt-Uv; Sun, 18 Oct 2020 13:03:30 -0400 From: Mathieu Othacehe References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> <87mu0jpm5b.fsf@gmail.com> Date: Sun, 18 Oct 2020 19:03:27 +0200 In-Reply-To: <87mu0jpm5b.fsf@gmail.com> ("Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Sun, 18 Oct 2020 17:52:00 +0200") Message-ID: <87imb7zctc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brendan Tildesley , 44027@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: dfjxXODI/TYY Hello Miguel & Brendan, > AFAIU from the code, the first partition should not be created by the > installer but it won't be removed if it was found on the disk > beforehand. Tomorrow I'll give a try at the full installation process, > I must have overlooked something if it still being created in that > case... Thanks for your help on this topic! Brendan is probably using a GPT partitionned disk on a non-UEFI compatible machine. Hence, as you noticed, the installer does not create a bios_grub partition. This is a problem as this partition is necessary for GRUB and I think that your patch is fixing the problem. The "auto-partition!" procedure is also leaving a probably pre-existing ESP partition, but I don't really understand how it appeared in the first place. Brendan, did you use "manual partitioning" to create an ESP partition? Thanks, Mathieu