From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ODJ1AsAHkF/ZXgAA0tVLHw (envelope-from ) for ; Wed, 21 Oct 2020 10:04:48 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6EjROb8HkF+VAwAAB5/wlQ (envelope-from ) for ; Wed, 21 Oct 2020 10:04:47 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 58C589402A0 for ; Wed, 21 Oct 2020 10:04:47 +0000 (UTC) Received: from localhost ([::1]:60058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVAz8-0007AO-4h for larch@yhetil.org; Wed, 21 Oct 2020 06:04:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVAyv-0007A7-OJ for guix-devel@gnu.org; Wed, 21 Oct 2020 06:04:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45467) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVAyu-0000ia-DM; Wed, 21 Oct 2020 06:04:32 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43128 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kVAyt-0001g8-9z; Wed, 21 Oct 2020 06:04:31 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ricardo Wurmus Subject: Re: Using #true and #false everywhere? References: <875z7a78ww.fsf@gnu.org> <20201020103244.GB6805@jurong> <871rhtw3tq.fsf@elephly.net> <87a6wg8j47.fsf@netris.org> <87r1psumnx.fsf@elephly.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 =?utf-8?Q?Vend=C3=A9miaire?= an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 21 Oct 2020 12:04:30 +0200 In-Reply-To: <87r1psumnx.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 21 Oct 2020 08:18:42 +0200") Message-ID: <87imb37v4h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: AKQOQSzI+GLN Hi, Ricardo Wurmus skribis: > Mark H Weaver writes: > >> Ricardo Wurmus writes: >> >>> I think it=E2=80=99s very ugly that we still need to end phases with #T= , even >>> though build systems don=E2=80=99t care any more. The only thing that = aborts a >>> build phase now is an exception. >> >> I would be glad if this were the case, but I believe you're mistaken. >> On both master and core-updates, in (guix build gnu-build-system), the >> 'gnu-build' procedure iterates over the phases using 'every', and >> procedure passed to 'every' ends by returning 'result', which is the >> value that the phase returned. Am I missing something? > > No, you are correct. My meaning was more about intent; in the early > days of the change to INVOKE I=E2=80=99ve seen a couple of warnings telli= ng me > that a phase returned # or #F, but that didn=E2=80=99t resul= t in > aborting the build. We have decided a long time ago that the only way > to exit a build should be through an exception, so I think it=E2=80=99s t= ime to > update the last few build system remnants of the Boolean assumption (on > core-updates). I agree. That means replacing =E2=80=98every=E2=80=99 with =E2=80=98for-ea= ch=E2=80=99. Ludo=E2=80=99.