From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oOEeCqjUyF9/PgAA0tVLHw (envelope-from ) for ; Thu, 03 Dec 2020 12:06:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0A3bBajUyF91MwAAbx9fmQ (envelope-from ) for ; Thu, 03 Dec 2020 12:06:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 68AAD94038E for ; Thu, 3 Dec 2020 12:05:59 +0000 (UTC) Received: from localhost ([::1]:42846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kknMz-0005G4-EW for larch@yhetil.org; Thu, 03 Dec 2020 07:05:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kknM6-0004cz-Rm for bug-guix@gnu.org; Thu, 03 Dec 2020 07:05:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kknM6-0000hT-Hk for bug-guix@gnu.org; Thu, 03 Dec 2020 07:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kknM6-0007Hm-Ak for bug-guix@gnu.org; Thu, 03 Dec 2020 07:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45017: asdf-build-system packages have priority over user ones Resent-From: Guillaume Le Vaillant Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 03 Dec 2020 12:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45017 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Pierre Neidhardt X-Debbugs-Original-Cc: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160699709527990 (code B ref -1); Thu, 03 Dec 2020 12:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Dec 2020 12:04:55 +0000 Received: from localhost ([127.0.0.1]:38759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kknLz-0007HO-5R for submit@debbugs.gnu.org; Thu, 03 Dec 2020 07:04:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:34900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kknLx-0007HG-Hi for submit@debbugs.gnu.org; Thu, 03 Dec 2020 07:04:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kknLv-0004NE-R9 for bug-guix@gnu.org; Thu, 03 Dec 2020 07:04:53 -0500 Received: from mout01.posteo.de ([185.67.36.65]:47138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kknLk-0000Zy-PU for bug-guix@gnu.org; Thu, 03 Dec 2020 07:04:51 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id BF8E416005C for ; Thu, 3 Dec 2020 13:04:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1606997076; bh=YUoiLrRYirF544JWmPtahKz5KVXH/i004z6pMFJjOgE=; h=From:To:Cc:Subject:Date:From; b=AyZ1ELJuRit7jBVrr1qGlQTCzep9UThC1GgYbvvevx3rZinMNYwcpqrpcThulyXd0 N/8XWzJbJH1hOjk2kzHf1eZq6E5PUudf1yaHoDmcim4BX5/dqLxid70eTxWbG1fEqR ZNuz3bbPcg7ZKCyuKWmjsUnNYmCEj6nPLyJFp29qk9oBiYGnR4aJSTBpJghSLxE1yH PLT0n2R2Tizc0v1ejWxfEf+9jc+xXaZVZcX3iWDmnpomXH6jkMXkUUNdVo4HwB8/9F 4gif7gYs4geT5HHxluvcoeD6fbLXzW1jr8RWtYzepmd+yaEZPRx9dmqh4g/zVJl1BW /7Yd2R++mJeqQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Cmvdv29Ywz9rxk; Thu, 3 Dec 2020 13:04:35 +0100 (CET) References: <87wnxzmdiy.fsf@ambrevar.xyz> User-agent: mu4e 1.4.13; emacs 27.1 From: Guillaume Le Vaillant In-reply-to: <87wnxzmdiy.fsf@ambrevar.xyz> Date: Thu, 03 Dec 2020 13:04:25 +0100 Message-ID: <87im9j2j06.fsf@yamatai> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=185.67.36.65; envelope-from=glv@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45017@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.78 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=posteo.net header.s=2017 header.b=AyZ1ELJu; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 68AAD94038E X-Spam-Score: -2.78 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: HtuWpLic1F43 --=-=-= Content-Type: text/plain Pierre Neidhardt skribis: > Since staging was merged a few days ago, I've noticed an undesirable > side-effect of our revamped asdf-build-system: the systems packages have > priority over the user-local ones. > > Here is the default list of registries: > > --8<---------------cut here---------------start------------->8--- > (defparameter* *default-source-registries* > '(environment-source-registry > user-source-registry > user-source-registry-directory > default-user-source-registry > system-source-registry > system-source-registry-directory > default-system-source-registry) > "List of default source registries" "3.1.0.102") > --8<---------------cut here---------------end--------------->8--- > > `user-source-registry' points to what is read in > ~/.config/common-lisp/source-registry.conf(.d/)?, so nothing by default. > > user-source-registry-directory reads what's in XDG_CONFIG_DIRS, and it > finds the Guix packages there. > > The default-user-source-registry expands to > > --8<---------------cut here---------------start------------->8--- > (:SOURCE-REGISTRY (:TREE (:HOME "common-lisp/")) > (:DIRECTORY (:HOME ".sbcl/systems/")) > (:DIRECTORY > #P"/home/ambrevar/.local/share/common-lisp/systems/") > (:TREE #P"/home/ambrevar/.local/share/common-lisp/source/") > :INHERIT-CONFIGURATION) > --8<---------------cut here---------------end--------------->8--- > > which is where I would drop my user-local packages. > > Finally, default-system-source-registry reads what's in XDG_DATA_DIRS, > and it finds the packages there again, but it does not read the > Guix-generated conf which collects the dependencies of each package. > > > > I believe the issue is that `user-source-registry-directory' should read > from XDG_CONFIG_HOME, and not XDG_CONFIG_DIRS (which would make it > redundant with `user-source-registry'). This would make it an upstream > issue, but I wanted to double-check I properly understood the problem > with the Guix community first. > > Guillaume, thoughts on this? Our cl-asdf package definition has little patches for 'user-source-registry-directory' and 'user-output-translations-directory-pathname' to make ASDF read configuration files in all the directories listed in 'XDG_CONFIG_DIRS' (IIRC regular ASDF was only reading from the first valid one in 'XDG_CONFIG_HOME' or 'XDG_CONFIG_DIRS'): --8<---------------cut here---------------start------------->8--- (substitute* dst-asdf (("\\(xdg-config-pathname \\*source-registry-directory\\* direction\\)") "`(:source-registry ,@(loop for dir in (xdg-config-dirs \"common-lisp/source-registry.conf.d/\") collect `(:include ,dir)) :inherit-configuration)") (("\\(xdg-config-pathname \\*output-translations-directory\\* direction\\)") "`(:output-translations ,@(loop for dir in (xdg-config-dirs \"common-lisp/asdf-output-translations.conf.d/\") collect `(:include ,dir)) :inherit-configuration)"))) --8<---------------cut here---------------end--------------->8--- I guess 'XDG_CONFIG_HOME' is missing here and we could add it in the list before the 'XDG_CONFIG_DIRS' directories. Something like: --8<---------------cut here---------------start------------->8--- (substitute* dst-asdf (("\\(xdg-config-pathname \\*source-registry-directory\\* direction\\)") "`(:source-registry (:include (xdg-config-home \"common-lisp/source-registry.conf.d/\")) ,@(loop for dir in (xdg-config-dirs \"common-lisp/source-registry.conf.d/\") collect `(:include ,dir)) :inherit-configuration)") (("\\(xdg-config-pathname \\*output-translations-directory\\* direction\\)") "`(:output-translations (:include (xdg-config-home \"common-lisp/asdf-output-translations.conf.d/\")) ,@(loop for dir in (xdg-config-dirs \"common-lisp/asdf-output-translations.conf.d/\") collect `(:include ,dir)) :inherit-configuration)"))) --8<---------------cut here---------------end--------------->8--- Or maybe we could make a better patch not changing 'user-source-registry-directory', but adding a new 'guix-source-registry' between 'default-user-source-registry' and 'system-source-registry' in the list of registries (and likewise for output-translations). I think this way the systems in '$HOME/.config/...', '$HOME/.local/...' or '$HOME/common-lisp/...' will have priority on the ones in Guix profiles. What do you think? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCX8jUSQ8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j80MwD+IUbf1WqpRRobAUhPWcFZM2FolI7tBPEztCd6 b/ac7twA/R9l9WVYDHkaS+nb28pPTo5Gr1v7K2eKjT/p9nE7Qd/T =iXrd -----END PGP SIGNATURE----- --=-=-=--