From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8IgKMVbP11+VWgAA0tVLHw (envelope-from ) for ; Mon, 14 Dec 2020 20:47:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wFwBLVbP119BHgAA1q6Kng (envelope-from ) for ; Mon, 14 Dec 2020 20:47:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 431719402D4 for ; Mon, 14 Dec 2020 20:47:18 +0000 (UTC) Received: from localhost ([::1]:34500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koukW-00020L-C2 for larch@yhetil.org; Mon, 14 Dec 2020 15:47:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koukJ-0001y4-3l for bug-guix@gnu.org; Mon, 14 Dec 2020 15:47:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43143) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koukI-0001BC-Rx for bug-guix@gnu.org; Mon, 14 Dec 2020 15:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koukI-0004oO-Q6 for bug-guix@gnu.org; Mon, 14 Dec 2020 15:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#45193: Wrapper of Qt programs doesn't extend existing environment variable Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 14 Dec 2020 20:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45193 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Zhu Zihao , 45193@debbugs.gnu.org Received: via spool by 45193-submit@debbugs.gnu.org id=B45193.160797878316565 (code B ref 45193); Mon, 14 Dec 2020 20:47:02 +0000 Received: (at 45193) by debbugs.gnu.org; 14 Dec 2020 20:46:23 +0000 Received: from localhost ([127.0.0.1]:54685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koujf-0004Is-0h for submit@debbugs.gnu.org; Mon, 14 Dec 2020 15:46:23 -0500 Received: from world.peace.net ([64.112.178.59]:32884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koujd-0004DC-Kg for 45193@debbugs.gnu.org; Mon, 14 Dec 2020 15:46:21 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koujX-0003kQ-RP; Mon, 14 Dec 2020 15:46:15 -0500 From: Mark H Weaver In-Reply-To: <86wnxns81f.fsf@163.com> References: <86wnxns81f.fsf@163.com> Date: Mon, 14 Dec 2020 15:45:23 -0500 Message-ID: <87im94ru9t.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.31 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 431719402D4 X-Spam-Score: -2.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: 9AUjoGNkWW5z Hi, Zhu Zihao writes: > Reproduce steps: > > guix environment --ad-hoc qbittorrent && cat $GUIX_ENVIRONMENT/bin/qbittorrent > > > We can see the wrapper generated in qt-build-system doesn't extend > existing environment variable. Instead, it overrides them. > > It was discussed in > https://lists.gnu.org/archive/html/guix-devel/2019-12/msg00117.html one > year ago. This's not a trivial issue because using input method in Qt > program requires an qt plugin(XIM doesn't work here) which is managed by > QT_PLUGIN_PATH. > > We should change following functions: > > 1. guix/build/qt-build-system.scm(wrap-all-programs) > 2. guix/build/qt-utils.scm(wrap-qt-program) > > It's ideal to make wrap-all-programs use wrap-qt-program internally and > we don't need to maintain two copy of wrap code. I agree with your analysis. Would you like to propose a patch and test it as thoroughly as you can? Regards, Mark