From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0KAeFtYc/l/+cQAA0tVLHw (envelope-from ) for ; Tue, 12 Jan 2021 22:04:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gNr3EdYc/l8ULQAAbx9fmQ (envelope-from ) for ; Tue, 12 Jan 2021 22:04:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E27829404FF for ; Tue, 12 Jan 2021 22:04:05 +0000 (UTC) Received: from localhost ([::1]:37874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzRlk-0001Sn-RZ for larch@yhetil.org; Tue, 12 Jan 2021 17:04:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzRkm-0000lo-Ex for guix-patches@gnu.org; Tue, 12 Jan 2021 17:03:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzRkl-0003zR-1P for guix-patches@gnu.org; Tue, 12 Jan 2021 17:03:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzRkk-0004sJ-Tp for guix-patches@gnu.org; Tue, 12 Jan 2021 17:03:02 -0500 Subject: bug#45825: [PATCH] gnu: Add efi_analyzer. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 12 Jan 2021 22:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 45825 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vincent Legoll Mail-Followup-To: 45825@debbugs.gnu.org, me@tobias.gr, vincent.legoll@gmail.com Received: via spool by 45825-done@debbugs.gnu.org id=D45825.161048895218661 (code D ref 45825); Tue, 12 Jan 2021 22:03:02 +0000 Received: (at 45825-done) by debbugs.gnu.org; 12 Jan 2021 22:02:32 +0000 Received: from localhost ([127.0.0.1]:33514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzRkF-0004qu-Qa for submit@debbugs.gnu.org; Tue, 12 Jan 2021 17:02:32 -0500 Received: from tobias.gr ([80.241.217.52]:43422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzRkC-0004qj-Oz for 45825-done@debbugs.gnu.org; Tue, 12 Jan 2021 17:02:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=+ICNYHOPcy3bWmQ5S1d+AlotDILRPBDOw87QuX1vZBo=; h=date:in-reply-to: references:subject:cc:to:from; b=UwQnvQKySAn/XtcY+1k/9+Xm77H9Mq0FDQHvJ kXS+/7sLDeepAOtly24Nuw8XOGAK9nz+cM2M9jRWhVPhE04g+sXmaftuxHlby3BF1W+KnV KKAFM8uU87uK05f4MdoJk4ksjFXQM+3W5s1OF20lnnoOmT1PkAE/1718JpVXbGDrJ6uH3p GcL+UlDy05nd5yRPFz+Uel4Zq/UKwbBrM8cVyvOUSOYvKQ7/k5iyNcPXxZfQXMcmavkZk9 AmoELh/ATUhnBHGpnMNAm+3e8kZVuDi+wGXB151T1SOVTtSEhTTm2KjRMUOcDOlFglTRNx QxxvcOwLHtKhttPAAHBdDUx7Q== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 23544d08 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 12 Jan 2021 22:02:59 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; References: <20210112193747.19460-1-vincent.legoll@gmail.com> In-reply-to: <20210112193747.19460-1-vincent.legoll@gmail.com> Date: Tue, 12 Jan 2021 23:02:24 +0100 Message-ID: <87im81olu7.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45825-done@debbugs.gnu.org, guix-patches@gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.46 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tobias.gr header.s=2018 header.b=UwQnvQKy; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E27829404FF X-Spam-Score: -4.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: +o/ra2uEhGxw --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Vincent, Vincent Legoll =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/engineering.scm (efi_analyzer): New variable. Neat! > gnu/packages/engineering.scm | 27 +++++++++++++++++++++++++++ I failed to see any connection to engineering and moved this to=20 efi.scm. Don't forget to add or update your copyright line. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url=20 > "https://github.com/xypron/efi_analyzer") > + (commit commit))) > + (sha256 > + (base32=20 > "1izdkzybqyvzpzqz6kx4j7y47j6aa2dsdrychzgs65466x1a4br1")) I added a newline after =E2=80=98source=E2=80=99 to give this 81-character = line=20 some breathing room. URLs, snippets, ... can grow wide and a few columns can save a=20 pointless string-append or newlines. > + (file-name (string-append name "-" version=20 > "-checkout")))) This can be done with the (file-name (git-file-name name version)) helper. > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'configure)) Not a comment on your patch, but I added a=20 =E2=80=98support-cross-compilation=E2=80=99 phase here that replaces the=20 Makefile's hard-coded =E2=80=98gcc=E2=80=99 so you can inspect EFI binaries= on=20 your cross-compiled ARM box. > + #:make-flags (list "prefix=3D" (string-append "DESTDIR=3D"=20 > (assoc-ref %outputs "out"))))) The other way 'round: set $prefix (or the BSD variant $PREFIX) to=20 the destination, and never set DESTDIR unless you're working=20 around a bug in a broken build system. DESTDIR is for distributions/builds using a temporary =E2=80=98staging=E2= =80=99=20 destination directory. Guix doesn't. > + (description > + "The EFI Analyzer can be used to check EFI binaries and to=20 > print out header > +and section information.") Slash empty =E2=80=98x can y=E2=80=99 (or =E2=80=98x allows the user to y= =E2=80=99) filler with=20 gleeful prejudice. Pushed with these changes as=20 373f808df229c12101301b766bd1810836b98481. Thanks! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX/4ccA0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15MY8BAIC71P9T/PV5Sh66h+7dJJ3MCMPyRU4JFy8fQt/M ULe4AP4kcAMe13YyRXRpTKXyYgyGJpVH5yQgLOZXMQ9HSRFnDQ== =Qwas -----END PGP SIGNATURE----- --=-=-=--