From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8kzdAN/aSmD/NAAA0tVLHw (envelope-from ) for ; Fri, 12 Mar 2021 03:07:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +CqqN97aSmBFHAAAbx9fmQ (envelope-from ) for ; Fri, 12 Mar 2021 03:07:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7F1AA801E for ; Fri, 12 Mar 2021 04:07:10 +0100 (CET) Received: from localhost ([::1]:51398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKY8r-0007ZE-AJ for larch@yhetil.org; Thu, 11 Mar 2021 22:07:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKY8k-0007Z7-Q8 for guix-patches@gnu.org; Thu, 11 Mar 2021 22:07:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44198) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKY8k-0008I1-F1 for guix-patches@gnu.org; Thu, 11 Mar 2021 22:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lKY8k-0006n3-74 for guix-patches@gnu.org; Thu, 11 Mar 2021 22:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#47027] Disarchive package Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Mar 2021 03:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47027 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Leo Prikler , 47027@debbugs.gnu.org Received: via spool by 47027-submit@debbugs.gnu.org id=B47027.161551840626080 (code B ref 47027); Fri, 12 Mar 2021 03:07:02 +0000 Received: (at 47027) by debbugs.gnu.org; 12 Mar 2021 03:06:46 +0000 Received: from localhost ([127.0.0.1]:55744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKY8U-0006ma-2X for submit@debbugs.gnu.org; Thu, 11 Mar 2021 22:06:46 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lKY8S-0006mN-Oz for 47027@debbugs.gnu.org; Thu, 11 Mar 2021 22:06:45 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B779C5C00AC; Thu, 11 Mar 2021 22:06:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 11 Mar 2021 22:06:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=SW2U7O00PP/qn0YJZODT+0Kfif1KZGePJI5Txy9K3 ec=; b=GDdSsQRfCAxzgvjwHpCyMrvBrShB6POL+ae1k+b5Q/vAk+yoPeIRvlSCe +6nV2o0mIPPLwehz8DlgKxBmYHO5caqC6hsV707ZnQDQIRIicPyzZNL4H7qMCeTi 80Ru3oZt+iQVk1JXj4V5JdvYoUH6x59uzhW3U60l+tC7WSkzjjGZXt2mO8p/HTc3 7hRfIqQUSwuA83AfrEWX7JZk7IcRcKouwajN4ui+Z88jH4wX9SNAWaO+lOxjTWMl uFAMoXgcYmck0zixvI78MWoVciotgIQdPgJ3lDiYESzcCIiystLvRWh1CSBWmdm+ qa5IyexBMiju/gZrg6WPbCFv0xTHg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvuddgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfhimhho thhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrf grthhtvghrnhepieduuefhgeegleelveehgedugfeuhfeikefftdevieelgfelhfdvtdfg ieehtefgnecukfhppeejgedrudduiedrudekiedrgeegnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtgho mh X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id D211224005A; Thu, 11 Mar 2021 22:06:38 -0500 (EST) From: Timothy Sample References: <20210309193925.15447-1-samplet@ngyro.com> <20210309193925.15447-2-samplet@ngyro.com> <6c09a18a2f23bc093eecaae17fc9b007847ef14b.camel@student.tugraz.at> <87eeglwd1n.fsf_-_@gnu.org> Date: Thu, 11 Mar 2021 22:06:37 -0500 In-Reply-To: <87eeglwd1n.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 11 Mar 2021 23:17:24 +0100") Message-ID: <87im5xyssi.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615518430; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SW2U7O00PP/qn0YJZODT+0Kfif1KZGePJI5Txy9K3ec=; b=eoIL7EoBcJaLUJ9M58SzXTEb0/cYmk8lc8LIeEgfyEzc4jCYQx5BrV8CtcTN/KM4BEjobZ P98B4/83NfMNfk8rpZiTc78KTWtH+iDqTnxePVi2yCO3pH/wxSrVu68VKpZmxb0aZLX67N yLg0eTmXg9uF9kM7YresEvzMRVagJFSxOT2/xB3v8dAUP4uQjVeGqUeoPLEyaf7K48y9QQ yyLGbuWDR+5HXBqYI9HidVnfgXD77j03cnI2ngt4N8DQHXc6WniOXc/RpEbs8SNV4xmhkU HE8iPkWl01NRHOSWZNFXHlKMysB7sS+ir+2tGtm/u3JgPnD24sDWRlOGuZxFIA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615518430; a=rsa-sha256; cv=none; b=svkQL/cTU7yRfyTRCQs39y1Sc6GxYE1z2tD6lqdTGdjrYGm+251etLaGTV6U/Z60DR8+yg CMe1f0zJHcDzMvl0/XzuNLV1F2YIyKdOpIu0xm5a4X9zLzGdjvAW2Y7pqf7SScm7hHM9jw klzSMfpaa/jYX/wS1hLk54HlX5mNMGnc+msQSMb/W9vJIPeWzAekbus8V9ZUIXiDTLYsV6 80G1YejqpGuaSQg/3gDDLft+t0qM0P0KvhEC1vOZrDDigVqwXhP0N9aYTb//KFrLR5uGBC 16byN6QAztvGPkqFEzOlrIe2Gl9jFUvoUB6kukUlVWGiqTMYZ2VOpKe/7Sh79g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=GDdSsQRf; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=GDdSsQRf; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7F1AA801E X-Spam-Score: -1.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: kOpyCKFTwmLM Hi, Thanks Leo for the review! (And to Ludo and Tobias for follow ups.) Ludovic Court=C3=A8s writes: > Leo Prikler skribis: > >> I've checked and the package seems to build fine with Guile 3.0.2. I >> think the bytecode mismatch happens, because Guix compiles stuff with >> 3.0.2 by default, but users have 3.0.5 in their system, which is not >> bytecode-compatible. (As an exception, Guix itself seems to be >> compiled with Guile 3.0.5 for performance reasons). >> >> I think it would be fine to add with Guile 3.0.2, perhaps adding a note >> that Guile 3.0.5 will effectively be required to use Guix interop? If >> not, could you provide a script, that breaks in a way other than >> recompiling the mismatching code? > > I tend to agree here: I don=E2=80=99t think =E2=80=98guile-3.0-latest=E2= =80=99 is needed in this > case. The only case where you need it is if it depends on a library, > such as Guix, that is itself built with =E2=80=98guile-3.0-latest=E2=80= =99. Well, now I=E2=80=99m second guessing myself. :) It is just the auto compilation notes and warnings that I=E2=80=99m worried about. The module closure of =E2=80=9Cswh.scm=E2=80=9D works fine on Guile= 3.0.2. Eventually, the daemon will invoke Disarchive via =E2=80=9Cbuiltin:download= =E2=80=9D and =E2=80=9Cperform-download.scm=E2=80=9D. I intend to use the Scheme interfa= ce there, which means Disarchive will be runing on Guile 3.0.5. For that, it would be preferable to have a Guile 3.0.5 version of Disarchive, right? On the other hand, when using Disarchive to extract metadata (e.g., with Cuirass), the SWH code is not needed at all. I will resurrect my patch for calling Disarchive from Guix, and come back to this when I know exactly what kind of package I need for that to work smoothly. >> As far as the location is concerned, I personally do not like adding >> too many single-package files. Would it make sense to add this to >> compression.scm (like gzip) or backup.scm (like libarchive)? > > Maybe there=E2=80=99ll be other packages eventually in archival.scm, like= the > SWH Python code? It=E2=80=99s fine with me, but I don=E2=80=99t have a s= trong opinion. I don=E2=80=99t feel strongly about it either. There=E2=80=99s other softw= are besides Disarchive and SWH that could be called =E2=80=9Carchival=E2=80=9D, and I t= hink it=E2=80=99s more accurate than the other options. -- Tim