From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yMUqKeWQjGCnGgAAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 01:21:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KH/jJOWQjGDBJAAA1q6Kng (envelope-from ) for ; Fri, 30 Apr 2021 23:21:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8875D12165 for ; Sat, 1 May 2021 01:21:08 +0200 (CEST) Received: from localhost ([::1]:39660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lccRX-0004wN-Ao for larch@yhetil.org; Fri, 30 Apr 2021 19:21:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lccRS-0004w8-Lx for guix-patches@gnu.org; Fri, 30 Apr 2021 19:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lccRS-00050g-DU for guix-patches@gnu.org; Fri, 30 Apr 2021 19:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lccRS-0005Wh-89 for guix-patches@gnu.org; Fri, 30 Apr 2021 19:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48126] [PATCH] Add package for vim-solarized Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 30 Apr 2021 23:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48126 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tissevert Cc: 48126@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 48126@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.161982483921188 (code B ref -1); Fri, 30 Apr 2021 23:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Apr 2021 23:20:39 +0000 Received: from localhost ([127.0.0.1]:60007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lccR4-0005Vg-VT for submit@debbugs.gnu.org; Fri, 30 Apr 2021 19:20:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:41252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lccR4-0005VZ-0W for submit@debbugs.gnu.org; Fri, 30 Apr 2021 19:20:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lccR3-0004qW-RA for guix-patches@gnu.org; Fri, 30 Apr 2021 19:20:37 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:47958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lccR0-0004iG-Pd for guix-patches@gnu.org; Fri, 30 Apr 2021 19:20:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=5Zg5IXRNIsZai6QAxKKBJfVPi5hEwreqNef825xvyB0=; h=date:in-reply-to: subject:cc:to:from:references; b=ISanTZEcEP9K2B/i/TE2LIrs2LQhDuBT/uc5Y la0jhIJTQTQnKgAGlwGmcNf3y4bCWqUAsZCzMJ4Ht6MQ1tcrS303MR96R9/XY1tIuJKCB4 QmCtIR7wuxrpArgYAhgNCKMFkhB6XHpAPHoHjxOXmfeLzeiAG4p7UeeAPhTtDDesndIW/G c0MluqMqdCpDDCZ80EpooNYQFWMMk2qbXoDICcBRaujvRtheEV4uEqYRPz3Bv7eHSQs0tc 12qMmtOsJfbF7phVLfD6mib/raGY/NRM7AbCme31pcRzspNmSdUspruYdWms6grMu1SzbO Uvk9lX9NauLAMpBcSTYicTjog== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 47cf0869 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Fri, 30 Apr 2021 23:20:40 +0000 (UTC) References: <20210430194235.1461cada@pine.local> In-reply-to: <20210430194235.1461cada@pine.local> BIMI-Selector: v=BIMI1; s=default; Date: Sat, 01 May 2021 01:20:30 +0200 Message-ID: <87im43qs01.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619824869; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=5Zg5IXRNIsZai6QAxKKBJfVPi5hEwreqNef825xvyB0=; b=dkLN+1IMLIK/och7Rkfd/Khtnzgf9Nn+fA+eUPSHO2HSIxuY5Ayl/1mp2rlvpn11SGJ3O9 a5mwsJTwzzD/kVeSjQTOhztvet50t1QgNLXerElmbBLOSHlIkDffGTHultVrdi51Z4a0im GniL4lPt3DW7N3YoVjf4FeORGc0M6kIimDIbWSt6TcrSGPsbC0h+4hcMY+9RXCql1vFugo uQXFTYEyS9XhsQEn0uh2fqEvTknHReAq+j3V8PiBJZXiwGEDUFifuwsbzOPZHSfP67yUGA O4X7UJdcSH4ZcBqgxImeqMOWbJzQuA2xNFEN3+t8zVB672eJGAgqClskXpmmHw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619824869; a=rsa-sha256; cv=none; b=u0pid327PjsvAqb+JAm4N93tjHlGFIaQQntep/ZxwKyHken1F6fDlPmJRaBGoPwzxxdK7y ieRxaYoH8ocQ1WdSrk8faBVGreT0/yfK9TcUL3V56xRjxdeI9V9LiNyk5dInuvFPI2C0SM mcq4nGIf3gLU1+eWNcna5lp1bftT/G5fi8vEjfFSd/a6pRih6+hy1MQ17cIcbuzTWsDRzK 8ykYAuufKT9yfuC5855YaDICGbgtqvkAQyZS5givvNKTPzkzyc1bLjNOEOBjgqPm1X2xSq /ZFHDAejZmK16JG+3tXmi4N1e/SOSWVKId3v93bJxM12GXtuLRaVePuZ4aDkyw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=ISanTZEc; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -4.56 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=ISanTZEc; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8875D12165 X-Spam-Score: -4.56 X-Migadu-Scanner: scn0.migadu.com X-TUID: foHF9m7OoMi+ --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Tissevert =E5=86=99=E9=81=93=EF=BC=9A > I here's my first attempt at packaging something, I noticed that=20 > vim-solarized > was missing so I tried to write a package for it. Thank you! > > The only warning I got was from the guix lint which told me it=20 > couldn't find > upstream releases. I believe this is due to vim-solarized=20 > particular structure: > it's a light =C2=ABclone=C2=BB of the main repository > https://github.com/altercation/solarized containing only the=20 > vim-files. Hmm. Could we install from this authoritative(?) source instead,=20 even if the download's bigger? > (https://github.com/vim-scripts/Solarized) which has made a tag=20 > (the same > version name that I chose) so we could be using either the full=20 > repository > (more unneeded data retrieved during the build) or this second=20 > copy (they do > provide a tag but isn't it better to remain as close as possible=20 > to the > original source ?). Oh, I think we agree. :-) /tmp =CE=BB git clone --depth=3D1=20 https://github.com/vim-scripts/Solarized Cloning into 'Solarized' [...] /tmp =CE=BB git clone --depth=3D1=20 https://github.com/altercation/solarized Cloning into 'solarized' [...] /tmp =CE=BB du -hs [Ss]olarized 196K Solarized 30M solarized The relative difference is huge but I think 30M is worth it. Could you make this change, test, and send a V2? I'm no adherent=20 of the Vim. > I hope my patch is correct and thank you everyone for being such=20 > a welcoming > community and having made my experience with Guix so far=20 > absolutely great ! Thank you! We try to do our best... Your patch is great. I'd make the following tweaks before=20 committing. You can incorporate them into your V2 if you want. The description should explain what the package is to someone=20 who's never heard of it. We actually recommend ~10 lines (more is=20 fine), although many existing packages don't meet that bar. The=20 synopsis should do the same in one line. Don't be afraid to temper fawning upstream marketing-speak and=20 empty taglines like this one. That doesn't mean it can't be=20 positive (like mine -- I hate Solarized). C-M-q reindented the source field according to the same rules as=20 etc/indent-code.el. Better to do so before committing it, so=20 future committers can just run C-M-q on the entire expression=20 without creating unrelated whitespace noise. diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm index 477c15b9aa..ad95724c41 100644 =2D-- a/gnu/packages/vim.scm +++ b/gnu/packages/vim.scm @@ -585,24 +585,33 @@ are detected, the user is notified.") (name "vim-solarized") (version "v1.0.0beta1") (source =2D (origin =2D (method git-fetch) =2D (uri (git-reference =2D (url=20 "https://github.com/altercation/vim-colors-solarized") =2D (commit=20 "528a59f26d12278698bb946f8fb82a63711eec21"))) =2D (file-name (git-file-name name version)) =2D (sha256 =2D (base32 =2D=20 "05d3lmd1shyagvr3jygqghxd3k8a4vp32723fvxdm57fdrlyzcm1")))) + (origin + (method git-fetch) + (uri (git-reference + (url=20 "https://github.com/altercation/vim-colors-solarized") + (commit=20 "528a59f26d12278698bb946f8fb82a63711eec21"))) + (file-name (git-file-name name version)) + (sha256 + (base32=20 "05d3lmd1shyagvr3jygqghxd3k8a4vp32723fvxdm57fdrlyzcm1")))) (build-system copy-build-system) (arguments '(#:install-plan '(("colors" "share/vim/vimfiles/") ("doc" "share/vim/vimfiles/")))) (home-page=20 "https://github.com/altercation/vim-colors-solarized") =2D (synopsis "Solarized Colorscheme for Vim") =2D (description "Precision colors for machines and people") =2D (license license:bsd-3))) + (synopsis "Solarized color scheme for Vim") + (description + "Solarized is a sixteen-color palette of eight monotones and=20 eight accent +colors. It was designed for use with both terminal and GUI=20 applications. + +Black text on white from a computer display is akin to reading a=20 book in direct +sunlight and can tire the eye. Solarized reduces brightness=20 contrast but, +unlike many low-contrast color schemes, retains contrasting hues=20 based on +color wheel relations for syntax highlighting readability. + +Solarized retains the same selective contrast relationships and=20 overall feel +when switching between the light and dark background modes.") + (license license:expat))) Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYIyQvg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15DiEBAJQKJCd/tCHR9kVNZrCmPqqTXri1MYPyPOJ759Rl +cd+AP4oNsCltm6Xv8/HSFkHpJkT5TlNc9crygpOwX3K8vOOBA== =miOd -----END PGP SIGNATURE----- --=-=-=--