From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QGEGEhOXuGB7dwAAgWs5BA (envelope-from ) for ; Thu, 03 Jun 2021 10:47:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SAgCDROXuGCEXQAAbx9fmQ (envelope-from ) for ; Thu, 03 Jun 2021 08:47:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D08B316074 for ; Thu, 3 Jun 2021 10:47:14 +0200 (CEST) Received: from localhost ([::1]:49528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loj0T-0001Ad-C4 for larch@yhetil.org; Thu, 03 Jun 2021 04:47:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loj08-00015C-HT for guix-devel@gnu.org; Thu, 03 Jun 2021 04:46:52 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:43899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loj06-0006WX-Me for guix-devel@gnu.org; Thu, 03 Jun 2021 04:46:52 -0400 Received: by mail-pf1-x435.google.com with SMTP id t28so4363331pfg.10 for ; Thu, 03 Jun 2021 01:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:user-agent :mime-version; bh=4yJWbpsQ7P7c6nKb9W4H/2PKZwldvqrbmeIKjSgs76I=; b=H3hCMxPea+8iXYFtY/gOTR7b6sDjYMBiyqXVS3y17Ocnmq2fndP+igM/a2thP0/alI JSr2OHww1EvK5dcOyJaap07+G6232QNhz+FcE2a20rQQJYSCbFEmByuvr6Oz4SzST8yq GgQ74HXFzw73WgUWwvXm3451Z7Nt+2I2yVmj6Gk0Ssgp0MrpwVW0TDp4GO/HSkGTa+CM FPMKx/3ZNjKc6FeNjqUFXrvVfbKdcxnuFqzjYWmVvdeBdObXd171ERnP0gJ67Be1Lbti TTjMYfnDZelC1VZliJbMdCBMvcIRDLxcrxNhGYSGLfzG2uyQewjTV096pL7ONTdLxUB2 IliQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :user-agent:mime-version; bh=4yJWbpsQ7P7c6nKb9W4H/2PKZwldvqrbmeIKjSgs76I=; b=QxiKT4wZ8zTpC5ncxC4JdULYT/4FvGkLa0VHTPBcfrBDtvJ/FyXiX5SDGlk8QrLjhD GxO9Sg+FL1LkJEOsPsoiXkps5TAsCTeD3fr7hKTYm2RD+3SwW+YfF0BAb+rEKoNXFHRk AgEyZRAgXq1Fk3jv1NtTWXV2TUl4T4rAGV2oKuP9HJ5M/B3cH1QWjiF5iv64dmf8ZE5s 1Wc2JAN9oXRu+Al56ObLfGXz8ilifCqhGucfnCz9hfXA5ax3mrDadSQWdK3bj8UUD20W 1mu4QfJ+/YcXI6PpKPJy7foyPT7dHpO9ltdU/7aVU08VU/JVx747ysBNGt2knO68TZFp m8wQ== X-Gm-Message-State: AOAM530cDGS+cc/GGQmfhp5VMhaiHDHyeTAv1OxxKQaN7kCYNBMp1FQc Di713A2C30OqaTmdh17piYi9tcatM6w= X-Google-Smtp-Source: ABdhPJwW87nZ2Xfd9Gvtf3tNdKlSRcQN45JGrxqTEVzqTy5MPmHx5Hu7J0JE90/KPCGcCtsOVPZQ/A== X-Received: by 2002:a05:6a00:88a:b029:261:6d37:dac6 with SMTP id q10-20020a056a00088ab02902616d37dac6mr31254763pfj.18.1622710007953; Thu, 03 Jun 2021 01:46:47 -0700 (PDT) Received: from garuda-lan ([2601:601:9d01:3f90::b043]) by smtp.gmail.com with ESMTPSA id y1sm1802115pfn.13.2021.06.03.01.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 01:46:46 -0700 (PDT) From: Chris Marusich To: Maxim Cournoyer Subject: Re: GNU Guix 1.3.0rc2 available for testing! References: <874kfdvuuu.fsf@gmail.com> <87r1ic5i3t.fsf@gmail.com> <87lf8h70zx.fsf@gmail.com> Date: Thu, 03 Jun 2021 01:46:42 -0700 Message-ID: <87im2vs5cd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=cmmarusich@gmail.com; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622710035; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=4yJWbpsQ7P7c6nKb9W4H/2PKZwldvqrbmeIKjSgs76I=; b=K01HYOxb/LL9D5/977LW1RXglFsMRxamxOXyQx/V9SlExvQ8a8KVegCSUwWFn9MUfMBf9o GGWZ79wjXpiyVq/ApmaLJTHT0bsApwswuYZMaVeY2YURSjvbN/hOzjHUNdDZmkkCtAu0Wr PgcDLplBr+DooFH/92BnNLPa3xU+Gdk/S9jeLLaHc+CS5qvvqpArTAJxTk9t9pI1pWn3nz FiHTBryynyPUfFvnzjOijHVVZso7u0jME4iPc29xiNLATSLUY56vYXTgN38EZ4jbkafBqp m6CQHh6EJ5RcOQ/BnSVhLyHGYgWpdkmb4IA+yRn76aeTWp/zyjlQe5IlJ5eAwg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622710035; a=rsa-sha256; cv=none; b=WHsiNUAyVE7iizkmfFcdhuViQZ+W0eEgYLrxRO2EG1VKMf4aa2YsJYiQOSXWnww8DCXTG6 1PGkHOgeu0TVgXYRm6/XzNC0aiAQOyC++s4HQp5fg3Zt6Y3TEDf3s4k0UW/1VQOVguyuPf Km1spUHfn8/YmPPfZt6RpyowuD4ouhgypcXc+2oCwWDtxBmgUt+k37tHgmkdtEVEpSgBsH DCNSKQNsOYy+f/TFM4IobHtrS8elT+O8T63jqgtAA7VnYnVO7tJ1I7E5AHcJBsnPyiNWVt m3kYZIp4ulNha5PbxLxHRtqA1OMqg7qGrESFxZCneDlW7zHxM0v6xulPaQ/jtw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=H3hCMxPe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.73 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=H3hCMxPe; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: D08B316074 X-Spam-Score: -2.73 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3I/zLCW/RSkL --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Maxim, Maxim Cournoyer writes: > Sorry for the delayed answer. No worries! I've waited even longer in replying to you now, so we're even. :-) > The go importer depends on a recent version of guile-lib (0.2.7), which > added a new #:strict argument to the HTML parser. We should probably > skip the test depending on the already available HAVE_GUILE_LIB Automake > conditional, like so: > > modified Makefile.am > @@ -457,7 +457,6 @@ SCM_TESTS =3D \ > tests/git-authenticate.scm \ > tests/glob.scm \ > tests/gnu-maintenance.scm \ > - tests/go.scm \ > tests/grafts.scm \ > tests/graph.scm \ > tests/gremlin.scm \ > @@ -505,6 +504,10 @@ SCM_TESTS =3D \ > tests/uuid.scm \ > tests/workers.scm >=20=20 > +if HAVE_GUILE_LIB > +SCM_TESTS +=3D tests/go.scm > +endif > + > if BUILD_DAEMON_OFFLOAD > SCM_TESTS +=3D tests/offload.scm > else > > Could you give the above a try? Feel free to commit it if it works as > expected. I tested this, and it works. Thank you! I can now build the release (with this change) and run the tests (make check) successfully; tests/go.scm is just omitted from the tests to run. By chance, I noticed the following lines below what you added: =2D-8<---------------cut here---------------start------------->8--- if HAVE_GUILE_LIB SCM_TESTS +=3D tests/go.scm endif if BUILD_DAEMON_OFFLOAD SCM_TESTS +=3D tests/offload.scm else EXTRA_DIST +=3D tests/offload.scm endif =2D-8<---------------cut here---------------end--------------->8--- I guess that if we omit tests/go.scm from SCM_TESTS, it not only means that the test won't be run, but it also means the test won't get included in the tarball distribution ("make dist"). Is that right? It seems undesirable to omit this test from the distribution just because the machine on which the distribution was built might have lacked the library necessary to run the test. Someone who builds Guix from the distribution might actually have that library installed and thus be able to run the test. To ensure that this test always gets included in the distribution, perhaps we should also add it to EXTRA_DIST like so: =2D-8<---------------cut here---------------start------------->8--- diff -u a/Makefile.am b/Makefile.am =2D-- a/Makefile.am 2021-05-11 11:09:31.000000000 -0700 +++ b/Makefile.am 2021-06-02 12:55:06.134793001 -0700 @@ -457,7 +457,6 @@ tests/git-authenticate.scm \ tests/glob.scm \ tests/gnu-maintenance.scm \ =2D tests/go.scm \ tests/grafts.scm \ tests/graph.scm \ tests/gremlin.scm \ @@ -505,6 +504,12 @@ tests/uuid.scm \ tests/workers.scm =20 +if HAVE_GUILE_LIB +SCM_TESTS +=3D tests/go.scm +else +EXTRA_DIST +=3D tests/go.scm +endif + if BUILD_DAEMON_OFFLOAD SCM_TESTS +=3D tests/offload.scm else =2D-8<---------------cut here---------------end--------------->8--- What do you think? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmC4lvIVHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadrl8P/RQ+ZAWw0aRUu1QkLy6R6wLGx3MY rEbEDLFFcfOKuREaIZS6lTGngllM+cV5vf/pU3xOV94JM9+TMl5Rl8Ex1xt1hlL4 FqU2Oe4O2rLLD1niCrdeAKfCM4zwUusXpvXK+4VCQNSa6JVy9/1zZVt5iIoVdNO+ VZmLvh0T0r8Zfc6XrvBh3f6YRC7WNKvJojHQjE9gwcRU2KTtHb3sBKsDRXqPAR5t DnAe6wUeK+UR/4KdtUGJ+fFRX89m0Q9EumOT+GceOA20TBQ8aRwaGXVdbM9RGjqg EKIFa4bzlesoHK27xQy0njfg/Kyx4D3tB9ta0fQK/mYe+A0C93sdNlZF4yGSV58D kN7g/RyESUuXT/O01eQzEO6l9iPQNSouqY9kkTKkIOcMV0EnBpG0aDWBl71CIlpm WWG1D6lOTQNRovJtMAC8g6GrxNDvr89RNo4+kSJO+nTNKhRgCy8DTcS0g4PaJ+s7 Rbhrs+TA5XpbmjXt9HeVRqgY3V8NKh4hmkAIsQrw0Y4eq3C/j2IGeAr88ZTLrmIX Hv6sQ4eYaMl+pUCkAh1ZavjQeATSScnzfrgD2p6AdWMOJeRQH7ELIR5gVQE9LiI7 fgmLKYxoa9NK1hrf1r5DG6Fx9GWOFvwV4C8z1tIXhmZdv+f+YiM50dc63V9DowY6 fyVOWUDGz/hKbM9v =cNNV -----END PGP SIGNATURE----- --=-=-=--