From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id dusHMhEC5GBZzAAAgWs5BA (envelope-from ) for ; Tue, 06 Jul 2021 09:11:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SP0oLREC5GDJYQAA1q6Kng (envelope-from ) for ; Tue, 06 Jul 2021 07:11:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 18A7025180 for ; Tue, 6 Jul 2021 09:11:13 +0200 (CEST) Received: from localhost ([::1]:40632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0fEd-0003sw-Iy for larch@yhetil.org; Tue, 06 Jul 2021 03:11:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0fEU-0003sm-Of for guix-patches@gnu.org; Tue, 06 Jul 2021 03:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0fEU-0004Qi-GT for guix-patches@gnu.org; Tue, 06 Jul 2021 03:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m0fEU-0004xF-9z for guix-patches@gnu.org; Tue, 06 Jul 2021 03:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49419] [PATCH 1/4] home-services: Add most essential home services Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Jul 2021 07:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49419 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 49419@debbugs.gnu.org Received: via spool by 49419-submit@debbugs.gnu.org id=B49419.162555540418966 (code B ref 49419); Tue, 06 Jul 2021 07:11:02 +0000 Received: (at 49419) by debbugs.gnu.org; 6 Jul 2021 07:10:04 +0000 Received: from localhost ([127.0.0.1]:47148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0fDY-0004vq-2G for submit@debbugs.gnu.org; Tue, 06 Jul 2021 03:10:04 -0400 Received: from mail-lf1-f44.google.com ([209.85.167.44]:33570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0fDV-0004vG-Jy for 49419@debbugs.gnu.org; Tue, 06 Jul 2021 03:10:02 -0400 Received: by mail-lf1-f44.google.com with SMTP id t17so36650136lfq.0 for <49419@debbugs.gnu.org>; Tue, 06 Jul 2021 00:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=EtZjUjIZ6TFs0wFNroqBvc/oncyppmt1ks0yKhftJwo=; b=dHS4OeY6rT4oKdv08REv4dth5uzqQlt0AgK0wHiKj8DOq7Wa8Z7nB/gAyGKKSpFD3W LdkEIdtF8m6s3ZMXyahEe3dr5K8i4yB1xN3H6xWOcY6V/jlxSxH6f23aEf8DT7mYSSzG y4FOPHvlscpMicziHidW903Uh3trNALK1PqHbIzWhdiiR+sevNm/H9sbBvcnJ4sP2ADi CSKuluiIM1FJEpedebYNj+ljX3aq4xon9I3q/sWgNoC8HWdsH/LD6qhDM05xndv7DrY+ yib0INCGE08sIsqQy8fulnyhzdiYaQWlJoK+oB3VnotMVN7NO6MK3p6HO17+3xP4shiT EO0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=EtZjUjIZ6TFs0wFNroqBvc/oncyppmt1ks0yKhftJwo=; b=LkIS+uyx0eycaaBS5yVk/ejPVDaupWR6clf04dYNhuBhy+ebHb9pYLQFzDm7eGDRn6 3kZACx2KSiqGT/mOK6Y4qc6enE/aI+eqLTFWo7NfsgDUH4zDTObEuGbdZr1Q6oBs3sZe WthhkOqQlA25aG+KVqNUa04GltZk8Y9UUOlG6Id/KbQcun3fB9BcviPu4rKplCVK2tCl bctqTqpLBvYgS3MN31YtCv+Epn8G2CvioQlqZn8uuFbmccDvy70UHr3PihofQOme2XVG a6pr3mviDsLD7X4CqfURCZYOn+yjof9uVtsZ/NHWq6OH1YimvaYrC3Ce7/O3pUphTxYd aHDw== X-Gm-Message-State: AOAM532HcG5+r/0F/tbv/LNh8MM53YynP+H4MbHiYkqf8jmM+pI3n73D kmQq0enoynTtkIbZpD8j/oD/DxipuYMvYA== X-Google-Smtp-Source: ABdhPJxnZ2obTi1AXQGtyt1ng20ukrdn2GM5RECFtfRMP37c1mWuBH+Q6QQEj9st8ILd6vG2PvaR3A== X-Received: by 2002:a05:6512:1056:: with SMTP id c22mr1622551lfb.187.1625555394166; Tue, 06 Jul 2021 00:09:54 -0700 (PDT) Received: from ixy (109-252-117-164.nat.spd-mgts.ru. [109.252.117.164]) by smtp.gmail.com with ESMTPSA id m6sm1304669lfu.238.2021.07.06.00.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 00:09:53 -0700 (PDT) From: Andrew Tropin In-Reply-To: <6b465d9991c15eb9fc9f8def6aa3293a872352c1.camel@telenet.be> References: <87y2akhiz1.fsf@trop.in> <87wnq4hivq.fsf@trop.in> <9ee31c62aef0a42b15b48ece2c1d0fe765fdcc83.camel@telenet.be> <87mtr0hgx0.fsf@trop.in> <6b465d9991c15eb9fc9f8def6aa3293a872352c1.camel@telenet.be> Date: Tue, 06 Jul 2021 10:09:50 +0300 Message-ID: <87im1nhq9t.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625555473; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=EtZjUjIZ6TFs0wFNroqBvc/oncyppmt1ks0yKhftJwo=; b=TtfRVojDJTgcQZVehTZ3k+HFm22JHbACgaE1R8akxvPQ3sh4un4MvocDEhXvoy1g/FQ9+F BDeWLNTbOYxEBbLMw0eyJP67Vpm6BkyNjEU/gI3cwZ/cqZ+1pz+VozfgU94MaftWFx8Hzv 55fNRFXU8zW0C9QuacAWiP1hTFoJoQZLYLebR1YijUeWJegEYwgj72xFyP4rbyM+n0ekvG ZtQc4CSmqyOzrlzGcZAZE+cF4Oy9vQD3AWZbtyAkIg7nBwAWlRg92gY8LRy/z7fQCzAZpJ mNJ5K7FCibgRHG1qB09QQHClSkrxskGCKfqTqrdM1GP9h8L7uILh5cuLIpwssg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625555473; a=rsa-sha256; cv=none; b=mVH+Juq8xw3hGEtyzinMpsRmWlz1kGTg6w00K9Gy2+qOqwP1K07IQfrc7aQn38VBkPp0AD OP9CkRM/iIg66iVeZKK6z8AC3q7O+nGcnYwoHVsIUIvKhz0gRtR5sMC0Ueu39PmOqKw4zQ OkB34aUOHlIVAfxg6dqDOsF8JAihNgqOgs+LQhDjwnZDrTHuY0mPffOga6Pa1bLAL74M4l PFdVIwvJuxRt+ElCRXQaHlQNojbhVy6t98+d3JkT8BVW+l9Ce35uSz7gWNhdlL3gmJm+tz nHGlFbMHPi6FtQqrIVlef83aSCkb/hk6lEjkweLXrwb/wxSPshZWpSqkDSGhvQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=dHS4OeY6; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.51 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=dHS4OeY6; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 18A7025180 X-Spam-Score: -3.51 X-Migadu-Scanner: scn0.migadu.com X-TUID: XcaVFO1V5CpO --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Maxime Devos writes: > Andrew Tropin schreef op ma 05-07-2021 om 19:19 [+0300]: >> Maxime Devos writes: >>=20 >> [...] >> >> BTW, how to add changes to the patches? Do I need to resend a >> particular patch with required updates or have to wait other reviews and >> send a v2 patch series? > > I would do a combination of those: reply to the mail of the reviewer with= a > revised patch attached. When you have received a =E2=80=98sufficient=E2= =80=99 number of reviews > from others on the other patches in the series as well, send a v2. > > Some benefits of this method: > > (1) it should be clear which patches should be applied, > as the number of 'revised patches' without sending a new series > version is limited. > > This is also the case if you send a new version after each little c= hange, > but can easily become _not_ the cas if you always respond with a re= vised > patch without starting a new series version. > > (2) you don't clutter the mailboxes with new version after new version > after each little change. > > This is particularily important if you have large patch series (say= 13 or > more patches), which doesn't seem to apply here. > > WDYT? I came up with one more approach: I can send a patch, which address the issues reviewer mentioned and after getting more reviews from other peers I can rebase my original commits and incorparate all the later patches to them and prepare v2 series. [PATCH 0/4] [PATCH 1/4] fix1 to address issue from subthread1 reported by r1 fix2 to address issue from subthread2 reported by r2 fix3 to address issue from subthread2 came during discussion with r1 and r2 [PATCH 2/4] ... Such approach makes it clear how the comments were addressed, because now you see a diff, not the whole new patch. On the other hand it can be a little harder to reply, because you don't have the latest version of the patch, but have only original patch and updates to it, so you need to pick, which one you want to reply to. I will try this one, to find its weak points. It's better to practice on this small patch series, rather something huge) Another question: Is it better to inline or attach patches? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmDkAb4PHGFuZHJld0B0 cm9wLmluAAoJECII0glYwd6wjAMP/3HfCFMBPLkyY3E8LrGZ5y9Y5x4ezbdnvC+I GeVjML5vMzVQ1RI/eIvtzfF2pCxN1ID+41gFvRv+fJ6JWceu0uwMWhOK9mktkKBG V5+gB6aX1CuCoVh4ekIt1DcT6TeQlUvE06y6196xspCeCI0OpnH2FJNfvU3Y+reC 1wK6oL5ch9kKjyF+09U/U8DRWyEc1GSrETM7DQ6i5dYiy7l8KVNgbj7THRHI36as ia5Fw8axZ1uoXPFDqmnbuHuCuGP5ch98e+0K2jJL7+1cysPjtbkzzeXAHKNsVo/l AH5DhN38zy/Jnsyv55Kdkb6MF9BR+Dehm8aRJoFrAoFzBTgJw7zGRSB4OvwLLdSg +n7hy8+EGmX8XU4psLS4r1isXTScCiela1rNq/P6t3xmOlP8xNkZ2t/VAg9qeqca c3pkXtOHjTYlp5eyo1/jPr6Uto2uJL6CkPAJZyyeX8VT7wRvduYLratJ3c33xYnH tjLVOqdoJwOEPcEu0rnt05y/VbSNsUSz7P/RO9YUDqBI/w913EgN8hz3uR5f8L2/ fZpUfdnUYlcQ1LH2Vbj8UIEIf7c65To+14dQUunoN3z8nwR2pPfO5SCbmjZBFzii /2IG36ozJ1XL6x9lu79hDkkXJkVQkW50kGuDsM89j86AASgThs4AtWusSma2nqrm oBqdTYd4 =ePjX -----END PGP SIGNATURE----- --=-=-=--