From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sCM7D75URGFWpAAAgWs5BA (envelope-from ) for ; Fri, 17 Sep 2021 10:41:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2FD+Cr5URGFVLgAA1q6Kng (envelope-from ) for ; Fri, 17 Sep 2021 08:41:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1233810CAE for ; Fri, 17 Sep 2021 10:41:34 +0200 (CEST) Received: from localhost ([::1]:46226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR9R6-0002Fd-NN for larch@yhetil.org; Fri, 17 Sep 2021 04:41:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR9Jq-0007G5-Gw for guix-patches@gnu.org; Fri, 17 Sep 2021 04:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46904) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mR9Jq-0006kF-4a for guix-patches@gnu.org; Fri, 17 Sep 2021 04:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mR9Jp-00024k-Uc for guix-patches@gnu.org; Fri, 17 Sep 2021 04:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50615] [PATCH] gnu: grokmirror: Update to 2.0.11. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Sep 2021 08:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50615 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Kyle Meyer Cc: 50615@debbugs.gnu.org Received: via spool by 50615-submit@debbugs.gnu.org id=B50615.16318676157936 (code B ref 50615); Fri, 17 Sep 2021 08:34:01 +0000 Received: (at 50615) by debbugs.gnu.org; 17 Sep 2021 08:33:35 +0000 Received: from localhost ([127.0.0.1]:58450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR9JO-00023w-Kh for submit@debbugs.gnu.org; Fri, 17 Sep 2021 04:33:34 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:33460 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR9JM-00023e-Gk for 50615@debbugs.gnu.org; Fri, 17 Sep 2021 04:33:33 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1631867603; bh=i4WUXkfs2fSgls31pwyHgBtSIBazg6c8kOe9Ar1CZM4=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=eH2W1Geg4Lgx9QdGuicEMrbXc/JUh8qVrLHfYyiuWo6JEhEqkktFnmLRwyv8Y4fUT nLjU/f68bt70GqjOBlFNG2GwZ14j2EfUhun6INEnHcELN+00oOf0UhkxW2/pa/g9vq ZQZKIvv2OnkHuhp7jeOCloD3/fsyUu7rXhmP2Ywc= In-Reply-To: <87lf3vvr30.fsf@kyleam.com> References: <87lf3vvr30.fsf@kyleam.com> Date: Fri, 17 Sep 2021 10:33:22 +0200 Message-ID: <87ilyzppnx.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 1233810CAE X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: EfSsiZuQ8rsW --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Sep 16 2021, Kyle Meyer wrote: > Xinglu Chen writes: > >> * gnu/packages/version-control.scm (grokmirror): Update to 2.0.11. >> [arguments]<#:phases>: Don=E2=80=99t return #t. > > Thanks for keeping grokmirror up to date. You are welcome! >> (define-public grokmirror > [...] >> @@ -2487,8 +2487,7 @@ Mercurial, Bazaar, Darcs, CVS, Fossil, and Veracit= y.") > > Unrelated sidenote: you could get a more informative hunk header for > your patches by defining a custom one (more details in the gitattributes > manpage). Ah, thanks for the tip! >> "/man/man1/"))) >> (mkdir-p man) >> (for-each (lambda (file) (install-file file man)) >> - (find-files "." "\\.1$"))) >> - #t))))) >> + (find-files "." "\\.1$")))))))) > > Oops, sorry about the unnecessary #t. I did a quick search of the > lists/manual but didn't find any pointers/discussion. What's the way to > decide when a custom phase should return #t (like in the below snippet > from the manual)? > > --8<---------------cut here---------------start------------->8--- > (modify-phases %standard-phases > (add-after 'install 'fix-egrep-and-fgrep > ;; Patch 'egrep' and 'fgrep' to execute 'grep' via its > ;; absolute file name instead of searching for it in $PATH. > (lambda* (#:key outputs #:allow-other-keys) > (let* ((out (assoc-ref outputs "out")) > (bin (string-append out "/bin"))) > (substitute* (list (string-append bin "/egrep") > (string-append bin "/fgrep")) > (("^exec grep") > (string-append "exec " bin "/grep"))) > #t)))) > --8<---------------cut here---------------end--------------->8--- I don=E2=80=99t think it documented in the manual, but on =E2=80=98master= =E2=80=99, phases have to return #t, otherwise, you will get a warning message about it. But once the =E2=80=98core-updates-frozen=E2=80=99 branch gets merged (should b= e soon=E2=84=A2), phases don=E2=80=99t have to return #t anymore. Since the boilerplate won= =E2=80=99t be needed once =E2=80=98core-updates-frozen=E2=80=99 gets merged, I thought it= would be a good idea to just remove the #t. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFEUtIVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5vV8P/jo3pO7uQY3fqAdUemBY7Dw+6jBW 6IOmB7Xgwf9kWQS5wN6Epx4fLtW/3atllmZprwxm0yYt6/1VBd/TNTQ8FEiZOghu j5P3Tm92/pcEBeYk9Iz0131ZUdnxvBghMTgXywq2B7te8qu63ej6b5i0zFLsWiCQ tfiWrBd4US6HPy6A6Wv0A1sNnO5C5ECvKMnA38MjFMDEkmjzP1lDZtvUtDCAFGN4 pLwVuFb6Gkhv7peXQlTN8Fp/Lzxa1RA0ZQ0lNUWMrYNU2OBtdfQrhfFBIkIrkvf4 m3MeovHgkXnbFhPu5qYIZfz8wtFSUVWl5/Sib1Q+yLslv+QKtcWk896xh79Y4xQ7 z659F7ki7dSqOguh5jOXAjawkMth9B4NnsPSJmjgpBHRiTR/GWsUEjlxReGS1KkS I6OB8SGbdx+9+8mLBQR4fcLpUuOs0gfpdr9Sb7rHDWOkyPmNBONMSArc6nfXs4Yx Y85lu+NIFRAX64z/x15osXqN+uWg2jLtQoXw9m2Edo7wWAbbeEXjfzBkbAyYVtir OJSyJJfSXA4dxN9TSnK68cWp5LMY/q91eneKvnWuMej/PpLbSgmYlMBD4uT/eCwb fIAI9hURWNqvmeSj155MEc3cOQ8MWq8aona4Gb256YHIqaUFCvibrxexCl6HKToR odXxYIxy9E+CdreO =gBCM -----END PGP SIGNATURE----- --=-=-=--