From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +4wNHvLVSWFgCwAAgWs5BA (envelope-from ) for ; Tue, 21 Sep 2021 14:54:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sG4xGfLVSWFtXAAA1q6Kng (envelope-from ) for ; Tue, 21 Sep 2021 12:54:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29D8119450 for ; Tue, 21 Sep 2021 14:54:10 +0200 (CEST) Received: from localhost ([::1]:40574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSfHl-0000tb-6U for larch@yhetil.org; Tue, 21 Sep 2021 08:54:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSfHd-0000sK-Vi for guix-patches@gnu.org; Tue, 21 Sep 2021 08:54:01 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSfHd-0006qZ-Op for guix-patches@gnu.org; Tue, 21 Sep 2021 08:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSfHd-0002KZ-NG for guix-patches@gnu.org; Tue, 21 Sep 2021 08:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50476] [PATCH 00/10] Update guile-dbi and guile-dbd-* Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Sep 2021 12:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50476 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 50476@debbugs.gnu.org Received: via spool by 50476-submit@debbugs.gnu.org id=B50476.16322288388949 (code B ref 50476); Tue, 21 Sep 2021 12:54:01 +0000 Received: (at 50476) by debbugs.gnu.org; 21 Sep 2021 12:53:58 +0000 Received: from localhost ([127.0.0.1]:45282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSfHZ-0002KG-Su for submit@debbugs.gnu.org; Tue, 21 Sep 2021 08:53:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSfHX-0002K1-VZ for 50476@debbugs.gnu.org; Tue, 21 Sep 2021 08:53:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48528) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSfHR-0006j8-JL; Tue, 21 Sep 2021 08:53:49 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=47304 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSfHR-0001aI-AZ; Tue, 21 Sep 2021 08:53:49 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210908145413.4652-1-arunisaac@systemreboot.net> <20210908145413.4652-3-arunisaac@systemreboot.net> Date: Tue, 21 Sep 2021 14:53:47 +0200 In-Reply-To: <20210908145413.4652-3-arunisaac@systemreboot.net> (Arun Isaac's message of "Wed, 8 Sep 2021 20:24:06 +0530") Message-ID: <87ilyuks2s.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632228850; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=MmsYb9pCz/pSsc6/oywQ2Hh5Bk/RXEA0PeOsQjrz3X4=; b=V4NHbbOCUQzFZCs2nXzYWPg8KOZ/Yxz8B6SWVHC849DPRz8UGPkBlnH4DOMuDZMxbTJ7Jj Km+szO6D9HLyp/Ai/YW4Pk9kkR8ofmaXZQ0qiRnJbyZ4XcYEH8FIn4Y73Zpko4jcn4GL3O OwvcexiEj0bJ1oBDPjsYVrX1H4K+qJzflAvHiHHDOS1c3t8Lvm6XlJGnUIO+ijVfsVoe89 zBmxYnaNnlbOY1Scnma4hyM6SUY6Ts3Jm/YPNx+JoeLQCl3X6ncgjDl1OLZLDRWJmbGffF 7MKqZtIPT2b5H+zgr19k5yPJNahGpvHz4fKB9tKoTN0U/9+n9uQappFD0RIoZQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632228850; a=rsa-sha256; cv=none; b=NhOU2TOanbAmTxBGkONcKnStX3jsnplPdSnMgekaAYfsKRjnkIOyk66po+Q1UYQjqGINiT qEdn9yGjlhYDe2IukUjxIUAd8SFMJk+cUQxFkpd8XIZ8Qx2Ulck73Qe+IqC0Ipt9FhoEHD OlmuQGI50ge+kFvPdy/I2iP/NFWW+xxpqk94RucsR2tXKI0Jza/sZTXcMGXhRg+u5KiByM QD3rqnFhKe6c30cmqAnkdgp6wBCpT2Kk3mrq4hPx0VbF8EXXBO6/ltHWnQN31JppwGLFTo HCXMOUdF75zdvR2MBytF99baY4gtJUIrRO1IL/jxwjzQFO4u6L0JD9c8zHqmpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.89 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 29D8119450 X-Spam-Score: -2.89 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1WvKPsH3wSJI Hello! Arun Isaac skribis: > * gnu/packages/guile-xyz.scm (guile-dbi)[arguments]: Do not set LDFLAGS a= nd > RPATH in #:make-flags. > [inputs]: Remove guile-dbd-sqlite3 and guile-dbd-postgresql. > [native-search-paths]: Add LD_LIBRARY_PATH. [...] > + (native-search-paths > + (list (search-path-specification > + (variable "LD_LIBRARY_PATH") > + (files '("lib"))))))) I think we should not add LD_LIBRARY_PATH as a search path spec as it can have undesirable side effects; it=E2=80=99s just too broad and risky. The difficulty here is that we want guile-dbi to be able to find its guile-dbd-* plugins, right? The previous method, which was to set the RUNPATH of guile-dbi pointing to guile-dbd-*, sounds preferable to me: it=E2=80=99s localized and does the job. The downside of the RUNPATH method is that these are no longer really =E2=80=9Cplugins=E2=80=9D: you end up pulling them whether or not you use t= hem. Perhaps you were concerned about the closure size? If that really is a concern, I=E2=80=99d recommend taking a different appro= ach, such as using/defining a dedicated search path variable. WDYT? Thanks, Ludo=E2=80=99.