From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IM5+H+RsUmFFLwEAgWs5BA (envelope-from ) for ; Tue, 28 Sep 2021 03:16:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YCkQG+RsUmFeQwAAbx9fmQ (envelope-from ) for ; Tue, 28 Sep 2021 01:16:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0E2AA2FD63 for ; Tue, 28 Sep 2021 03:16:20 +0200 (CEST) Received: from localhost ([::1]:56800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mV1jF-0000A2-Ui for larch@yhetil.org; Mon, 27 Sep 2021 21:16:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mV1j1-00009j-Ie for bug-guix@gnu.org; Mon, 27 Sep 2021 21:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mV1j0-0001FZ-Dp for bug-guix@gnu.org; Mon, 27 Sep 2021 21:16:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mV1j0-0006g0-3X for bug-guix@gnu.org; Mon, 27 Sep 2021 21:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50299: [PATCH v2 01/27] lint: check-tests-true: Allow #:tests? #t for some build systems. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 28 Sep 2021 01:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50299 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Received: via spool by 50299-submit@debbugs.gnu.org id=B50299.163279170725591 (code B ref 50299); Tue, 28 Sep 2021 01:16:02 +0000 Received: (at 50299) by debbugs.gnu.org; 28 Sep 2021 01:15:07 +0000 Received: from localhost ([127.0.0.1]:43246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV1i6-0006eh-Ok for submit@debbugs.gnu.org; Mon, 27 Sep 2021 21:15:07 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:34732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV1i5-0006du-3X for 50299@debbugs.gnu.org; Mon, 27 Sep 2021 21:15:05 -0400 Received: by mail-qt1-f173.google.com with SMTP id m26so6976067qtn.1 for <50299@debbugs.gnu.org>; Mon, 27 Sep 2021 18:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OmlKkFIofBQcPD3b3EBhYfrGnY45FpRlkGdrtE79g1M=; b=Keroo+iw5wPe2hgrzDvV1lZPAwdxTPBvWr5w7z5FQqRvlVY2h2loDWEQVrXKKKVkHQ zn/P37CaiYnuW5ShFEPqCO1sdI5NRSfWy6KNR6fgh15f44ifwA5eaBaU3Vyw4DhOHehk N7cNSctGsWLfPEWpHrPPPgtLiTskeLxpjG/KeOphtGNxSQLn4rwow9plXZ4dYNEvuame dpJtlWorPcLEGzDKuqKSfvGHRa6Xb4WoEANhpXtvyNn/bh/nT6Ny83oT1H8XxJf+w4Ve arIS1/Td3pBAlfMFJ2mHOrUmhqWoEeb4IUbRMbw4Dmr0UdnhQJbhKs2VNALkDw3OIqhs cD1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OmlKkFIofBQcPD3b3EBhYfrGnY45FpRlkGdrtE79g1M=; b=q396tVNfuq06Rgp92FGF+PnDDkW+km03/Pvo93n7RnSOD/1Lsxm9Cjzs8woYI5+eYb y2fYmUmbNtAqfd7E1WUO0VEvNClqUX3OXr9OOUj9CDky8yDSDJhcLgGoxGnOgZlgr5UC wHv0ADjUHh0P7JVSQRYKW2zaZBu7zRnuYwv2EYaudsEttiQDbqbJd0qutQz+W0keS7N7 +refCzS8IE+SFWWWmT82qN6TwwItar8XMfWWvtoQRFifyfHuoV12cKAttyt8KI+8JMC+ SpF5bSFJtAVP6rl2XYNX9K0Wwhn+mFM0dj/yo7tM0gLyo5VnI5t35Kmat1xoM4z/vWYp 6Cqg== X-Gm-Message-State: AOAM530KdKI1lRffnSdNTqRCUXXfUe23kBB+WUzMEBTo8nSyVjYE3/qs AFByM433WtVlxDNek28gnsHPQxEp7R4= X-Google-Smtp-Source: ABdhPJxIV46sQINUQBMUQxVrAvC17cFhGDQy+K0c1o2pLwycqqBEeDrrtU83Py/CwHW4o65wKCst2Q== X-Received: by 2002:ac8:15a:: with SMTP id f26mr2909524qtg.417.1632791699379; Mon, 27 Sep 2021 18:14:59 -0700 (PDT) Received: from hurd (dsl-10-149-239.b2b2c.ca. [72.10.149.239]) by smtp.gmail.com with ESMTPSA id v1sm9867103qkv.37.2021.09.27.18.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 18:14:58 -0700 (PDT) From: Maxim Cournoyer References: <20210927154537.28227-1-maximedevos@telenet.be> Date: Mon, 27 Sep 2021 21:14:57 -0400 In-Reply-To: <20210927154537.28227-1-maximedevos@telenet.be> (Maxime Devos's message of "Mon, 27 Sep 2021 17:45:11 +0200") Message-ID: <87ilylijqm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 50299@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632791780; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=OmlKkFIofBQcPD3b3EBhYfrGnY45FpRlkGdrtE79g1M=; b=NfwRZKW1maWxgNMLuH3GD7AG3IA9DCjbFEFfcsUFadKkyODxodGrxBlfy5FFfmDNtUf7Rg +aB1jDq2dxDoiDQpnwceSStGslYogp5sGzlaJl2DmNCm9Gq2nFlbu7G4KEYPOkDTVhH9c3 ArTPCXF6qq1aIf83eCmUQzL9C1P7JCxYMQZAi4s4UzmOnD/iJtP1yJ5jgZMlHv/g+6zAAi L0t4kRhoRAGih1rVxbYulGraN2B9558MkwLcwhxojSa8bYRdhEvkUkJbbl3z6Z89GH0Hfj eSkQjzAoauPf60/v8aJRtnFChJ5zyz3WT3hkn6wyWB/Zz3Kk9YuCjxSi7Tpl5w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632791780; a=rsa-sha256; cv=none; b=inaz3EaH2vkBWG+NsFwHhplradb58naIVnm4S0bi4izwUYJ5hX14eWp6rEnbJKeEqycpEt yUlabtjliKkR+DBISsfHNR6T6zu+ypapb8xQgO8giYRdegpnKn67LKPSVxlCktXeObB+N4 J7znF5sDe0XbPV/n5ARyMS2eRAVshbcpcaKt8qz6v+VVwWpFfNQChHPLDLl9kFsXXrwDD5 +uy/50zxA6zUhfNGnrg/r3lt855c0d0R+xdldpPtJHYEHw5+h4Eu+F2TLXqQC9ICet0ReZ tVuiWDhasNED8ROMcs/T2UCJknn0bdaikatLz+nbYkE+kYqT2+BwdHus8nGbAA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Keroo+iw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.69 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Keroo+iw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 0E2AA2FD63 X-Spam-Score: -1.69 X-Migadu-Scanner: scn1.migadu.com X-TUID: aJiB0485Tp/k Hello! Maxime Devos writes: > emacs-build-system sets #:tests? #f by default, so the linter > shouldn't warn if #:tests? #t is set for packages using > emacs-build-system. Likewise for texlive-build-system > > * guix/lint.scm (check-tests-true): Do not warn if the build system > is emacs-build-system or texlive-build-system. > * tests/lint.scm > ("tests-true: #:tests? #t acceptable for emacs packages") > ("tests-true: #:tests? #t acceptable for texlive packages"): New tests. [...] > diff --git a/tests/lint.scm b/tests/lint.scm > index 0f51b9ef79..7b04dc98d4 100644 > --- a/tests/lint.scm > +++ b/tests/lint.scm > @@ -35,6 +35,7 @@ > #:use-module (guix tests http) > #:use-module (guix download) > #:use-module (guix git-download) > + #:use-module (guix build-system emacs) > #:use-module (guix build-system gnu) > #:use-module (guix packages) > #:use-module (guix lint) > @@ -324,6 +325,25 @@ > `(#:tests? ,(not (%current-target-system))))))) > (check-tests-true pkg))) > > +;; The emacs-build-system sets #:tests? #f by default. > +(test-equal "tests-true: #:tests? #t acceptable for emacs packages" > + '() > + (let ((pkg (dummy-package "x" > + (build-system emacs-build-system) > + (arguments > + `(#:tests? #t))))) > + (check-tests-true pkg))) > + > +;; Likewise, though the 'check' phase is deleted by default, > +;; so #:tests? #t won't be useful by itself. > +(test-equal "tests-true: #:tests? #t acceptable for texlive packages" > + '() > + (let ((pkg (dummy-package "x" > + (build-system emacs-build-system) ^ texlive-build-system ? :-) Thanks! Maxim