From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aP14DUlwX2ERCgEAgWs5BA (envelope-from ) for ; Fri, 08 Oct 2021 00:10:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iG4jCUlwX2FdHgAAbx9fmQ (envelope-from ) for ; Thu, 07 Oct 2021 22:10:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B962D0E7 for ; Fri, 8 Oct 2021 00:10:16 +0200 (CEST) Received: from localhost ([::1]:48734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYbah-0001fd-KM for larch@yhetil.org; Thu, 07 Oct 2021 18:10:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYbaV-0001fL-UJ for guix-patches@gnu.org; Thu, 07 Oct 2021 18:10:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYbaU-0003ld-1w for guix-patches@gnu.org; Thu, 07 Oct 2021 18:10:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYbaT-0001A3-RE for guix-patches@gnu.org; Thu, 07 Oct 2021 18:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42180] bug#51061: [PATCH v2 01/23] guix: Add extracting-download. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Oct 2021 22:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42180 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 42180@debbugs.gnu.org, 51061@debbugs.gnu.org Received: via spool by 42180-submit@debbugs.gnu.org id=B42180.16336445574401 (code B ref 42180); Thu, 07 Oct 2021 22:10:01 +0000 Received: (at 42180) by debbugs.gnu.org; 7 Oct 2021 22:09:17 +0000 Received: from localhost ([127.0.0.1]:48631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYbZi-00018l-5b for submit@debbugs.gnu.org; Thu, 07 Oct 2021 18:09:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYbZg-00018S-LZ; Thu, 07 Oct 2021 18:09:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50420) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYbZb-00034q-6Z; Thu, 07 Oct 2021 18:09:07 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36518 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYbZa-0000Q0-SX; Thu, 07 Oct 2021 18:09:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <626e4718c45c95a7278460f132bd38e08835e9f4.1633533541.git.h.goebel@crazy-compilers.com> <1aa101af088dceee34ad9373f153b5f7dd7603ba.1633533541.git.h.goebel@crazy-compilers.com> Date: Fri, 08 Oct 2021 00:09:05 +0200 In-Reply-To: <1aa101af088dceee34ad9373f153b5f7dd7603ba.1633533541.git.h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Wed, 6 Oct 2021 17:20:01 +0200") Message-ID: <87ily88p32.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633644616; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=VYWPlJtCamOYrrgTQaxU3o5yxmaZlv2AX60EIXQZNbE=; b=BFEUdzEJMsTymYvFSW40lKMXTg4Vh9kFiHuuI95NjS4YAx+U8XImXnrVaVfD+vRDnmvgkU hj8k98GAkz1R1Lr1qvs81QabCNUFImnywMFbzsMvZVNXwEBmtcW2YWWs0Uylykiwt+leaI UZNo1jt2AW8MdQ1b3SnSqmjbcS+EQjbOIPtbP2R5l8B82JLtjF06TeNfAxE8lYZ0y+FQ2w N0DDwgrsiynY3+dZ9lnLv71vn6VlqjA8ENIyzy/KD15smb2aTz9/Q071Aca27LbzbL9SfU 7Cjv7jYVcYbK/AtR3P1jChHP14DfMEO9ntbvs2GWVCGyVkxTf1nl07bcgyuVFA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633644616; a=rsa-sha256; cv=none; b=Pg59yTtdDwEKEwUe9WPtPOjLo83kAjNPRKdWgQNRw0OTdvso+9b/kT08++JR/aicuNgP1I B+Mj+OQUdMM0un9eySI2P97t5pxMwRZHpoBegCk+FdTjffnILG7/k7AWhkC+UPq7hDcgTS GTVnfN2ebDchqJ6wls4qZH+FX/Gn2BvhU5iks8bovjo6pbt5wwgUqjqATNlIBA/yZetWxC x0qUNFVL+ZVx1nIC/NLSUe/LM+OiZ64sQ+I4Zo02KyYXOqBN475WnkAXrBTjCzkcWyE99a YbXvOLKUBGMvABToBLjiUe3eRqMOLHY9XJyUcGZ95OYw+2Kj4Zj791FWZeCUxw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6B962D0E7 X-Spam-Score: -1.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: G9MhQwHS9Rf3 Hartmut Goebel skribis: > * guix/build-system/rebar3.scm, guix/build/rebar3-build-system.scm: New f= iles. > * Makefile.am (MODULES): Add them. This looks OK, except it=E2=80=99s undocumented: https://guix.gnu.org/manual/en/html_node/Build-Systems.html I=E2=80=99d be in favor of reverting until we can see the doc. Also, I would have suggested not adding new build systems on =E2=80=98maste= r=E2=80=99: they=E2=80=99ll have to be adjusted on =E2=80=98core-updates-frozen=E2=80= =99, and I=E2=80=99d rather distribute the workload on this and avoid merge issues. > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2016 Ricardo Wurmus Is Ricardo involved? > + (for-each > + (lambda (pkg) > + (for-each > + (lambda (dirname) > + (let ((src-dir (string-append build-dir "/" pkg "/" dirname)) > + (dst-dir (string-append pkg-dir "/" dirname))) > + (when (file-exists? src-dir) > + (copy-recursively src-dir dst-dir #:follow-symlinks? #t)) > + (false-if-exception > + (delete-file (string-append dst-dir "/.gitignore"))))) > + '("ebin" "include" "priv"))) Regarding the style, please avoid abbreviations: =E2=80=98source=E2=80=99, = not =E2=80=98src-dir=E2=80=99, etc. https://guix.gnu.org/manual/en/html_node/Formatting-Code.html The root of a package directory should follow the usual layout: bin, sbin, share, lib, libexec. I think we should not have =E2=80=9Cebin=E2=80= =9D and =E2=80=9Cpriv=E2=80=9D, unless there=E2=80=99s a very good justification. Thanks, Ludo=E2=80=99.