From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QNsKB8vfo2Eh6AAAgWs5BA (envelope-from ) for ; Sun, 28 Nov 2021 21:00:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GMO4Asvfo2F5eQAA1q6Kng (envelope-from ) for ; Sun, 28 Nov 2021 20:00:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9F58528B3F for ; Sun, 28 Nov 2021 21:00:10 +0100 (CET) Received: from localhost ([::1]:54142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrQLJ-0000b4-Q1 for larch@yhetil.org; Sun, 28 Nov 2021 15:00:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrQLC-0000av-PU for guix-patches@gnu.org; Sun, 28 Nov 2021 15:00:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrQLC-0006gv-Bi for guix-patches@gnu.org; Sun, 28 Nov 2021 15:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrQLC-0002fY-C0 for guix-patches@gnu.org; Sun, 28 Nov 2021 15:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH 00/11] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 28 Nov 2021 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 51838@debbugs.gnu.org, Philip McGrath , Liliana Marie Prikler Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163812958210204 (code B ref 51838); Sun, 28 Nov 2021 20:00:02 +0000 Received: (at 51838) by debbugs.gnu.org; 28 Nov 2021 19:59:42 +0000 Received: from localhost ([127.0.0.1]:36395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrQKs-0002eW-9C for submit@debbugs.gnu.org; Sun, 28 Nov 2021 14:59:42 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrQKq-0002eG-6R for 51838@debbugs.gnu.org; Sun, 28 Nov 2021 14:59:40 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C00A25C00AE; Sun, 28 Nov 2021 14:59:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 28 Nov 2021 14:59:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=0DIN/f9osEv9HSArYNlyI1uIeawvVxWOh0faRvpiG fU=; b=YQ+sh7adHCjtsfJDlp0H/IdN8anpPXzlYsxotGlRWZwhlfbiyF4homIIp A+/SHYbyaUs5lABr69KxCI4ihjbsxgIKYzR8r+HLnKpQuRFVVUb4O1nBrUN5szcK q2L2P+1mIaeMIy7PfZrQVYcxbYFkgdqaU3a5/jIgG/JRuZHmygwjp1ik6MiXcKVM AEYSwsz9hE/LXr7Za6+BESRpmQ3qf/LkOoFXydju3qECIsb8E9zt0euvDbbwZxmV CL3+7sBpfBGE8XJOKMiME6KU6uBvGtSIWc//YG1Sxv6yfPIdWcFS927BPycdxJQo fHrT09zLA/ljJwzZ3U0Bx0VWJs1VQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrheeigddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfhimhho thhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrf grthhtvghrnhepvdelvefhheegudevjedvfedtveeileffveehveejgefgteetteejteel tdefueevnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 28 Nov 2021 14:59:34 -0500 (EST) From: Timothy Sample References: <20211114125830.45427-1-philip@philipmcgrath.com> <20211114130409.49241-1-philip@philipmcgrath.com> <20211114130409.49241-2-philip@philipmcgrath.com> <48018e12484d19466d9c6f253a8d7ebeae93e947.camel@gmail.com> <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <87tug6bnen.fsf@ngyro.com> <87czmqk29d.fsf@gmx.com> Date: Sun, 28 Nov 2021 14:59:33 -0500 In-Reply-To: <87czmqk29d.fsf@gmx.com> (Pierre Langlois's message of "Tue, 23 Nov 2021 20:54:26 +0000") Message-ID: <87ilwcm4pm.fsf_-_@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638129610; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0DIN/f9osEv9HSArYNlyI1uIeawvVxWOh0faRvpiGfU=; b=UKvzQ582ME1aIbg7SE3/G96Oy4p24gIB6WJta7a6Wmseg1/6JIZaAQWCvq+aQHUbmUYGLf YZVoTKfcMxYHbVda2LOdQHgZWj2F8QLs9cQQFryUIySBV84YatKWqLb7GWxyiZQQwFKzyv EMUz09R4G6RpDL9oRsScH3AiSBgl8WWy1zkdxlTS90lOd478TBg3EmBA1YoqDExKiUYffx ScICqfOzx6C9BSMs7vfmOuPWYBUVKpdATlcsk51vIQrDuP3nVEyvoLb8yis93Yi0m5c+0T 9PhFRMUCY8aQcokqJrBMfL05ub1vHo6QOZgCx4ibzrKxei8it1df6GidqTrrXA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638129610; a=rsa-sha256; cv=none; b=rejh3CbK5rb3YtodW9zABYRXJU2hqmPZgPuuJBbtuWdhj5orKlwG2SlmAv5FTuk36VBur8 41y9lg7LwixcGWJ69vJhgLBOcnxE8b1odis1Zqc6EQSzd+zVq4XmdCj0u4ihv1R6niZ0ho CaYlxqU+tz7UQJH9pLyxZrUo2w6dxX6LgD1ZopxWirAhMGhJVfYkmRsCn++E5Ycq3c8/wr 4xNqBL6E/QBsLiNmGHlwYPCuo5G5LD6i5Ou6MilpGz3q0/43536u9C6WjOCUxW3vwzECv+ KNlMToU6PdgFLixSXfcX/0orq7QI10eWUcI60x7La5JoC0u7F3dtLkv3HU+aKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=YQ+sh7ad; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.51 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=YQ+sh7ad; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9F58528B3F X-Spam-Score: -0.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: u9h7OYgsubaY Hello, Pierre Langlois writes: > Hi Timothy, > > Timothy Sample writes: > >> More importantly, is the general plan that we merge these changes, >> and then Pierre rebases their Tree-sitter changes on top these? >> >> Pierre, maybe you could weigh in here? > > The overall approach looks good to me, it's better than what I > originally proposed for sure :-). That being said, I'm not very > familiar with the Node.js ecosystem so I don't know if it's necessarily > the right way, but I suspect the correct way for node isn't very Guix-y > so I'm not too worried about that. The whole Node.js bundles NPM, which bundles node-gyp, which bundles a fork of GYP [1] is not very Guix-y at all, no. :/ This is one of those problems (like bootstrapping GCC) that will take years of incremental improvements and side projects and all that. [1] Not to get too off topic, but isn=E2=80=99t =E2=80=9Cgyp=E2=80=9D a slu= r? How did Google ever call something that? > It's on my TODO list to take another look at the patches as well :-), > then yes, I'm planning on rebasing my tree-sitter series on top. Excellent! >> Sorry if I missed something. I assume everything is OK, but I want to >> be sure before I start digging into the details of the patches =E2=80=93 >> especially those first few more complicated ones. :) > > Thanks for taking a look! I have an idea to simplify the patch series a bit: if we can answer my question here and come to a conclusion about deleting lock files , I could merge the =E2=80=98#:absent-dependencies=E2=80=99 part of the patch series. I think = this might make future re-rolls easier and help rein in the scope a bit. Thoughts? Philip? Thanks! -- Tim