From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2HxPH5ooA2JAKgEAgWs5BA (envelope-from ) for ; Wed, 09 Feb 2022 03:36:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WBn/G5ooA2KhxgAAauVa8A (envelope-from ) for ; Wed, 09 Feb 2022 03:36:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E6B2638473 for ; Wed, 9 Feb 2022 03:36:09 +0100 (CET) Received: from localhost ([::1]:49922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHcq0-0004s2-SH for larch@yhetil.org; Tue, 08 Feb 2022 21:36:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHcpI-0004rn-DX; Tue, 08 Feb 2022 21:35:24 -0500 Received: from [2607:f8b0:4864:20::72c] (port=34407 helo=mail-qk1-x72c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHcpF-0004fb-5d; Tue, 08 Feb 2022 21:35:23 -0500 Received: by mail-qk1-x72c.google.com with SMTP id bs32so623976qkb.1; Tue, 08 Feb 2022 18:35:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=pm9PL5a2/Jv8mvcaQTVhiK6PeusB0+BUWy+6nvb+jo0=; b=mXbaWspbKD/b1wtxgrGS2ng7wVg0mkuGDhakuV67kz7A4SzW2dY1leBP8J4Yjfd61q /2X3V9LnAMeFkCgHyeaX5PA/MmCOTCuv/0P7P3tYO1Iwjvjdo1AVS1CNhid9d73TdVF+ ObQOq69Qej9AejPJWLCQ/FWCBOzG6OLg1gPD7YV4/GB+waS0C9CmWVo75SMcXuIoVWBN o02BTq5HLV/r9VR1pYAC385xRyTZGEvmEwtw7Ji32FaQy5lojamJ6uqE4LICcYvRKwHC lcUvmD4fGLf6j86Zqug//yY61L/uSeuYOtnHTosXAYLEasgbsMNJZ5rEuQy1QesGxtMd 7L0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=pm9PL5a2/Jv8mvcaQTVhiK6PeusB0+BUWy+6nvb+jo0=; b=eu8EF7HgXgci6SlVucJ01eMsUkuqUiNeR+KBF02wBX13MPXsXVxp1Pf2mb56hSvDlK nGjPSwS3K6eoo9kRKE/zwJSsdwAvJUoU0Q2glFIY2QHmbJWGp56foopy78YXkhGNBHPA k97nozgjPbTn/FBZQH8Y34QJCai0KX6Z59x1l3uxkNAAYbwDMB7l/IA9zAcG6TAK/A5b MoBz649baVdhp/A+mrSdVKWeqsGIcFUq8K/DYZKhrNHoYs2inuviSkX4+FOhZ2Oa6UA9 itlengBk1S+JnbJ53OZ0ATP6/DWBspOM7eZkJ1CdJhTa2EL9Rp7yDiuNagDr6s6+ji7h 2mvA== X-Gm-Message-State: AOAM532lYX15Hlw+ICOPok/9a4t41/y3Sl4oPYqmEE9QGY+VVr4d+LSf yNszY0FB6PtDj2izmH8AiMK/CvN7ojVkOw== X-Google-Smtp-Source: ABdhPJz8HkQEqPQvTB0BEwlMDSnhnTC6JrGFple3ACl1Z0I2LOVf/WxuKkifVWMSy3hW1sDkJrt+PQ== X-Received: by 2002:a05:620a:201c:: with SMTP id c28mr95120qka.326.1644374118004; Tue, 08 Feb 2022 18:35:18 -0800 (PST) Received: from hurd (dsl-154-179.b2b2c.ca. [66.158.154.179]) by smtp.gmail.com with ESMTPSA id v22sm8267601qta.60.2022.02.08.18.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 18:35:17 -0800 (PST) From: Maxim Cournoyer To: Ricardo Wurmus Subject: Re: Dropping gzip-compressed substitutes References: <878rum1pph.fsf@gmail.com> <87tud9jxc6.fsf@gnu.org> <87wni5xplp.fsf@elephly.net> Date: Tue, 08 Feb 2022 21:35:16 -0500 In-Reply-To: <87wni5xplp.fsf@elephly.net> (Ricardo Wurmus's message of "Tue, 08 Feb 2022 17:53:47 +0100") Message-ID: <87ilto22e3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::72c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::72c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x72c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Mathieu Othacehe , guix-sysadmin Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644374170; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=pm9PL5a2/Jv8mvcaQTVhiK6PeusB0+BUWy+6nvb+jo0=; b=j2p+gfqwJIuFRPdeSx1r0Osv2vwSBBXeWK5mPtfueo3GXpw93dDlJWMLO6WNHOHj95gm0z KeZ+0UFskbnkuutw8BprC0PN9ycJICuKrvZSjxhrjTOzhIvjh1mtM80m7Ghn5uBkR7fE2+ oo2tmeVGhjjb8r/kZHv+VriIuklyE8X3BHHIHuODMz6GZu1XYIKGbV/WDkqZOpA6wk6yT4 aes6eoTVCKu9muO7b4vxDRBGKvRcsKp9iW2HXyhrLZSZ+zOgybvUIjihO/G+idl1fxF21U uojb8Rw/40qPL5njZrrE/nen5XfaoSUBQtqZWW7KsACM6Ct8sLXBQmS0tSprTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644374170; a=rsa-sha256; cv=none; b=bwP+NnIZM+dPQkT0EP0Ns6Tujl1JVj+7UYTHG5oDk0CYoYd6440nuNthlIrpUl9Zsn9ZvD fULltEM/nvcpO9qrx0zRbILpN/K9gk6h1pQKp28SGac2vBLkr2bjmPIriRpfKiwKV5Xcz7 i6V43nlYSxiiHvtgbU2rhbDHGcOsAlAdYPQaM+kGdToJRCyMLv5qqAwYqYMuQb11iS1N2w 5MEJhhOr49Gd+kk9RmUuo4ValJxCGThMlNQs48vfQ3TukQbTJoq5d2W8hCmsbk0qiLHqU0 k949rAfw5U9cSwCZRKFb9ct0FpE+UMbEHCH/xhiPQeVaOmq7n1D2ODA8Z/yIQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=mXbaWspb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=mXbaWspb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E6B2638473 X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: DDdSBEB6pOjg Hi Ricardo and Mathieu, Ricardo Wurmus writes: > Hi Mathieu, > > thanks for the patch! > >> From bd306a8b20f2033d67755dd332a5d33b2f6b822d Mon Sep 17 00:00:00 2001 >> From: Mathieu Othacehe >> Date: Tue, 8 Feb 2022 14:28:56 +0100 >> Subject: [PATCH 1/1] store: Warn about daemon deprecation. >> >> * guix/deprecation.scm (warn-about-old-daemon): New procedure. >> * guix/store.scm (build-things): Use it to warn about old daemons. >> --- >> guix/deprecation.scm | 7 +++++++ >> guix/store.scm | 2 ++ >> 2 files changed, 9 insertions(+) >> >> diff --git a/guix/deprecation.scm b/guix/deprecation.scm >> index c66c9367f6..666e178d75 100644 >> --- a/guix/deprecation.scm >> +++ b/guix/deprecation.scm >> @@ -1,5 +1,6 @@ >> ;;; GNU Guix --- Functional package management for GNU >> ;;; Copyright =C2=A9 2019, 2020, 2021 Ludovic Court=C3=A8s >> +;;; Copyright =C2=A9 2021 Mathieu Othacehe >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -24,6 +25,8 @@ (define-module (guix deprecation) >>=20=20 >> define-deprecated/public >> define-deprecated/alias >> + >> + warn-about-old-daemon >> warn-about-deprecation)) >>=20=20 >> ;;; Commentary: >> @@ -32,6 +35,10 @@ (define-module (guix deprecation) >> ;;; >> ;;; Code: >>=20=20 >> +(define (warn-about-old-daemon) >> + (warning (G_ "Your Guix daemon is seriously outdated, please consider >> + updating it by following the 'Upgrading Guix' documentation section.~%= "))) >> + > > s/documention section/section in the manual/ > > Should it also mention that staying with the old daemon means that > binaries will no longer be available? For example: > > Your Guix daemon is no longer supported and will soon no longer be > able to download binary substitutes. > > I realize that what you proposed is a generic warning, but perhaps it=E2= =80=99s > better to mention a direct consequence of failing to upgrade. (I know > many people who will not upgrade unless they absolutely have to.) Good idea; I modified it slightly like so: --8<---------------cut here---------------start------------->8--- @@ -36,8 +36,9 @@ (define-module (guix deprecation) ;;; Code: =20 (define (warn-about-old-daemon) - (warning (G_ "Your Guix daemon is seriously outdated, please consider - updating it by following the 'Upgrading Guix' documentation section.~%"))) + (warning (G_ "Your Guix daemon is severely outdated, and will soon cease= to +be able to download binary substitutes. To upgrade it, refer to the +'Upgrading Guix' section in the manual.~%"))) =20 (define* (warn-about-deprecation variable properties #:key replacement) --8<---------------cut here---------------end--------------->8--- =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20 >> --- a/guix/store.scm >> +++ b/guix/store.scm >> @@ -1442,6 +1442,8 @@ (define build-things >> things))) >> (parameterize ((current-store-protocol-version >> (store-connection-version store))) >> + (when (< (current-store-protocol-version) 355) ;0x163 >> + (warn-about-old-daemon)) >> (if (>=3D (store-connection-minor-version store) 15) >> (build store things mode) >> (if (=3D mode (build-mode normal)) > > Maybe add a comment here to explain why this particular protocol version > is considered old. I added the following: --8<---------------cut here---------------start------------->8--- @@ -1442,7 +1442,11 @@ (define build-things things))) (parameterize ((current-store-protocol-version (store-connection-version store))) - (when (< (current-store-protocol-version) 355) ;0x163 + (when (< (current-store-protocol-version) #x163) + ;; This corresponds to the first version bump of the daemon + ;; since the introduction of lzip compression support. The + ;; version change happened with commit 6ef61cc4c30 on the + ;; 2018/10/15). (warn-about-old-daemon)) (if (>=3D (store-connection-minor-version store) 15) (build store things mode) --8<---------------cut here---------------end--------------->8--- And pushed with commit 96d7535b03. Thanks for the feedback! Maxim