From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +BefKJwobWJNVwAAbAwnHQ (envelope-from ) for ; Sat, 30 Apr 2022 14:16:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aJz7J5wobWIvnwAAG6o9tA (envelope-from ) for ; Sat, 30 Apr 2022 14:16:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29ADD2CA05 for ; Sat, 30 Apr 2022 14:16:28 +0200 (CEST) Received: from localhost ([::1]:37056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkm1S-00039C-TX for larch@yhetil.org; Sat, 30 Apr 2022 08:16:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkm1B-000389-59 for bug-guix@gnu.org; Sat, 30 Apr 2022 08:16:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkm14-0002pB-8s for bug-guix@gnu.org; Sat, 30 Apr 2022 08:16:08 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nkm14-0007sh-5K for bug-guix@gnu.org; Sat, 30 Apr 2022 08:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#54723: [PATCH] Check URI when verifying narinfo validity. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 30 Apr 2022 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54723 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 54723-submit@debbugs.gnu.org id=B54723.165132094330256 (code B ref 54723); Sat, 30 Apr 2022 12:16:02 +0000 Received: (at 54723) by debbugs.gnu.org; 30 Apr 2022 12:15:43 +0000 Received: from localhost ([127.0.0.1]:56053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkm0l-0007rw-6A for submit@debbugs.gnu.org; Sat, 30 Apr 2022 08:15:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkm0j-0007rc-4q for 54723@debbugs.gnu.org; Sat, 30 Apr 2022 08:15:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkm0d-0002mI-KQ; Sat, 30 Apr 2022 08:15:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=9QOtkk72dT+EGMihfFSagbCMd3qXPdU5JsNimlKk9TY=; b=Fy22OzTJCeemIaYKbyeW s6YOA2+4DydK1PyRzjoqdJwOOG5+xUMgoZYf4YoCZakHLyzdM6tyva34O4ZYvAfoIdSG+W67OejjL yLfcfxrT/1bcvtV7l8pBkkC+HyRYvlSntozElPQ2Cam96me5cgrnDqOjuu0NxJ5ANkbyeCX0I9bht 7TrWEcnjTt/t35RzaW/h84Ev/AYPMkjGlsDS04XREdW+8t8C93tXawNmIfWuOH7lDlVmUiWDuCR01 74VTRX+6Ui28j6Jwn3EoQEMqiEKUytWarIGmPOVjpLiSS9evd6ZAkPVf+lkXQ0aPW87O4M6iNCadX SFbnyHcOuVnQVA==; Received: from 71.125.192.77.rev.sfr.net ([77.192.125.71]:37452 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkm0c-0000Op-R1; Sat, 30 Apr 2022 08:15:35 -0400 From: Mathieu Othacehe References: <87a6czbzvh.fsf@kitej> <877d83lapv.fsf@gnu.org> <875ynnbe65.fsf@kitej> <87pmlq6lqx.fsf_-_@gnu.org> <877d7ydjwk.fsf@kitej> <87wnfv90cl.fsf@kitej> <871qy2g2v3.fsf@gnu.org> <87o816wt36.fsf@kitej> <87sfqfc0fq.fsf@kitej> <87bkwyxjtp.fsf@gnu.org> <87v8v3ddz5.fsf@kitej> <87y1zn6ev5.fsf_-_@gnu.org> Date: Sat, 30 Apr 2022 14:15:31 +0200 In-Reply-To: <87y1zn6ev5.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 29 Apr 2022 18:20:14 +0200") Message-ID: <87ilqqwyvw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 54723@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651320988; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9QOtkk72dT+EGMihfFSagbCMd3qXPdU5JsNimlKk9TY=; b=TyNPmxfVLkHuj6f3Vnudbh/4iL27MCqxbQJh0xu0DuLaDIWjoV6/PrHR/oUJp7ZtQA9qiT wzO2MDVbbSofJfWChPxz5OCEdmAsN6TjQZEqQQratnmidiaol5+j4ub8MLaqahFzAxdBNj y9rU/r1uzw74hlsfgmtjHBqA2fDJcHHGjVfYrI3rIPqcMrc2bPqCGz+7278VkbwNrjUha7 ye5b97P6ZxDNzLeCW2TH5ZzgdpNIkX5QYY7NuRqQyOxokVpPaSRiRddVgEep9THbL/4WId NRCUwLNRLxso2yf1LPq/MEEmihzx3mVPljbV+njEeGKJetG5FJ2FwHHTgAILBw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651320988; a=rsa-sha256; cv=none; b=UGMLlHfhURfAc3iRkQhmWpCzd4k6jRNpfNhMsDiW62q1/P7wRsCiWA10ZKuMlV0DYNq6C2 OLs0twrX7XThymd2xf46l747zG2FFi3IWwDAijsB4QJCiOMfFOId5h5PWOeJrEROG8dQV3 WkiFZhkw/Q4htpy6Jhn8YJA2P/9koqfN5zyUP2zSe25nFMsO5my8aD4s8OY9+wyxRVkj5g gTp1ccOQsHAepmr9USama/H+Q2CjCYN7M32d0mznmgXpNsZ+SmaFPuUStEBXQugrMQIJCR A78uqTS+xCMoZx3VuAetlrbODE2q0IOEVTEHbfgfmHb8Nu4tpDDDoAtZbzBiYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Fy22OzTJ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Fy22OzTJ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 29ADD2CA05 X-Spam-Score: -2.40 X-Migadu-Scanner: scn1.migadu.com X-TUID: vs/8Ka3hAb0t Hey Ludo, > Now, the only way =E2=80=98narinfo-string=E2=80=99 can take too long thes= e days is (I > think) if the store GC lock is held (we should check that hypothesis, > but I believe that if the GC lock is held, then the =E2=80=98query-path-i= nfo=E2=80=99 > RPC made from =E2=80=98narinfo-string=E2=80=99 might block until the lock= is released). > The GC lock is no longer held for hours on berlin, so there=E2=80=99s less > pressure to address that. Thanks for having a look to that issue. On my side, I'd like to take some time to look closely at the situation. > To summarize: I think =E2=80=98guix publish=E2=80=99 is okay as-is but we= should > fiberize it sometime. I think however that it would be nice to create a wip branch for those changes, deploy it and monitor it closely on Berlin before pushing. From experience, the publish code is really fragile and the I/O pressure on Berlin can exhibit a lot of unexpected issues. Mathieu