bug#58417: Installer script no longer works with `yes` utility

bug#58417: Installer script no longer works with `yes` utility

[Jonas Freimuth]

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

Package: guix

Version: 1.4.0

Severity: important

Heyo,

I use the github `guix-install-action` 
(https://github.com/PromyLOPh/guix-install-action), which internally 
runs the `guix-install.sh` script non-interactively, via the yes utility:

```{bash}

bash -c 'yes | bash guix-install.sh'

```

However, since commit `6a2e303d3a49baf7c222a70b91f453e9efd456c6` 
(https://git.savannah.gnu.org/cgit/guix.git/commit/etc/guix-install.sh?id=6a2e303d3a49baf7c222a70b91f453e9efd456c6), 
this apparently causes the entire action to hang (leading to eventual 
termination by github).

I confirmed this behaviour by running the "Download", "Fetch Key", and 
"Install Guix" steps of the `guix-install-action` as root on a WSL2 
instance of Ubuntu20.04 (using todays wsl rootfs from 
https://cloud-images.ubuntu.com/focal/current/).

Running

```{bash}

sudo --preserve-env=GUIX_BINARY_FILE_NAME -- bash -c 'bash guix-install.sh'

```

instead of

```{bash}

sudo --preserve-env=GUIX_BINARY_FILE_NAME -- bash -c 'yes | bash 
guix-install.sh'

```

i.e. running the script interactively works fine.

Is this intended, or is there another suggested way to run the 
`guix-install.sh` script non-interactively?

Best wishes,

Jonas

[-- Attachment #2: Type: text/html, Size: 2258 bytes --]

bug#58417: Installer script no longer works with `yes` utility

[Maxim Cournoyer]

Hi,

Jonas Freimuth <jonas.freimuth@posteo.de> writes:

> Package: guix
>
> Version: 1.4.0
>
> Severity: important
>
> Heyo,
>
> I use the github `guix-install-action`
> (https://github.com/PromyLOPh/guix-install-action), which internally
> runs the `guix-install.sh` script non-interactively, via the yes
> utility:
>
> ```{bash}
>
> bash -c 'yes | bash guix-install.sh'

This should be fixed with e46bb5fd5a.  Please report back if it there
are still issues.

Thanks for reporting the issue, and apologies for the breakage!

-- 
Maxim

Re: bug#58417: Installer script no longer works with `yes` utility

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

[Shunted to guix-devel@]

Jonas Freimuth 写道：
> bash -c 'yes | bash guix-install.sh'

While this happens to work (again) now, that doesn't mean it 
always will or should be considered supported.

We should reserve the right to ask future questions to which the 
safe/sane/common answer is ‘no’, without phrasing it awkwardly 
just to make an unthinking stream of ‘y’s happy.

  $ guix-install.sh
  …
  Would you like to NOT enable the Cool Experimental Feature? 
  (DANGER) [Y/n]

Conversely, I'd like to add a comment that does commit to always 
keeping ‘yes '' | bash guix-install.sh’ working, assuming there 
was no other input or detected issues.  Also nice for humans in a 
hurry.

Does that seem unreasonable to anyone?

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

Re: bug#58417: Installer script no longer works with `yes` utility

[zimoun]

Hi Tobias,

On Tue, 11 Oct 2022 at 18:26, Tobias Geerinckx-Rice <me@tobias.gr> wrote:
> Jonas Freimuth 写道：

>> bash -c 'yes | bash guix-install.sh'
>
> While this happens to work (again) now, that doesn't mean it 
> always will or should be considered supported.
>
> We should reserve the right to ask future questions to which the 
> safe/sane/common answer is ‘no’, without phrasing it awkwardly 
> just to make an unthinking stream of ‘y’s happy.
>
>   $ guix-install.sh
>   …
>   Would you like to NOT enable the Cool Experimental Feature? 
>   (DANGER) [Y/n]

Personally, I am always confused by the negative form of a question. :-)


> Conversely, I'd like to add a comment that does commit to always 
> keeping ‘yes '' | bash guix-install.sh’ working, assuming there 
> was no other input or detected issues.  Also nice for humans in a 
> hurry.
>
> Does that seem unreasonable to anyone?

From my point of view, it could nice to have a way to run the
installation script without any human action.  For instance, install
Guix in some GitHub/Gitlab CI.


Cheers,
simon

Re: bug#58417: Installer script no longer works with `yes` utility

[Maxim Cournoyer]

Hi Simon,

zimoun <zimon.toutoune@gmail.com> writes:

[...]

>> Conversely, I'd like to add a comment that does commit to always 
>> keeping ‘yes '' | bash guix-install.sh’ working, assuming there 
>> was no other input or detected issues.  Also nice for humans in a 
>> hurry.
>>
>> Does that seem unreasonable to anyone?
>
> From my point of view, it could nice to have a way to run the
> installation script without any human action.  For instance, install
> Guix in some GitHub/Gitlab CI.

If I understood Tobias, they were not suggesting to make the
non-interactive installation use case harder/impossible, just to change
it from 'yes | ./install.sh' to 'yes "" | ./install.sh', which would
give us the freedom to choose a default value of either yes or no for
each question.

Hope that helps!

-- 
Thanks,
Maxim

Re: bug#58417: Installer script no longer works with `yes` utility

[zimoun]

Hi Maxim,

On dim., 16 oct. 2022 at 21:22, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> If I understood Tobias, they were not suggesting to make the
> non-interactive installation use case harder/impossible, just to change
> it from 'yes | ./install.sh' to 'yes "" | ./install.sh', which would
> give us the freedom to choose a default value of either yes or no for
> each question.

Thanks for explaining.

IIUC, is the point to have 'default | ./install.sh'?


Cheers,
simon

Re: bug#58417: Installer script no longer works with `yes` utility

[Maxim Cournoyer]

Hi,

zimoun <zimon.toutoune@gmail.com> writes:

> Hi Maxim,
>
> On dim., 16 oct. 2022 at 21:22, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> If I understood Tobias, they were not suggesting to make the
>> non-interactive installation use case harder/impossible, just to change
>> it from 'yes | ./install.sh' to 'yes "" | ./install.sh', which would
>> give us the freedom to choose a default value of either yes or no for
>> each question.
>
> Thanks for explaining.
>
> IIUC, is the point to have 'default | ./install.sh'?

What do you mean by 'default | ./install.sh' ?  I think Tobias' point
was to have the ability for a newline (RET) to mean either YES or NO,
compared to the current case where it always mean YES.  "yes ''" does
this: enter nothing then RET, repeatedly.

-- 
Thanks,
Maxim

Re: bug#58417: Installer script no longer works with `yes` utility

[zimoun]

Hi,

On Mon, 17 Oct 2022 at 17:22, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:

> What do you mean by 'default | ./install.sh' ?

Nothing relevant. :-)

>                                                 I think Tobias' point
> was to have the ability for a newline (RET) to mean either YES or NO,
> compared to the current case where it always mean YES.  "yes ''" does
> this: enter nothing then RET, repeatedly.

Ah, yes.  For sure.   Sorry for the noise.


Cheers,
simon

Re: bug#58417: Installer script no longer works with `yes` utility

[Maxim Cournoyer]

Hi,

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> [Shunted to guix-devel@]
>
> Jonas Freimuth 写道：
>> bash -c 'yes | bash guix-install.sh'
>
> While this happens to work (again) now, that doesn't mean it always
> will or should be considered supported.
>
> We should reserve the right to ask future questions to which the
> safe/sane/common answer is ‘no’, without phrasing it awkwardly just to
> make an unthinking stream of ‘y’s happy.
>
>  $ guix-install.sh
>  …
>  Would you like to NOT enable the Cool Experimental Feature?
>  (DANGER) [Y/n]
>
> Conversely, I'd like to add a comment that does commit to always
> keeping ‘yes '' | bash guix-install.sh’ working, assuming there was no
> other input or detected issues.  Also nice for humans in a hurry.
>
> Does that seem unreasonable to anyone?

To the contrary, that seems pretty reasonable.  You may be interested in
this version of a biased prompt, gracefully shared by Earnestly from
#bash:

--8<---------------cut here---------------start------------->8---
confirm() {
    local -l reply
    local prompt bias=$1
    shift

    case $bias in
        yes) prompt=Y/n ;;
        no)  prompt=y/N
    esac

    # shellcheck disable=SC2059
    printf -- "\033[1m* $1 [$prompt]\033[0m " "${@:2}"
    read -r reply

    case $bias in
        yes) [[ $reply = y || ! $reply ]] ;;
        no)  [[ $reply = y ]]
    esac
}
--8<---------------cut here---------------end--------------->8---

The first arguments is the default argument (yes or no).  The rest works
the same (but they used printf to format things).  We can adapt our
version with that.

If you make the change you'll want to write a news so that 'yes' users
can transition to "yes ''".

-- 
Thanks,
Maxim

Re: bug#58417: Installer script no longer works with `yes` utility

[Maxim Cournoyer]

Hi again,

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> [Shunted to guix-devel@]
>
> Jonas Freimuth 写道：
>> bash -c 'yes | bash guix-install.sh'
>
> While this happens to work (again) now, that doesn't mean it always
> will or should be considered supported.
>
> We should reserve the right to ask future questions to which the
> safe/sane/common answer is ‘no’, without phrasing it awkwardly just to
> make an unthinking stream of ‘y’s happy.
>
>  $ guix-install.sh
>  …
>  Would you like to NOT enable the Cool Experimental Feature?
>  (DANGER) [Y/n]
>
> Conversely, I'd like to add a comment that does commit to always
> keeping ‘yes '' | bash guix-install.sh’ working, assuming there was no
> other input or detected issues.  Also nice for humans in a hurry.
>
> Does that seem unreasonable to anyone?

I forgot to add: I think we should only introduce such a change if/when
the need occurs.  We may never need it, and having a 'yes' only bias
forces us to offer only quality additions that we think users ought to
want enabled ;-).

-- 
Thanks,
Maxim