From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uOACGQf+tGNMZgEAbAwnHQ (envelope-from ) for ; Wed, 04 Jan 2023 05:18:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id u/DrGAf+tGP7AwEAauVa8A (envelope-from ) for ; Wed, 04 Jan 2023 05:18:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E92C53D9A6 for ; Wed, 4 Jan 2023 05:18:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCvE6-0005KB-Vh; Tue, 03 Jan 2023 23:18:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCvE3-0005Jq-NC for guix-patches@gnu.org; Tue, 03 Jan 2023 23:18:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCvE2-0005oR-Pq for guix-patches@gnu.org; Tue, 03 Jan 2023 23:18:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCvE2-0007Dr-BE for guix-patches@gnu.org; Tue, 03 Jan 2023 23:18:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59761] [PATCH 0/2] Add u-boot-ts7970-q-2g-1000mhz-c. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Jan 2023 04:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59761 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 59761@debbugs.gnu.org Received: via spool by 59761-submit@debbugs.gnu.org id=B59761.167280583327705 (code B ref 59761); Wed, 04 Jan 2023 04:18:02 +0000 Received: (at 59761) by debbugs.gnu.org; 4 Jan 2023 04:17:13 +0000 Received: from localhost ([127.0.0.1]:47257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCvDE-0007Cm-QA for submit@debbugs.gnu.org; Tue, 03 Jan 2023 23:17:13 -0500 Received: from mail-qt1-f177.google.com ([209.85.160.177]:46879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCvDA-0007CX-A0 for 59761@debbugs.gnu.org; Tue, 03 Jan 2023 23:17:12 -0500 Received: by mail-qt1-f177.google.com with SMTP id x11so26386960qtv.13 for <59761@debbugs.gnu.org>; Tue, 03 Jan 2023 20:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=V0d6m04ZyCXn1QBu2pxzD/7MkoZHkdVnyByS5RLj+/E=; b=DLjXjuV7sIfqUF+GQrGTU2w3zfnyBaKnhL8XEIzRr6vB0RvJ36tPpy5GCEirMriatk vNg9CSUMdhD2SovXTkBnOw0sZ4VrbkOSfsXSmmD9W9wZu17EnikRFpsN0k/IKF0z4F/D 02zoRVGHEphljI5T/d0DcnGMn+HAHmdNgCRF8mtg8s+I7Ps+1HbF1jGGAHYLbLAlF7ou ry/6S50DVHm0yLBEdvizNj7c44rElanfW8Ri9sHW79ecUfcy44yJWxCOTpGEg2OI7aKn E4/bclVp+HycsYp2fmwFG6MvraVbmAHrydyOdjppmBQK5IvHbOGwD+fi3qh8gH+7cVzB MnOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=V0d6m04ZyCXn1QBu2pxzD/7MkoZHkdVnyByS5RLj+/E=; b=Ad0rhEeu80WKPVJhDIC11UJq5K6wdi0yeeW1w1zh+X7TpLhxlNVcj8H57zHfMjCgkP ewqacUnrvSW+KQfKkMyP9XED08y2zu7pQJXOGcAzpY0QNvkamtcTnqdGQUZqfckpdjM7 mvGMJmBVG0HiQ/2+tFOiqDbIes/V/PGqCWv383uCbiIQME0R9WSTsI+b/NQ0ag8K9AqY 2INnHNlFwoNjq7oEH1OcwTxdX7qMI0bTH+X4W0yRsdrVmC3DuAmvEHIk3+X1MhHVPjb2 aiVXw7sWkslsjKS8GS46cqAW2h/L+jhkbdz1DyC/TP3g2D9m4u0JqWxCaAEzQWx5dgio 1zOg== X-Gm-Message-State: AFqh2koD0IbwHzYgI6kZsb6sRfbM//v/nFxg7gCMC9l5hoJCLYKmOw4N ZfrVPmkKDPVl3Kt8X4fdtuCAjSglr8NtQv2r X-Google-Smtp-Source: AMrXdXuE6yFHjQbGq+dnOvGMcR85SGZUBXlFwIPseVHOyH8ze27XCNbnscI0pGf+UP+m0QdpTvCouw== X-Received: by 2002:ac8:1287:0:b0:3a8:23d4:8d2b with SMTP id y7-20020ac81287000000b003a823d48d2bmr63405444qti.10.1672805822506; Tue, 03 Jan 2023 20:17:02 -0800 (PST) Received: from hurd (dsl-10-135-221.b2b2c.ca. [72.10.135.221]) by smtp.gmail.com with ESMTPSA id i17-20020a05620a405100b006fcb77f3bd6sm23930615qko.98.2023.01.03.20.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 20:17:02 -0800 (PST) From: Maxim Cournoyer References: <20221202052903.10475-1-maxim.cournoyer@gmail.com> <871qoi9f0b.fsf@elephly.net> Date: Tue, 03 Jan 2023 23:17:00 -0500 In-Reply-To: <871qoi9f0b.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 29 Dec 2022 20:33:16 +0100") Message-ID: <87ilhnvsqr.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672805895; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=V0d6m04ZyCXn1QBu2pxzD/7MkoZHkdVnyByS5RLj+/E=; b=A4quSqCYTVccAFGe9NlFrOD4H3r73raJ3hP9+/JPb4jt2LiEuyDjh+WLE0H7+RGeqf3dvF eoT6tjpP7ZVxyGMYD1bheehwOUYLr00iUzz7i8Vc4asIcOERkxdSl6t5196+OyJ7bIKFhV o3UIPH/DSVg4tkNKX4hsw50nIXtyH8E7EgPR7MReXB2m/3R5BkJ5KVLKOIx0le9/hArqob K7hV398LfmHB4dRXBfoaxQrHmMN+O8LKFiokPnkrI3wLFPXF/BIQhBvzgqK9VtXqtAY1qI Ka4B/HqBzWq8ACQg03L5lE87MRuMDHZFgNlYWHwTHVGmJkgUqgr3ki3uTaYpsQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=DLjXjuV7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672805895; a=rsa-sha256; cv=none; b=Ii/MSLhNbr/Fn604AWkO5wlOy942KDXISNOFeKO5KH1YbO6pArmEcjZZt9Vy3j+04rOapi fob6uDxc23efkEtqHZ09t50kkEu6Yq3m0ifZYzfyA7NEdMz0hFlrd+99l/UDphE42edW7O 1G6cI5HB1kwQDvHCHw1XEJpua/PIPT12LcwIs1/bp56QYSzEChGfHIunvACXXxlG6j1tQZ +r0fqISQ2TqRXYS8GDvROPYn+yNDdMlGmy9c4hfP5++5Gi4Kas1zm0OsCsMHC9pKtRb13O Xu5BWVP+2UUiegd5iHk1IEtCFauqdsXsTBae7rpsaH80K31Qrmi+1R2pafAZBg== X-Spam: Yes X-Migadu-Queue-Id: E92C53D9A6 X-Migadu-Spam: Yes X-Spam-Score: 7.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=DLjXjuV7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: 7.44 X-TUID: n3PnoVhDpCKH Hi Ricardo, Ricardo Wurmus writes: > Hi Maxim, > > there seems to be some overlap between this and > https://issues.guix.gnu.org/60224. Yes, I ended up splitting my changes focusing on u-boot in #60224, which should be reviewed before and blocking this change here, which is based on it. > Looking just at v4 I only have one > comment. > > In your substitute* replacements it=E2=80=99s better not to use string-ap= pend. Oh? Why is this so? There must be hundreds of string-append occurences used in such place, so I'm curious. > You can include real line breaks in a string and escape line breaks with > \. This is preferable to gluing strings together. OK, I guess this is your rationale for the above comment (cleaner). > For something as > long as the replacements in this package consider using a patch file > instead. This has the added advantage of failing the build when the > patch cannot be applied cleanly. I agree that a patch would be most suitable here, especially that if something breaks, if would likely be silent (unlikely to be caught at build time). I'll extract this as a patch. > The rest looks good to me. OK. I'll await your comments on #60224, which is awaiting feedback post-rework based on your earlier feedback. PS: I had also missed that email; please keep me in CC in all your replies :-). --=20 Thanks, Maxim