From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0HNHBlf2L2SoVgAASxT56A (envelope-from ) for ; Fri, 07 Apr 2023 12:54:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eM5jBVf2L2RLiQAAG6o9tA (envelope-from ) for ; Fri, 07 Apr 2023 12:54:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B77DE2FA8A for ; Fri, 7 Apr 2023 12:54:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkjjH-0001AJ-RO; Fri, 07 Apr 2023 06:54:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkjjG-00019u-QE for guix-patches@gnu.org; Fri, 07 Apr 2023 06:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkjjG-0008Tk-IA for guix-patches@gnu.org; Fri, 07 Apr 2023 06:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkjjG-0000Ll-FC for guix-patches@gnu.org; Fri, 07 Apr 2023 06:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62684] [PATCH] gnu: Zstandard: Update to 1.5.5. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Apr 2023 10:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62684 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari , 62684@debbugs.gnu.org Received: via spool by 62684-submit@debbugs.gnu.org id=B62684.16808648041279 (code B ref 62684); Fri, 07 Apr 2023 10:54:02 +0000 Received: (at 62684) by debbugs.gnu.org; 7 Apr 2023 10:53:24 +0000 Received: from localhost ([127.0.0.1]:55767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkjid-0000KZ-IE for submit@debbugs.gnu.org; Fri, 07 Apr 2023 06:53:23 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:40086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkjic-0000KL-K4 for 62684@debbugs.gnu.org; Fri, 07 Apr 2023 06:53:23 -0400 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-2ef2d5c92f5so141347f8f.0 for <62684@debbugs.gnu.org>; Fri, 07 Apr 2023 03:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680864797; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=WotbHz2K8w0OTqnqNVM0aPRVn1E1k+0sLhfSsbah3sc=; b=Wx4SvjLsrbvx/o4hfjZrxVp8bUO3TIGaqjKd3IsDv/BQEcdr5e2hgpW2Ws822HqocE k60DYGXepCTMM9PsJ1HsQVAd0kcsfzalnaHI2MV3Bk1w+WdA6BwTCTpDP/VaWa1ha8F0 jUIty/eTPrxsGqDvl7XhJlyhwB9LVDv9Caf01PFTo2FydK8OL3Ql496senoPQG4ZG5KB FERbgBy+VJFBPsSBEg+Z7NhnmZbIVcrSI42/5XicO0qAAB5MtBWA2Q4B/zYIXqmM98M1 eZkHmbScoMX8sUBUDasZBE6g3+rkjBkhNHCuJPWkXhAUjFD+gl1f1dsI2Ubu9LmVO6jX CUfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680864797; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WotbHz2K8w0OTqnqNVM0aPRVn1E1k+0sLhfSsbah3sc=; b=TkQFwQoKu++QcJAMejjy1J4tUTaEAH6esjLPw70QCAEkYMovq7sfF6FJ02QYwgcPfk hFGDgVB3w9t1ZQwaxp/ulvH6Vzu70GIs1kgKcA5qHx7oMHKauRVMzvCL/FTzOq3FL3pW inWwtgcB55/gcOn+9i9Y+IabRZ62MztuB/sDSmXNrSVbNUiRBM3GPJ/PUuwPfoatGyLR efBUvRjzOLiLm7JfOHbP1wwL1nODyJ7gN8Xk6gn66WhPSutclcVJ5JXUcQdN25t1sKD4 M8uXyMZkGQx9/BaL5zUwceE29wd+Wi4xNuT487K8Lj9MLIaDG0lQ629T17ClC+reVF3n uNbw== X-Gm-Message-State: AAQBX9eB9DFDQq9PKtNc5YpyqNZuyDgOtXSgiWokVrCRcUqsVbI+sLKa +q9K6lLIiKlBT4sDtlxo9kJRouVj85k= X-Google-Smtp-Source: AKy350a9aUimofhJYKb57Y1FRq8e7+6aGPoSS1LNKINg4MaBH/lxNNnLZgDwAQwvZYwhhRylrpFewQ== X-Received: by 2002:adf:dccf:0:b0:2ef:5b62:7873 with SMTP id x15-20020adfdccf000000b002ef5b627873mr789508wrm.4.1680864796744; Fri, 07 Apr 2023 03:53:16 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id f4-20020a7bcd04000000b003ed1f6878a5sm4313549wmj.5.2023.04.07.03.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 03:53:16 -0700 (PDT) From: Simon Tournier In-Reply-To: <8d9ae0fcc8215c2e7aa0514c814ee8b0966db2e1.1680722796.git.leo@famulari.name> References: <8d9ae0fcc8215c2e7aa0514c814ee8b0966db2e1.1680722796.git.leo@famulari.name> Date: Fri, 07 Apr 2023 12:52:40 +0200 Message-ID: <87ile8klqf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680864854; a=rsa-sha256; cv=none; b=E85BJaV/CUrSoZ3h32ZiCpDzyUNG26oAyW+He2oXfq2eWe8scpZSSpTjtQBGTE2yiqVJkf n2izfa6lUMjtfkPqM2HdF8bgq61YQmlAnqxRbx3bfCWtRUQF9CXFyEVKpTcNCLQgTV+R0X LgDVXF3uvv9ZnXrbnd0WN3REBaJmacDy0gezUd+4RhZoSqApk3SfhgsTQSwwqvyYzHcOzL 9UUe+igjrAGp23jr/LXpwnuk5jVFV0c9OmMFgI69i1gc1DlmOM6oD0xE1nscnxSyjOjztu vzGHjGkNjI5DwnC9C+8GQ/zoWP5q2KzRJ1tZEK/+R6uOtBLYTpZxiZe6sksVdw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Wx4SvjLs; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680864854; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=WotbHz2K8w0OTqnqNVM0aPRVn1E1k+0sLhfSsbah3sc=; b=INVzg1iuE7IZjBdLZjJUhAlzYsNpwaQDBLost/vHZUCj8kcyJXBAmSxTM5JR+cobvCMxiZ uDqTcEXs8Nw9Qr3DbxrncFUwQMM7knv12vNacihmHQs1n/BJn03svlRkTfIYaWOnHqmorU 7v7wsu6WFPO/hrhp6gY/Re3zCRXU4mMdZOhYdjn7meDuuaK8fyXhzK1ncdS2NhOYNqLU6S Gkq9LykBW7u3ihcz5rIxoQ4RSrybWG0wfClNSqsvHZiq9YiPFcRhJhTJnrD3nTU8xlmofw 6E68Q31q9yl7JHMTk5onqC7kOV9oUZv69fdZmbOc+OKwHQlOS5X5dZ/vTr2VYA== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Wx4SvjLs; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -1.42 X-Spam-Score: -1.42 X-Migadu-Queue-Id: B77DE2FA8A X-TUID: YmmUa+Y7RK6L Hi Leo, On mer., 05 avril 2023 at 15:26, Leo Famulari wrote: > + (replacement zstd-1.5.5) > (version "1.5.0") [...] > +(define-public zstd-1.5.5 > + (package > + (inherit zstd) > + (version "1.5.5") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/facebook/zstd/releases/download/" > + "v" version "/zstd-" version ".tar.gz")) > + (sha256 > + (base32 "1r1ydmj7ib3g5372yj3k40vl3b9ax0154qg2lqcy7ylwhb69chww")))))) I am always confused by the implication of such change. --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix show zstd | recsel -p name,version name: zstd version: 1.5.5 name: zstd version: 1.5.0 $ ./pre-inst-env guix build zstd@1.5.0 /gnu/store/g8cl62bmsdsqn14yxghdl882zn0ls8n9-zstd-1.5.5-lib /gnu/store/b980xf8i6qmx7iaih1bfnqvaihg37p3b-zstd-1.5.5 /gnu/store/6iysnbm6rb9hm61f7jsqgiry5l9v9yca-zstd-1.5.5-static $ ./pre-inst-env guix build zstd@1.5.0 --no-grafts /gnu/store/3x3dl71d4xm6y4hjwq110hmfyfx0xc6j-zstd-1.5.0-lib /gnu/store/bn6pk5zjjdpdfzb6yfr5psi9pji9w51n-zstd-1.5.0 /gnu/store/wa5pngf2lywgi8vd8k9b1k13wp2acvi4-zstd-1.5.0-static --8<---------------cut here---------------end--------------->8--- Well, maybe something like: --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index 8a78fee107..5841ea0cf0 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -1637,6 +1637,7 @@ (define-public zstd (name "zstd") (replacement zstd-1.5.5) (version "1.5.0") + (properties `((hidden? . #true))) (source (origin (method url-fetch) @@ -1726,6 +1727,7 @@ (define-public zstd-1.5.5 (package (inherit zstd) (version "1.5.5") + (properties '()) (source (origin (method url-fetch) --8<---------------cut here---------------end--------------->8--- would be less confusing. Note this discussion [1] about similar examples. And this patch [2] as an attempt to address the UX issue. 1: https://yhetil.org/guix/86czvohn86.fsf@gmail.com/ 2: https://yhetil.org/guix/86im5a6ea4.fsf@gmail.com Cheers, simon