From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cLkSNxLmMWRSeQEASxT56A (envelope-from ) for ; Sun, 09 Apr 2023 00:09:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AFz6NRLmMWRXDwEAG6o9tA (envelope-from ) for ; Sun, 09 Apr 2023 00:09:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 63B5E35951 for ; Sun, 9 Apr 2023 00:09:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plGk7-0003Sh-1e; Sat, 08 Apr 2023 18:09:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plGk3-0003SU-EN for guix-patches@gnu.org; Sat, 08 Apr 2023 18:09:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plGk3-0005Bv-01 for guix-patches@gnu.org; Sat, 08 Apr 2023 18:09:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plGk2-0000pM-H7 for guix-patches@gnu.org; Sat, 08 Apr 2023 18:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62202] [PATCH 0/21] Juliahub import script. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 08 Apr 2023 22:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62202 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: 62202@debbugs.gnu.org Received: via spool by 62202-submit@debbugs.gnu.org id=B62202.16809916843102 (code B ref 62202); Sat, 08 Apr 2023 22:09:02 +0000 Received: (at 62202) by debbugs.gnu.org; 8 Apr 2023 22:08:04 +0000 Received: from localhost ([127.0.0.1]:59773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plGj5-0000nx-Qz for submit@debbugs.gnu.org; Sat, 08 Apr 2023 18:08:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plGj3-0000nU-LN for 62202@debbugs.gnu.org; Sat, 08 Apr 2023 18:08:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plGiv-0004xt-RO; Sat, 08 Apr 2023 18:07:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=TajsiM4QO16mND9oKQAKLa6N77xN8GXdGT/ZdjmuUJc=; b=d5oe4ax+cwVdThRubfwg LrWJae9Y9wbR7FMfkoyMINceshDYIVf4LDgs8ReQYuQSz0+dJV48u1hUMdSpoVjYCyDL40QdcmMBA m6cnGgroYSm40+SOQQl6xmDrxmS9xKApJUkTzjctiQeL4ZXg9uk3FR5O1n/Cr95qDpzi2+DBEwFqj jFZQJH8Z92xfx0RUeLSVs+byRwPrp+brfnKOwIMRAvBXREnZVKy7/AS0R6xFVCwPMleqa0Ud5NoTh TYUSJi3NwwwLKbtrExwPMr43VgZAHUm+YiFAd9/+TxMPQWPfQUwO0cMj9I3HE0RVASS8x1isypQzt Vn6ISEfMPJAHdw==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plGiv-0008Cu-7w; Sat, 08 Apr 2023 18:07:53 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871qlq89kz.fsf@ngraves.fr> Date: Sun, 09 Apr 2023 00:07:50 +0200 In-Reply-To: <871qlq89kz.fsf@ngraves.fr> (Nicolas Graves's message of "Wed, 15 Mar 2023 13:47:56 +0100") Message-ID: <87ile69geh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680991762; a=rsa-sha256; cv=none; b=W/BIomb1Hd/mJhNXQ2DT/0nyuWjHfh6+LlL8VrjkrcTUACEXSZPgIvlzFjJJcGbFscJfQO piOOZ65unSmrggBLCmoE08wDuWyShtnmd6WuSQncW31dxiauxMknWmX0FjUzFFJ9mNOrS7 zTNSB+iR61AfVtK2SO7WbLsNVj7fjRzIeUbyWWLSMMwOK+QmbMA5eviSw0o8m6UCXA3rn2 Gh9B3k4AQRw1sxzHOeWIC89664ITnCO46taOuS9q8Yntw6sea6MgAplUb+YmiKFdujR7Dh 9N6mjaOS8Rg07A2dvIluEBz28wzVShAMhloPpTiK76ybSHqIgaaDmKrRYjcH/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=d5oe4ax+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680991762; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TajsiM4QO16mND9oKQAKLa6N77xN8GXdGT/ZdjmuUJc=; b=H5gKoBIlKTAALYZVIQQSjldhk8oq+KAFrb7iqrZGyso762XwbyrorYPhnfSx1IqWKgnCkk uOiRVWbzt8ej0UHAZ8Po2Yk7zJ8F6kpUKYnLPby8by492I9AjHyQrOypOjX6eESMRtkpN0 W7Fo7yA4VOPuNhh9x2t9g8RiHlfZ0jR0lJ62J3hgQ98easJ5KBqRPodJb2QKl+LdNm6fGT vUuIeSPX33HB2VUwhzin1U9OlP6Yr0tX5sESAtiUNmFGVkKfjOw8Vq58IMOOpSJC/HNFRz yLFWMN4Fbelw7O2bwosqdrRMgH1XThVbABB6qgFXJT4N2ZJecgjlpiQptCvC6w== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=d5oe4ax+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.92 X-Spam-Score: -2.92 X-Migadu-Queue-Id: 63B5E35951 X-TUID: tUmSx1IQAQ5Y Hi! Nicolas Graves skribis: > Took me quite more time than I would've liked, but I have a usable > juliahub scheme import script! > > It seems there's still one edge case that isn't covered and revolves > around when Julia packagers don't properly tag their git repos (I've > only seen the case with SnoopPrecompile). There's the possibility to > rely on tree commit hashes from the General repository (since this is a > valid way to identify/store a git repo), but that needs some major > changes in the way latest-repository-commit works. Otherwise, it needs > to be done by hand. It might also not work for subpackages in > directories that are up-to-date on juliahub but not yet on github, I > haven't met this case yet. > > I'm sending a patch series in the coming minutes. > > It's detailed since I haven't swauased all commits, for readability, but > I can squash it further if necessary. I=E2=80=99ll let Simon comment on the actual code since I=E2=80=99m not a J= ulia person. :-) Some more general comments: =E2=80=A2 Please make sure to document it in =E2=80=98doc/guix.texi=E2=80= =99 under =E2=80=9CInvoking guix import=E2=80=9D, following the same template as the others there. =E2=80=A2 Please write =E2=80=98tests/juliahub.scm=E2=80=99. I recommend= the same strategy as =E2=80=98tests/cpan.scm=E2=80=99, which is to mock the upstream HTTP se= rver. =E2=80=A2 Prefer (srfi srfi-41) over (ice-9 streams) (see rationale at ). =E2=80=A2 Prefer (srfi srfi-71) over (srfi srfi-11) for multiple-value bindings. Thanks, Ludo=E2=80=99.