all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Sergio Pastor Pérez" <sergio.pastorperez@outlook.es>
Cc: 64957@debbugs.gnu.org
Subject: [bug#64957] [PATCH] gnu: Add python-fontmake.
Date: Wed, 06 Sep 2023 14:43:48 -0400	[thread overview]
Message-ID: <87il8nqh0b.fsf@gmail.com> (raw)
In-Reply-To: <DU2P193MB21325F3C497682AB0E922457F3EFA@DU2P193MB2132.EURP193.PROD.OUTLOOK.COM> ("Sergio Pastor Pérez"'s message of "Wed, 06 Sep 2023 19:22:36 +0200")

Hi Sergio,

Sergio Pastor Pérez <sergio.pastorperez@outlook.es> writes:

> Hi, again.
>
> When I submitted the package I thought the checks where passing at least
> it was building without errors for version 3.4.0.  I see that you are
> using another build system and you updated the version. I'm trying your
> patch out and I see the failures during the check phase.
>
> At first sight I would not know how to fix any of this. I'm not very
> experienced with python in general. If I find the problem I will send an
> updated revision.

It's common for the PyPI archives to lack the tests files and/or for the
old build system (python-build-system) to not successfully run the test
suite and report success (which is what happens with 3.4.0 it seems).
So the package was "building" fine, but that doesn't mean much for
Python since it's interpreted -- running the test suite is important.

Often looking at what upstream does in their CI (github workflow for
example) can provide cues.  Or sometimes the test may try to access the
network.  Or sometimes they embed paths such as '/bin/sh' in the middle
of a file.  Or sometimes they need a writeable HOME, etc.

It's sometimes a bit of an effort to get the test suite going, but it's
what gives us confidence that it works well.

-- 
Thanks,
Maxim




      reply	other threads:[~2023-09-06 18:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-30 15:35 [bug#64957] [PATCH] gnu: Add python-fontmake Sergio Pastor Pérez
2023-07-30 15:45 ` [bug#64957] [PATCH vREVISION] " Sergio Pastor Pérez
2023-07-30 18:06   ` Hilton Chain via Guix-patches via
2023-07-30 18:06     ` Hilton Chain via Guix-patches via
2023-07-30 22:22 ` [bug#64957] [PATCH v2] gnu: Add fontmake Sergio Pastor Pérez
2023-07-31  7:25   ` Hilton Chain via Guix-patches via
2023-07-31  8:29 ` [bug#64957] [PATCH v3] " Sergio Pastor Pérez
2023-07-31 16:39   ` Hilton Chain via Guix-patches via
2023-08-01  7:05 ` [bug#64957] [PATCH v4] " Sergio Pastor Pérez
2023-09-06  4:52   ` bug#64957: [PATCH] gnu: Add python-fontmake Maxim Cournoyer
     [not found] ` <handler.64957.D64957.16939759387992.notifdone@debbugs.gnu.org>
2023-09-06  5:25   ` [bug#64957] " Maxim Cournoyer
2023-09-06 17:22     ` Sergio Pastor Pérez
2023-09-06 18:43       ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87il8nqh0b.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=64957@debbugs.gnu.org \
    --cc=sergio.pastorperez@outlook.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.