From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id SCM0OGyANWXK8wAA9RJhRA:P1 (envelope-from ) for ; Sun, 22 Oct 2023 22:05:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SCM0OGyANWXK8wAA9RJhRA (envelope-from ) for ; Sun, 22 Oct 2023 22:05:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB3E042AE7 for ; Sun, 22 Oct 2023 22:04:59 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=c8R9bBED; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=bNA1V1TS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698005100; a=rsa-sha256; cv=none; b=Nl1FqUrLAeSA4KYrpNYf1wasTugfujcZcA7XZZ6qfqLCpL7K5fBuBxXDmQwe290np8C0iK j03pjGXM8YsuOGhnkfotlXLhSLDpZC6HOCMxS04Eem/tWs72dZorWWXRx5fwFPoH2K+3H9 LHRes0ReaHj8Jjz0naXL6YId/IHlXluyq69QfZ9KMA5nJkK6YF71hPuaT8fWMnCarHr3yw IQffq1cKblDyNc4F/Xl7mPxb8WQK5UI8mql3LK33dm6hWuiyc4KVn6p7/yaSnV77AjmxZO NNnXVtJJt9yJFcsQd2j9B+sAOlX1tJp4tPwcF+gYA94IAb4429Fek3X0KQ1H5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=c8R9bBED; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=bNA1V1TS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698005100; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GwqMRzACtRZwgoMDm+GozstS3R/9TMFX6zwvBZYK2IA=; b=c6Joyj/+3QHuSQKyoZLfw0reBlMPG474uLO+344ltnkzVmLy4zbvBqm2ojzYaD8vMi3i8h m0nrcaJM924LHinoiogbh+gujoujVVunc+X5MrzszVGOW1mnBrOj5tOCUjC/AhxKh7QNsO DG9MM5BAv2/yT/qMPpU2WZHBuYw9uGJuo/8AHoob8h4uURZFthtmbZDYyuzlO0FcmlHm2A Pd12WKRradw/BjcUwFBKKzmTUVp5gp0Dc6/+KiOm16FfmDvCYWuaFwom+cZYGvDRz3Opdu mMTsw0FKmgY+lfxtZGg2AukQQRPvEMzJlzjbYcXYoqODWtz64gDkLKoJzZJ4DA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quege-000178-4Z; Sun, 22 Oct 2023 16:04:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quegb-00016H-FN for guix-patches@gnu.org; Sun, 22 Oct 2023 16:04:33 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quegb-0004EB-7h for guix-patches@gnu.org; Sun, 22 Oct 2023 16:04:33 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1queh3-0001JN-O3 for guix-patches@gnu.org; Sun, 22 Oct 2023 16:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 Oct 2023 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.16980050444906 (code B ref 66436); Sun, 22 Oct 2023 20:05:01 +0000 Received: (at 66436) by debbugs.gnu.org; 22 Oct 2023 20:04:04 +0000 Received: from localhost ([127.0.0.1]:48298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1queg8-0001Gz-0J for submit@debbugs.gnu.org; Sun, 22 Oct 2023 16:04:04 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1queg6-0001G8-DM for 66436@debbugs.gnu.org; Sun, 22 Oct 2023 16:04:03 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2EF225C01B3; Sun, 22 Oct 2023 16:03:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 22 Oct 2023 16:03:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1698005008; x=1698091408; bh=GwqMRzACtRZwgoMDm+GozstS3R/9TMFX6zw vBZYK2IA=; b=c8R9bBEDoACoBgV9GVWXag25QMq+OQrdZaJw/74xWTspxTD1Ofr k7rb7+uU5ClC9ZgWrz3f/JU0owyy0Pug04g0tSCF4A0Guf/KiEVJ9C9rD6DOUCTB 43IzgjFOPioyllRvwruhbfNsZtZjbUes/ABsEyZIQ2hgnZ/o+0Djh95tDm8IdUFx gaATfKBW2SQupIQlKwtJh8IsPu7d8Y+SU5e19dPYGApttERQrn8l/0pUNQ4WnRzz 1GlqZ7TjxBN10K1s10u87hp7L3bFooNp03QetAeHV2oqMyRAIF2d1UuSNSv13Yk0 jKmnK0DKxkjstzH2kjerBRQ/UB6FtREnsNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698005008; x=1698091408; bh=GwqMRzACtRZwgoMDm+GozstS3R/9TMFX6zw vBZYK2IA=; b=bNA1V1TS1ZYHSyXXUx/S6y0Ul0zSGpBSvh/gKgNG3qY5jhUkukm yenOVguyA8h9GMRRYTYRbcTIr/VLkWTKuzPpdRQdYjsSMTfU5f11EdC2hsyPkzBZ oTh5G/wG0t/0uUbn/+Lz5W7PEpWWRBMjPdHLuRvw3LEY58+WzofUV5+wqonuzIAj iw7hKl75VYdkJGaq2khqYNJIq3Ir5Yj7gI94pzIHO9hmo/jb9yeQEMMDayids1qn PusaONubwbItF33NLsMUeqY6pEAye79aFzuzfxFEQptmpMVPlIIVGp9hb5E0i+I1 loexa5pxcfzeQUfFV42m4VIRMW7Cx58TlRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrkeeggdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeeiudeuheeviedtleelheeivedutdejgfevhfdvtedvudel hfdthedvvddtieehkeenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhi vghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 22 Oct 2023 16:03:26 -0400 (EDT) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-Reply-To: <87r0logap6.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 20 Oct 2023 19:01:41 -0400") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> Date: Sun, 22 Oct 2023 22:03:12 +0200 Message-ID: <87il6ybf27.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -0.67 X-Spam-Score: -0.67 X-Migadu-Queue-Id: BB3E042AE7 X-TUID: wmSDPe8Z2zU9 Hi Maxim, Maxim Cournoyer writes: >> 1. What should the reviewer do with old-style patches, like the ones >> that don't use G-Expressions? Should we tell the submitter to use >> them when possible or is it only a matter of style that is up to the >> submitter? Obviously they are hard to grasp for newcomers. >> >> It's probably good for newcomers if we teach them how to use >> G-Expressions but we don't really have time to do so, given the >> number of patches waiting to be reviewed. >> >> This question could be extended to style issues. Like using %var >> versus var. > > I think we should now make sure all new submissions use the current > style; if they aren't we can demand of the contributors to adjust it. > There is a blog post and enough examples in the code base already that > should make this not too difficult. Are you referring to this one? https://guix.gnu.org/en/blog/2023/dissecting-guix-part-3-g-expressions/ >> 2. What should the reviewer do when only small changes are required? >> The reviewer could do these changes in seconds whereas asking for a >> new revision could take days. These changes could be indentation >> fixes, removing of unused code, but they could also be more >> substantial, like adding a missing `file-name` field. Or changing >> old-style to G-Expressions? >> >> If the reviewer makes such changes and pushes them right away, I >> imagine they should be documented and explained. > > +Perhaps the biggest action you can do to help GNU Guix grow as a project > +is to review the work contributed by others. You do not need to be a > +committer to do so; applying, reading the source, building, linting and > +running other people's series and sharing your comments about your > +experience will give some confidence to committers, and should result in > +the proposed change being merged faster. > > So it does mention trying out the software ("running"). Yes indeed! I didn't see it. Thanks for your reply! Cl=C3=A9ment